From b616e74ceb3fbff6874a8aa97a5f381f5f53f9d5 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Tue, 28 Sep 2021 00:39:52 +0200 Subject: [PATCH] refactor(bazel): no longer generate VE shims for other workspaces by default (#43431) We should no longer generate VE shims for workspaces which are not named `angular`. The default is Ivy compilation and this should be opt-in. The components repository for example does not need any shims as it is using Ivy for the common development workflows. PR Close #43431 --- packages/bazel/src/ng_module/ng_module.bzl | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/bazel/src/ng_module/ng_module.bzl b/packages/bazel/src/ng_module/ng_module.bzl index 3868d237909..b268c3503a7 100644 --- a/packages/bazel/src/ng_module/ng_module.bzl +++ b/packages/bazel/src/ng_module/ng_module.bzl @@ -307,12 +307,8 @@ def _expected_outs(ctx): # Determines if we need to generate View Engine shims (.ngfactory and .ngsummary files) def _generate_ve_shims(ctx): - # we are checking the workspace name here, because otherwise this would be a breaking change - # (the shims used to be on by default) - # we can remove this check once angular/components and angular/angular-cli repos no longer depend - # on the presence of shims, or if they explicitly opt-in to their generation via ng_modules' generate_ve_shims attr return _is_bazel() and _is_view_engine_enabled(ctx) or ( - getattr(ctx.attr, "generate_ve_shims", False) == True or ctx.workspace_name != "angular" + getattr(ctx.attr, "generate_ve_shims", False) == True ) def _ngc_tsconfig(ctx, files, srcs, **kwargs):