refactor: remove TODOs which have been corrected (#63421)

Remove TODOs which were addressed but the comment was not removed

PR Close #63421
This commit is contained in:
Joey Perrott
2025-08-27 15:59:02 +00:00
committed by Andrew Kushnir
parent 0133964ff4
commit b4ae94d5ef
5 changed files with 1 additions and 12 deletions
@@ -35,7 +35,6 @@ describe('ExampleViewer', () => {
await TestBed.configureTestingModule({
imports: [ExampleViewer],
providers: [
// TODO: Find why tests warn that zone.js is still loaded
provideZonelessChangeDetection(),
{provide: EXAMPLE_VIEWER_CONTENT_LOADER, useValue: exampleContentSpy},
{provide: ActivatedRoute, useValue: {snapshot: {fragment: 'fragment'}}},
@@ -103,13 +103,6 @@ async function main() {
const [srcs, outputFilenameExecRootRelativePath] = rawParamLines;
// TODO: Remove when we are using Bazel v6+
// On RBE, the output directory is not created properly due to a bug.
// https://github.com/bazelbuild/bazel/commit/4310aeb36c134e5fc61ed5cdfdf683f3e95f19b7.
if (!existsSync(outputFilenameExecRootRelativePath)) {
mkdirSync(outputFilenameExecRootRelativePath, {recursive: true});
}
// Docs rendering happens in three phases that occur here:
// 1) Aggregate all the raw extracted doc info.
// 2) Transform the raw data to a renderable state.
+1 -1
View File
@@ -1,7 +1,7 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
"types": ["jasmine", "node"],
"types": ["node"],
"paths": {}
}
}
-2
View File
@@ -25,12 +25,10 @@ angular_jasmine_test(
data = [
":test_lib",
],
flaky = True, # TODO: figure out why one of the transferCache tests is flaky
)
ng_web_test_suite(
name = "test_web",
flaky = True, # TODO: figure out why one of the transferCache tests is flaky
deps = [
":test_lib",
],
@@ -272,7 +272,6 @@ describe('TransferCache', () => {
makeRequestAndExpectOne('/test-1?foo=1', 'foo', {method: 'POST'});
});
// TODO: Investigate why this test is flaky
it('should cache POST with the transferCache option', () => {
makeRequestAndExpectOne('/test-1?foo=1', 'foo', {method: 'POST', transferCache: true});
makeRequestAndExpectNone('/test-1?foo=1', 'POST', {transferCache: true});