From b413b628568fac70cc1861682649deef62dfcee2 Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Mon, 18 Aug 2025 15:01:12 +0000 Subject: [PATCH] build: update the failure message with the correct command (#63219) Update the failure message for compliance tests to use the correct command for updating the goldens PR Close #63219 --- packages/compiler-cli/test/compliance/README.md | 2 +- .../compiler-cli/test/compliance/linked/linked_compile_spec.ts | 2 +- .../test/compliance/test_helpers/check_expectations.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/compiler-cli/test/compliance/README.md b/packages/compiler-cli/test/compliance/README.md index 75db0115f37..10b91b81097 100644 --- a/packages/compiler-cli/test/compliance/README.md +++ b/packages/compiler-cli/test/compliance/README.md @@ -186,7 +186,7 @@ the generated partial output, we must update the `GOLDEN_PARTIAL.js` file. This is done by running a specific bazel rule of the form: ```sh -bazel run //packages/compiler-cli/test/compliance/test_cases:.golden.update +bazel run //packages/compiler-cli/test/compliance/test_cases:.golden ``` where to replace `` with the path (relative to `test_cases`) of the directory diff --git a/packages/compiler-cli/test/compliance/linked/linked_compile_spec.ts b/packages/compiler-cli/test/compliance/linked/linked_compile_spec.ts index 8932d98067f..ec710dd6252 100644 --- a/packages/compiler-cli/test/compliance/linked/linked_compile_spec.ts +++ b/packages/compiler-cli/test/compliance/linked/linked_compile_spec.ts @@ -43,7 +43,7 @@ function linkPartials(fileSystem: FileSystem, test: ComplianceTest): CompileResu throw new Error( 'Golden partial does not exist for this test\n' + 'Try generating it by running:\n' + - `bazel run //packages/compiler-cli/test/compliance/test_cases:${test.relativePath}.golden.update`, + `bazel run //packages/compiler-cli/test/compliance/test_cases:${test.relativePath}.golden`, ); } const partialFile = fileSystem.readFile(goldenPartialPath); diff --git a/packages/compiler-cli/test/compliance/test_helpers/check_expectations.ts b/packages/compiler-cli/test/compliance/test_helpers/check_expectations.ts index ac152ca328e..ce3a363dbd2 100644 --- a/packages/compiler-cli/test/compliance/test_helpers/check_expectations.ts +++ b/packages/compiler-cli/test/compliance/test_helpers/check_expectations.ts @@ -58,7 +58,7 @@ export function checkExpectations( `The generated file at ${generatedPath} does not exist.\n` + 'Perhaps there is no matching input source file in the TEST_CASES.json file for this test case.\n' + 'Or maybe you need to regenerate the GOLDEN_PARTIAL.js file by running:\n\n' + - ` pnpm bazel run //packages/compiler-cli/test/compliance/test_cases:${testPath}.golden.update`, + ` pnpm bazel run //packages/compiler-cli/test/compliance/test_cases:${testPath}.golden`, ); // Clear the stack so that we get a nice error message error.stack = '';