From af1f8f84291b524d2bce7e36b080448192a7cd9f Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Fri, 15 Oct 2021 13:45:56 -0700 Subject: [PATCH] ci: remove saucelabs view engine tests (#43862) Remove the view engine specific saucelabs test job and associated tags/tooling as view engine is no longer being tested on CI. PR Close #43862 --- .circleci/config.yml | 41 ++++----------------------------- packages/forms/test/BUILD.bazel | 2 +- tools/saucelabs/README.md | 12 ++-------- 3 files changed, 7 insertions(+), 48 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 4153b6651f7..1bc5ffb6656 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -341,7 +341,7 @@ jobs: destination: core/todo/bundle.br # NOTE: This is currently limited to master builds only. See the `monitoring` configuration. - saucelabs_view_engine: + saucelabs: executor: name: default-executor # In order to avoid the bottleneck of having a slow host machine, we acquire a better @@ -353,35 +353,11 @@ jobs: - init_environment - init_saucelabs_environment - run: - name: Run Bazel tests on Saucelabs with ViewEngine + name: Run Bazel tests on Saucelabs # See /tools/saucelabs/README.md for more info command: | yarn bazel run //tools/saucelabs:sauce_service_setup - TESTS=$(./node_modules/.bin/bazelisk query --output label '(kind(karma_web_test, ...) intersect attr("tags", "saucelabs", ...)) except attr("tags", "ivy-only", ...) except attr("tags", "fixme-saucelabs-ve", ...)') - yarn bazel test --config=saucelabs --config=view-engine ${TESTS} - yarn bazel run //tools/saucelabs:sauce_service_stop - no_output_timeout: 40m - - notify_webhook_on_fail: - webhook_url_env_var: SLACK_DEV_INFRA_CI_FAILURES_WEBHOOK_URL - - # NOTE: This is currently limited to master builds only. See the `monitoring` configuration. - saucelabs_ivy: - executor: - name: default-executor - # In order to avoid the bottleneck of having a slow host machine, we acquire a better - # container for this job. This is necessary because we launch a lot of browsers concurrently - # and therefore the tunnel and Karma need to process a lot of file requests and tests. - resource_class: xlarge - steps: - - custom_attach_workspace - - init_environment - - init_saucelabs_environment - - run: - name: Run Bazel tests on Saucelabs with Ivy - # See /tools/saucelabs/README.md for more info - command: | - yarn bazel run //tools/saucelabs:sauce_service_setup - TESTS=$(./node_modules/.bin/bazelisk query --output label '(kind(karma_web_test, ...) intersect attr("tags", "saucelabs", ...)) except attr("tags", "view-engine-only", ...) except attr("tags", "fixme-saucelabs-ivy", ...)') + TESTS=$(./node_modules/.bin/bazelisk query --output label '(kind(karma_web_test, ...) intersect attr("tags", "saucelabs", ...)) except attr("tags", "view-engine-only", ...) except attr("tags", "fixme-saucelabs", ...)') yarn bazel test --config=saucelabs ${TESTS} yarn bazel run //tools/saucelabs:sauce_service_stop no_output_timeout: 40m @@ -888,16 +864,7 @@ workflows: - aio_monitoring_next: requires: - setup - - saucelabs_ivy: - # Testing saucelabs via Bazel currently taking longer than the legacy saucelabs job as it - # each karma_web_test target is provisioning and tearing down browsers which is adding - # a lot of overhead. Running once daily on master only to avoid wasting resources and - # slowing down CI for PRs. - # TODO: Run this job on all branches (including PRs) once karma_web_test targets can - # share provisioned browsers and we can remove the legacy saucelabs job. - requires: - - setup - - saucelabs_view_engine: + - saucelabs: # Testing saucelabs via Bazel currently taking longer than the legacy saucelabs job as it # each karma_web_test target is provisioning and tearing down browsers which is adding # a lot of overhead. Running once daily on master only to avoid wasting resources and diff --git a/packages/forms/test/BUILD.bazel b/packages/forms/test/BUILD.bazel index 8be33e239ce..525cba5a080 100644 --- a/packages/forms/test/BUILD.bazel +++ b/packages/forms/test/BUILD.bazel @@ -42,7 +42,7 @@ karma_web_test_suite( # IE 11.0.0 (Windows 8.1.0.0) template-driven forms integration tests basic functionality should report properties which are written outside of template bindings FAILED # InvalidStateError: InvalidStateError # ``` - "fixme-saucelabs-ivy", + "fixme-saucelabs", ], deps = [ ":test_lib", diff --git a/tools/saucelabs/README.md b/tools/saucelabs/README.md index e09556a8c1e..6da58ed2e65 100644 --- a/tools/saucelabs/README.md +++ b/tools/saucelabs/README.md @@ -47,19 +47,11 @@ Note, this option will also prevent bazel from using the test cache and will for `bazel query` is required gather up all karma saucelabs test labels so they can be run in one command as they are tagged `manual`. -Running all ViewEngine karma tests in Saucelabs: +Running all karma tests in Saucelabs: ``` bash yarn bazel run //tools/saucelabs:sauce_service_setup -TESTS=$(./node_modules/.bin/bazelisk query --output label '(kind(karma_web_test, ...) intersect attr("tags", "saucelabs", ...)) except attr("tags", "ivy-only", ...) except attr("tags", "fixme-saucelabs-ve", ...)') -yarn bazel test --config=saucelabs --config=view-engine ${TESTS} -``` - -Running all Ivy karma tests in Saucelabs: - -``` bash -yarn bazel run //tools/saucelabs:sauce_service_setup -TESTS=$(./node_modules/.bin/bazelisk query --output label '(kind(karma_web_test, ...) intersect attr("tags", "saucelabs", ...)) except attr("tags", "view-engine-only", ...) except attr("tags", "fixme-saucelabs-ivy", ...)') +TESTS=$(./node_modules/.bin/bazelisk query --output label '(kind(karma_web_test, ...) intersect attr("tags", "saucelabs", ...)) except attr("tags", "view-engine-only", ...) except attr("tags", "fixme-saucelabs", ...)') yarn bazel test --config=saucelabs ${TESTS} ```