From a5f8ee9b094e3768545214e0342b38a41f118133 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Wed, 26 Jun 2019 17:53:36 +0200 Subject: [PATCH] build: mark all e2e test suites as flaky within bazel (#16376) Marks all e2e test suites as flaky with Bazel's `flaky` rule attribute. This should improve CI stability as e2e tests can sometimes fail due to browser crashes, port collisions. --- src/cdk-experimental/scrolling/BUILD.bazel | 3 +-- src/cdk-experimental/testing/BUILD.bazel | 3 +-- src/cdk/overlay/BUILD.bazel | 2 +- src/material-experimental/mdc-button/BUILD.bazel | 3 +-- src/material-experimental/mdc-card/BUILD.bazel | 3 +-- src/material-experimental/mdc-checkbox/BUILD.bazel | 3 +-- src/material-experimental/mdc-chips/BUILD.bazel | 3 +-- src/material-experimental/mdc-menu/BUILD.bazel | 3 +-- src/material-experimental/mdc-radio/BUILD.bazel | 3 +-- .../mdc-slide-toggle/BUILD.bazel | 3 +-- src/material-experimental/mdc-tabs/BUILD.bazel | 3 +-- src/material/button-toggle/BUILD.bazel | 2 +- src/material/button/BUILD.bazel | 2 +- src/material/card/BUILD.bazel | 3 +-- src/material/checkbox/BUILD.bazel | 2 +- src/material/dialog/BUILD.bazel | 2 +- src/material/expansion/BUILD.bazel | 2 +- src/material/grid-list/BUILD.bazel | 2 +- src/material/icon/BUILD.bazel | 2 +- src/material/input/BUILD.bazel | 2 +- src/material/list/BUILD.bazel | 2 +- src/material/menu/BUILD.bazel | 2 +- src/material/progress-bar/BUILD.bazel | 2 +- src/material/progress-spinner/BUILD.bazel | 2 +- src/material/radio/BUILD.bazel | 2 +- src/material/sidenav/BUILD.bazel | 2 +- src/material/slide-toggle/BUILD.bazel | 2 +- src/material/stepper/BUILD.bazel | 2 +- src/material/tabs/BUILD.bazel | 2 +- src/material/toolbar/BUILD.bazel | 2 +- tools/defaults.bzl | 11 ++++++++++- 31 files changed, 40 insertions(+), 42 deletions(-) diff --git a/src/cdk-experimental/scrolling/BUILD.bazel b/src/cdk-experimental/scrolling/BUILD.bazel index fc971620c50..750444dc0d7 100644 --- a/src/cdk-experimental/scrolling/BUILD.bazel +++ b/src/cdk-experimental/scrolling/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") -load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite") +load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite", "protractor_web_test_suite") ng_module( name = "scrolling", diff --git a/src/cdk-experimental/testing/BUILD.bazel b/src/cdk-experimental/testing/BUILD.bazel index 345c147669a..f3ae529f99a 100644 --- a/src/cdk-experimental/testing/BUILD.bazel +++ b/src/cdk-experimental/testing/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("//tools:defaults.bzl", "ng_module", "ng_web_test_suite") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") +load("//tools:defaults.bzl", "ng_module", "ng_web_test_suite", "protractor_web_test_suite") ng_module( name = "testing", diff --git a/src/cdk/overlay/BUILD.bazel b/src/cdk/overlay/BUILD.bazel index 54bb06dd0b5..513fc2a3231 100644 --- a/src/cdk/overlay/BUILD.bazel +++ b/src/cdk/overlay/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material-experimental/mdc-button/BUILD.bazel b/src/material-experimental/mdc-button/BUILD.bazel index 98b7d410ca9..783d81f2910 100644 --- a/src/material-experimental/mdc-button/BUILD.bazel +++ b/src/material-experimental/mdc-button/BUILD.bazel @@ -1,8 +1,7 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") -load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module") +load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "protractor_web_test_suite") ng_module( name = "mdc-button", diff --git a/src/material-experimental/mdc-card/BUILD.bazel b/src/material-experimental/mdc-card/BUILD.bazel index b9dbd33769a..f344b391137 100644 --- a/src/material-experimental/mdc-card/BUILD.bazel +++ b/src/material-experimental/mdc-card/BUILD.bazel @@ -1,8 +1,7 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") -load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module") +load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "protractor_web_test_suite") ng_module( name = "mdc-card", diff --git a/src/material-experimental/mdc-checkbox/BUILD.bazel b/src/material-experimental/mdc-checkbox/BUILD.bazel index 89c4670e039..572cfdfa629 100644 --- a/src/material-experimental/mdc-checkbox/BUILD.bazel +++ b/src/material-experimental/mdc-checkbox/BUILD.bazel @@ -1,8 +1,7 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") -load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite", "ts_library") +load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite", "protractor_web_test_suite", "ts_library") ng_module( name = "mdc-checkbox", diff --git a/src/material-experimental/mdc-chips/BUILD.bazel b/src/material-experimental/mdc-chips/BUILD.bazel index 4331d7b7738..816feb9f42d 100644 --- a/src/material-experimental/mdc-chips/BUILD.bazel +++ b/src/material-experimental/mdc-chips/BUILD.bazel @@ -1,8 +1,7 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") -load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module") +load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "protractor_web_test_suite") ng_module( name = "mdc-chips", diff --git a/src/material-experimental/mdc-menu/BUILD.bazel b/src/material-experimental/mdc-menu/BUILD.bazel index cabdbdf55b4..d6f1da62385 100644 --- a/src/material-experimental/mdc-menu/BUILD.bazel +++ b/src/material-experimental/mdc-menu/BUILD.bazel @@ -1,8 +1,7 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") -load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite") +load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite", "protractor_web_test_suite") ng_module( name = "mdc-menu", diff --git a/src/material-experimental/mdc-radio/BUILD.bazel b/src/material-experimental/mdc-radio/BUILD.bazel index a72d2d794fb..de20a992edc 100644 --- a/src/material-experimental/mdc-radio/BUILD.bazel +++ b/src/material-experimental/mdc-radio/BUILD.bazel @@ -1,8 +1,7 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") -load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module") +load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "protractor_web_test_suite") ng_module( name = "mdc-radio", diff --git a/src/material-experimental/mdc-slide-toggle/BUILD.bazel b/src/material-experimental/mdc-slide-toggle/BUILD.bazel index 96199435bcb..53e467aa44c 100644 --- a/src/material-experimental/mdc-slide-toggle/BUILD.bazel +++ b/src/material-experimental/mdc-slide-toggle/BUILD.bazel @@ -1,8 +1,7 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") -load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite") +load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite", "protractor_web_test_suite") ng_module( name = "mdc-slide-toggle", diff --git a/src/material-experimental/mdc-tabs/BUILD.bazel b/src/material-experimental/mdc-tabs/BUILD.bazel index 071271e738c..be013849d4c 100644 --- a/src/material-experimental/mdc-tabs/BUILD.bazel +++ b/src/material-experimental/mdc-tabs/BUILD.bazel @@ -1,8 +1,7 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") -load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module") +load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "protractor_web_test_suite") ng_module( name = "mdc-tabs", diff --git a/src/material/button-toggle/BUILD.bazel b/src/material/button-toggle/BUILD.bazel index ebce74010c5..007bbf7b19f 100644 --- a/src/material/button-toggle/BUILD.bazel +++ b/src/material/button-toggle/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material/button/BUILD.bazel b/src/material/button/BUILD.bazel index 1db49ab3790..39d41cd9d3d 100644 --- a/src/material/button/BUILD.bazel +++ b/src/material/button/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material/card/BUILD.bazel b/src/material/card/BUILD.bazel index e3253c5ae17..3f501d05020 100644 --- a/src/material/card/BUILD.bazel +++ b/src/material/card/BUILD.bazel @@ -1,8 +1,7 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") -load("//tools:defaults.bzl", "markdown_to_html", "ng_e2e_test_library", "ng_module") +load("//tools:defaults.bzl", "markdown_to_html", "ng_e2e_test_library", "ng_module", "protractor_web_test_suite") ng_module( name = "card", diff --git a/src/material/checkbox/BUILD.bazel b/src/material/checkbox/BUILD.bazel index 865abbb5253..e8340ee89ad 100644 --- a/src/material/checkbox/BUILD.bazel +++ b/src/material/checkbox/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material/dialog/BUILD.bazel b/src/material/dialog/BUILD.bazel index e1d1ee67cc0..fdaa73ac6ae 100644 --- a/src/material/dialog/BUILD.bazel +++ b/src/material/dialog/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material/expansion/BUILD.bazel b/src/material/expansion/BUILD.bazel index 539417c0adc..ef2999a4dfc 100644 --- a/src/material/expansion/BUILD.bazel +++ b/src/material/expansion/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material/grid-list/BUILD.bazel b/src/material/grid-list/BUILD.bazel index 2b9eee92b87..aa68e7e2937 100644 --- a/src/material/grid-list/BUILD.bazel +++ b/src/material/grid-list/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material/icon/BUILD.bazel b/src/material/icon/BUILD.bazel index 9ba074527d8..019f81503bf 100644 --- a/src/material/icon/BUILD.bazel +++ b/src/material/icon/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material/input/BUILD.bazel b/src/material/input/BUILD.bazel index 76ada38ba38..63c77468426 100644 --- a/src/material/input/BUILD.bazel +++ b/src/material/input/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material/list/BUILD.bazel b/src/material/list/BUILD.bazel index 60d5c260545..e53a6efd9e0 100644 --- a/src/material/list/BUILD.bazel +++ b/src/material/list/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material/menu/BUILD.bazel b/src/material/menu/BUILD.bazel index 8ca0040bdfc..18fb2e73c1d 100644 --- a/src/material/menu/BUILD.bazel +++ b/src/material/menu/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material/progress-bar/BUILD.bazel b/src/material/progress-bar/BUILD.bazel index 3c9b8a956fb..995fffbca5b 100644 --- a/src/material/progress-bar/BUILD.bazel +++ b/src/material/progress-bar/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material/progress-spinner/BUILD.bazel b/src/material/progress-spinner/BUILD.bazel index a93da25d5ef..e5cba1665ec 100644 --- a/src/material/progress-spinner/BUILD.bazel +++ b/src/material/progress-spinner/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material/radio/BUILD.bazel b/src/material/radio/BUILD.bazel index 82e0efa8fd9..39d0d0f0ca1 100644 --- a/src/material/radio/BUILD.bazel +++ b/src/material/radio/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material/sidenav/BUILD.bazel b/src/material/sidenav/BUILD.bazel index 70a5a154a49..67127efb302 100644 --- a/src/material/sidenav/BUILD.bazel +++ b/src/material/sidenav/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material/slide-toggle/BUILD.bazel b/src/material/slide-toggle/BUILD.bazel index 58852976d5d..370eba14eab 100644 --- a/src/material/slide-toggle/BUILD.bazel +++ b/src/material/slide-toggle/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material/stepper/BUILD.bazel b/src/material/stepper/BUILD.bazel index 45b8865a2ab..524b7da1b31 100644 --- a/src/material/stepper/BUILD.bazel +++ b/src/material/stepper/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material/tabs/BUILD.bazel b/src/material/tabs/BUILD.bazel index bb1160d88f0..3c22021df36 100644 --- a/src/material/tabs/BUILD.bazel +++ b/src/material/tabs/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/src/material/toolbar/BUILD.bazel b/src/material/toolbar/BUILD.bazel index bfb9be95177..4290f924c88 100644 --- a/src/material/toolbar/BUILD.bazel +++ b/src/material/toolbar/BUILD.bazel @@ -1,7 +1,6 @@ package(default_visibility = ["//visibility:public"]) load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") -load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite") load( "//tools:defaults.bzl", "markdown_to_html", @@ -9,6 +8,7 @@ load( "ng_module", "ng_test_library", "ng_web_test_suite", + "protractor_web_test_suite", ) ng_module( diff --git a/tools/defaults.bzl b/tools/defaults.bzl index da13f2f40e6..979d2937bd4 100644 --- a/tools/defaults.bzl +++ b/tools/defaults.bzl @@ -1,6 +1,6 @@ # Re-export of Bazel rules with repository-wide defaults -load("@npm_angular_bazel//:index.bzl", _ng_module = "ng_module", _ng_package = "ng_package") +load("@npm_angular_bazel//:index.bzl", _ng_module = "ng_module", _ng_package = "ng_package", _protractor_web_test_suite = "protractor_web_test_suite") load("@npm_bazel_jasmine//:index.bzl", _jasmine_node_test = "jasmine_node_test") load("@npm_bazel_typescript//:defs.bzl", _ts_library = "ts_library") load("@npm_bazel_karma//:defs.bzl", _ts_web_test_suite = "ts_web_test_suite") @@ -122,6 +122,15 @@ def ts_web_test_suite(deps = [], srcs = [], **kwargs): **kwargs ) +# Protractor web test targets are flaky by default as the browser can sometimes +# crash (e.g. due to too much concurrency). Passing the "flaky" flag ensures that +# Bazel detects flaky tests and re-runs these a second time in case of a flake. +def protractor_web_test_suite(flaky = True, **kwargs): + _protractor_web_test_suite( + flaky = flaky, + **kwargs + ) + def ng_web_test_suite(deps = [], static_css = [], bootstrap = [], **kwargs): # Always include a prebuilt theme in the test suite because otherwise tests, which depend on CSS # that is needed for measuring, will unexpectedly fail. Also always adding a prebuilt theme