From a589aff3e4797beabfeef0c2c55ca689143773fd Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Mon, 11 Oct 2021 22:01:48 +0200 Subject: [PATCH] ci: re-enable dev-app building in components-repo-unit-tests job (#43798) Re-enables the building of the `src/dev-app` package in the components repo when the components-repo-unit-test job runs. We previously disabled the dev-app because it was not compatible with template typechecking of ngtsc. This should be fixed now and can re-enable it. This could be valuable for having some actual real test scenarios of type checking. PR Close #43798 --- scripts/ci/run_angular_components_unit_tests.sh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/scripts/ci/run_angular_components_unit_tests.sh b/scripts/ci/run_angular_components_unit_tests.sh index fe37024f060..17596b297af 100755 --- a/scripts/ci/run_angular_components_unit_tests.sh +++ b/scripts/ci/run_angular_components_unit_tests.sh @@ -13,6 +13,5 @@ cd ${COMPONENTS_REPO_TMP_DIR} # Create a symlink for the Bazel binary installed through NPM, as running through Yarn introduces OOM errors. ./scripts/circleci/setup_bazel_binary.sh -# Now actually run the tests. The dev-app and all its subpackages are excluded as they fail -# to compile due to limitations in Ivy's type checker (see FW-1352 and FW-1433) -bazel test --build_tag_filters=-docs-package,-e2e,-browser:firefox-local --test_tag_filters=-e2e,-browser:firefox-local -- src/... -src/dev-app/... +# Now actually run the tests. +bazel test --build_tag_filters=-docs-package,-e2e,-browser:firefox-local --test_tag_filters=-e2e,-browser:firefox-local -- src/...