From a3189e740b4b632dc7ca61f47c7c5ef5814a2d07 Mon Sep 17 00:00:00 2001 From: Robert Messerle Date: Thu, 17 Mar 2016 10:40:02 -0700 Subject: [PATCH] fix(e2e): screenshot changes will display proper error message closes #191 closes #192 Closes #194 --- e2e/_screenshot.js | 6 +++--- e2e/index.e2e.js | 2 +- screenshots/demo page: index.screenshot.png | 3 +++ screenshots/initial state.screenshot.png | 3 --- 4 files changed, 7 insertions(+), 7 deletions(-) create mode 100644 screenshots/demo page: index.screenshot.png delete mode 100644 screenshots/initial state.screenshot.png diff --git a/e2e/_screenshot.js b/e2e/_screenshot.js index 3237c4dd2bc..dc646dbfc38 100644 --- a/e2e/_screenshot.js +++ b/e2e/_screenshot.js @@ -58,14 +58,14 @@ class Screenshot { let referenceScreenshot = mapnik.Image.open(this.path); this.overwriteExistingScreenshot(); if (referenceScreenshot.compare(this.png)) { - throw new Error(`screenshot "${this.id}" has changed.`); + throw `screenshot "${this.id}" has changed.`; } else { console.info('[STATUS] Screenshot has not changed'); } } catch (e) { - console.info(`[STATUS] No reference screenshot found`); + console.error(`[ERROR] `, e); this.overwriteExistingScreenshot(); - throw new Error(`screenshot "${this.id}" was not found.`); + throw e; } } diff --git a/e2e/index.e2e.js b/e2e/index.e2e.js index 4343ebec066..8248055d332 100644 --- a/e2e/index.e2e.js +++ b/e2e/index.e2e.js @@ -5,7 +5,7 @@ describe('hello, protractor', function () { browser.get('/'); it('should have a title', function () { expect(browser.getTitle()).toBe('Material2'); - screenshot('initial state'); + screenshot('demo page: index'); }); }); }); diff --git a/screenshots/demo page: index.screenshot.png b/screenshots/demo page: index.screenshot.png new file mode 100644 index 00000000000..7e15bbfe269 --- /dev/null +++ b/screenshots/demo page: index.screenshot.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:606958be9d1e0ec1cc3b5e361feee28d0b1bf52b0008c8afb0f03b21a5353a9e +size 23924 diff --git a/screenshots/initial state.screenshot.png b/screenshots/initial state.screenshot.png deleted file mode 100644 index a4f72cf2d5c..00000000000 --- a/screenshots/initial state.screenshot.png +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:ba69049fdfdcffda020560f862c301494783d79ae13dc2befc377d679402b152 -size 22610