From 89cad3fd1511def6ea9aa17c867f9872bf774f2c Mon Sep 17 00:00:00 2001 From: Kristiyan Kostadinov Date: Tue, 3 Jul 2018 20:34:37 +0200 Subject: [PATCH] fix(tabs): don't show focus indication for mouse focus (#11194) Similarly to other components, makes the tabs focus indication not to show for mouse focus. Fixes #11184. --- src/lib/tabs/BUILD.bazel | 1 + src/lib/tabs/_tabs-theme.scss | 8 +++++--- src/lib/tabs/tab-group.html | 2 +- src/lib/tabs/tab-nav-bar/tab-nav-bar.ts | 16 +++++++++++++++- src/lib/tabs/tabs-module.ts | 2 ++ 5 files changed, 24 insertions(+), 5 deletions(-) diff --git a/src/lib/tabs/BUILD.bazel b/src/lib/tabs/BUILD.bazel index c2cf6a13753..1e8a90b451f 100644 --- a/src/lib/tabs/BUILD.bazel +++ b/src/lib/tabs/BUILD.bazel @@ -21,6 +21,7 @@ ng_module( "//src/cdk/observers", "//src/cdk/portal", "//src/cdk/scrolling", + "//src/cdk/a11y", "@rxjs", ], tsconfig = "//src/lib:tsconfig-build.json", diff --git a/src/lib/tabs/_tabs-theme.scss b/src/lib/tabs/_tabs-theme.scss index 1c2a0d65aeb..7b8648a02b9 100644 --- a/src/lib/tabs/_tabs-theme.scss +++ b/src/lib/tabs/_tabs-theme.scss @@ -83,9 +83,11 @@ } @mixin _mat-tab-label-focus($tab-focus-color) { - .mat-tab-label:not(.mat-tab-disabled):focus, - .mat-tab-link:not(.mat-tab-disabled):focus { - background-color: mat-color($tab-focus-color, lighter, 0.3); + .mat-tab-label, + .mat-tab-link { + &.cdk-focused:not(.cdk-mouse-focused):not(.mat-tab-disabled) { + background-color: mat-color($tab-focus-color, lighter, 0.3); + } } } diff --git a/src/lib/tabs/tab-group.html b/src/lib/tabs/tab-group.html index 53599f721e2..1e730c837d8 100644 --- a/src/lib/tabs/tab-group.html +++ b/src/lib/tabs/tab-group.html @@ -3,7 +3,7 @@ [disableRipple]="disableRipple" (indexFocused)="_focusChanged($event)" (selectFocusedIndex)="selectedIndex = $event"> -