From 7d33af0400f84e71656daed949a350231d8d00a6 Mon Sep 17 00:00:00 2001 From: JoostK Date: Tue, 19 Oct 2021 22:36:00 +0200 Subject: [PATCH] test(compiler-cli): run i18n extraction tests using Ivy compiler (#43893) This commit re-enables the `extract_i18n` test target and updates the test to run with the Ivy compiler. PR Close #43893 --- packages/compiler-cli/test/BUILD.bazel | 9 ++------- packages/compiler-cli/test/extract_i18n_spec.ts | 3 --- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/packages/compiler-cli/test/BUILD.bazel b/packages/compiler-cli/test/BUILD.bazel index 8153a3740e7..3e646ab8977 100644 --- a/packages/compiler-cli/test/BUILD.bazel +++ b/packages/compiler-cli/test/BUILD.bazel @@ -42,17 +42,12 @@ jasmine_node_test( name = "extract_i18n", bootstrap = ["//tools/testing:node_es5"], data = [ - "@npm//@angular/core-12", - ], - tags = [ - # Disabled as the tests pertain to the old extraction tool only, whereas the Ivy extraction - # tool will likely work differently. - "view-engine-only", + "//packages/core:npm_package", ], deps = [ ":extract_i18n_lib", + "//packages/common:npm_package", "//packages/core", - "@npm//@angular/common-12", "@npm//yargs", ], ) diff --git a/packages/compiler-cli/test/extract_i18n_spec.ts b/packages/compiler-cli/test/extract_i18n_spec.ts index 4e77cced287..23e7cd71bd4 100644 --- a/packages/compiler-cli/test/extract_i18n_spec.ts +++ b/packages/compiler-cli/test/extract_i18n_spec.ts @@ -227,9 +227,6 @@ describe('extract_i18n command line', () => { "moduleResolution": "node", "lib": ["es6", "dom"], "typeRoots": ["node_modules/@types"] - }, - "angularCompilerOptions": { - "enableIvy": false } }`); });