From 78eace65471b36fdf75d6ffbb79f742ba0fa9add Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Thu, 24 Mar 2022 21:04:16 +0100 Subject: [PATCH] build: shorten partial compilation test case target names for windows (#45431) Shortens the partial compilation test case target names as the paths/ manifest paths in Bazel became too large, exceeding some Windows path length limits. Relevant context/resources: * https://angular-team.slack.com/archives/C02PARQNMC1/p1648137933069659 (internal) * https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=cmd * https://github.com/bazelbuild/rules_nodejs/pull/3215/files#r782271592 PR Close #45431 --- .../test/compliance/partial/partial_compliance_goldens.bzl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/compiler-cli/test/compliance/partial/partial_compliance_goldens.bzl b/packages/compiler-cli/test/compliance/partial/partial_compliance_goldens.bzl index 0967ebe587f..7115164cde2 100644 --- a/packages/compiler-cli/test/compliance/partial/partial_compliance_goldens.bzl +++ b/packages/compiler-cli/test/compliance/partial/partial_compliance_goldens.bzl @@ -6,7 +6,7 @@ def partial_compliance_golden(filePath): # Remove the "TEST_CASES.json" substring from the end of the provided path. path = filePath[:-len("/TEST_CASES.json")] - generate_partial_name = "generate_partial_for_%s" % path + generate_partial_name = "partial_%s" % path data = [ "//packages/compiler-cli/test/compliance/partial:generate_golden_partial_lib", "//packages/compiler-cli/test/compliance/test_cases", @@ -44,7 +44,7 @@ def partial_compliance_golden(filePath): name = "_generated_%s" % path, tool = generate_partial_name, testonly = True, - stdout = "%s/this_file_should_not_be_committed" % path, + stdout = "%s/_generated.js" % path, link_workspace_root = True, visibility = [":__pkg__"], data = [],