skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: update to Angular 4.3 (#6483)

Browse Source 
* feat: update to Angular 4.3

* Bumps the Angular requirement to 4.3. This is also a prerequisite to the Angular 5 update since we encountered the same errors there.
* Refactors the sidenav not to use a `Promise.resolve` for toggling the initial animation, because it was making it impossible to flush the animations in unit tests. The new simplified approach uses a property to pass the animation state.
* Fixes the nested menu test failures.
* Fixes a "changed after checked" error in the autocomplete demo app.

Relates to #6454.

* fix: e2e failures
This commit is contained in:
Kristiyan Kostadinov
2017-08-16 22:14:12 +02:00
committed by Andrew Seguin
parent 1807c5b8f7
commit 66da5973db
12 changed files with 204 additions and 149 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/components/menu-e2e.spec.ts
+2 -1
View File
@@ -76,7 +76,8 @@ describe('menu', () => {
it('should mirror classes on host to menu template in overlay', () => {
page.trigger().click();
expect(page.menu().getAttribute('class')).toContain('mat-menu-panel custom');
expect(page.menu().getAttribute('class')).toContain('mat-menu-panel');
expect(page.menu().getAttribute('class')).toContain('custom');
});
describe('keyboard events', () => {
e2e/components/sidenav-e2e.spec.ts
+2
View File
@@ -20,7 +20,9 @@ describe('sidenav', () => {
it('should close again', () => {
element(by.buttonText('Open sidenav')).click();
browser.sleep(50);
element(by.buttonText('Open sidenav')).click();
expect(sidenav.isDisplayed()).toBeFalsy();
});
});