From 665e667e2d75539d50d31c80d1883b91d6f985a0 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Mon, 19 Jun 2017 20:48:47 +0200 Subject: [PATCH] build: payload task fails if functions are down (#5217) It can happen that the firebase `payloadGithubStatus` function is temporary disabled because a deploy failed (for example due to deploying while function executes). This leads to a failure inside of the payload CI task because the task is trying to parse the body using JSON (which is not always a JSON response) It's not worth trying to parse the JSON value since it's only used for debugging and to give an insight what's going on in the functions. --- tools/gulp/tasks/payload.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/gulp/tasks/payload.ts b/tools/gulp/tasks/payload.ts index 2fd17e939bb..26f33b3ed90 100644 --- a/tools/gulp/tasks/payload.ts +++ b/tools/gulp/tasks/payload.ts @@ -127,7 +127,7 @@ async function updateGithubStatus(commitSha: string, packageName: string, packag if (err) { reject(`Dashboard Error ${err.toString()}`); } else { - console.info('Dashboard Response:', JSON.parse(body).message); + console.info(`Dashboard Response (${response.statusCode}): ${body}`); resolve(response.statusCode); } });