From 6531e4c3653456b4b41a2ffc3079bfe8635f360e Mon Sep 17 00:00:00 2001 From: Jessica Janiuk Date: Thu, 29 Feb 2024 11:55:59 -0500 Subject: [PATCH] ci: Add primitives configurations for ng-dev tools (#54662) This adds the configs to enable validators and google sync patterns for primitives sharing. PR Close #54662 --- .ng-dev/google-sync-config.json | 9 ++++++++- .ng-dev/pull-request.mts | 5 +++++ package.json | 2 +- yarn.lock | 7 ++++--- 4 files changed, 18 insertions(+), 5 deletions(-) diff --git a/.ng-dev/google-sync-config.json b/.ng-dev/google-sync-config.json index 1fe231d6684..4e0adfe916a 100644 --- a/.ng-dev/google-sync-config.json +++ b/.ng-dev/google-sync-config.json @@ -1,5 +1,12 @@ { - "syncedFilePatterns": ["LICENSE", "modules/benchmarks/**", "packages/**"], + "syncedFilePatterns": [ + "LICENSE", + "modules/benchmarks/**", + "packages/**" + ], + "separateFilePatterns": [ + "packages/core/primitives/**" + ], "alwaysExternalFilePatterns": [ "packages/*", "packages/bazel/*", diff --git a/.ng-dev/pull-request.mts b/.ng-dev/pull-request.mts index c56dbd71b04..344c28e3185 100644 --- a/.ng-dev/pull-request.mts +++ b/.ng-dev/pull-request.mts @@ -17,4 +17,9 @@ export const pullRequest: PullRequestConfig = { // the `bazel` package is not considered part of the public API so that features // can land in patch branches. targetLabelExemptScopes: ['dev-infra', 'docs-infra', 'bazel'], + // enables specific validations during the pull request merge process + validators: { + assertEnforceTested: true, + assertIsolatedSeparateFiles: true, + }, }; diff --git a/package.json b/package.json index cf94c2eba68..df497f79425 100644 --- a/package.json +++ b/package.json @@ -154,7 +154,7 @@ "@angular/animations": "^17.2.0-next", "@angular/build-tooling": "https://github.com/angular/dev-infra-private-build-tooling-builds.git#65f8e0021b37719f1d6352d0680c6b45a47a6b3a", "@angular/docs": "https://github.com/angular/dev-infra-private-docs-builds.git#5274bdd3611a27067888e9a93c0838ab776e43af", - "@angular/ng-dev": "https://github.com/angular/dev-infra-private-ng-dev-builds.git#c21f93acb618bcaeda52a8065e7b6c9242def182", + "@angular/ng-dev": "https://github.com/angular/dev-infra-private-ng-dev-builds.git#0126481d9074759b2d1c5be77f8a3c87e5c3c1e4", "@babel/helper-remap-async-to-generator": "^7.18.9", "@babel/plugin-proposal-async-generator-functions": "^7.20.7", "@bazel/bazelisk": "^1.7.5", diff --git a/yarn.lock b/yarn.lock index 8fb5dddcf48..15396468016 100644 --- a/yarn.lock +++ b/yarn.lock @@ -546,9 +546,9 @@ "@material/typography" "15.0.0-canary.7f224ddd4.0" tslib "^2.3.0" -"@angular/ng-dev@https://github.com/angular/dev-infra-private-ng-dev-builds.git#c21f93acb618bcaeda52a8065e7b6c9242def182": - version "0.0.0-c83e99a12397014162531ca125c94549db55dd84" - resolved "https://github.com/angular/dev-infra-private-ng-dev-builds.git#c21f93acb618bcaeda52a8065e7b6c9242def182" +"@angular/ng-dev@https://github.com/angular/dev-infra-private-ng-dev-builds.git#0126481d9074759b2d1c5be77f8a3c87e5c3c1e4": + version "0.0.0-b18378deb8556573a8dc7f841415260bccfba878" + resolved "https://github.com/angular/dev-infra-private-ng-dev-builds.git#0126481d9074759b2d1c5be77f8a3c87e5c3c1e4" dependencies: "@yarnpkg/lockfile" "^1.1.0" typescript "~4.9.0" @@ -15071,6 +15071,7 @@ select-hose@^2.0.0: integrity sha512-mEugaLK+YfkijB4fx0e6kImuJdCIt2LxCRcbEYPqRGCs4F2ogyfZU5IAZRdjCP8JPq2AtdNoC/Dux63d9Kiryg== "selenium-webdriver4@npm:selenium-webdriver@4.18.1", selenium-webdriver@^4.18.1: + name selenium-webdriver4 version "4.18.1" resolved "https://registry.yarnpkg.com/selenium-webdriver/-/selenium-webdriver-4.18.1.tgz#bcd19048b4aba5411edb7b5266d9390578fc7fed" integrity sha512-uP4OJ5wR4+VjdTi5oi/k8oieV2fIhVdVuaOPrklKghgS59w7Zz3nGa5gcG73VcU9EBRv5IZEBRhPr7qFJAj5mQ==