diff --git a/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_i18n/icu_logic/TEST_CASES.json b/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_i18n/icu_logic/TEST_CASES.json index 59001f39a92..f27688e7401 100644 --- a/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_i18n/icu_logic/TEST_CASES.json +++ b/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_i18n/icu_logic/TEST_CASES.json @@ -190,8 +190,7 @@ "verifyUniqueConsts" ] } - ], - "skipForTemplatePipeline": true + ] }, { "description": "should handle icus with named interpolations", diff --git a/packages/compiler/src/template/pipeline/src/phases/i18n_const_collection.ts b/packages/compiler/src/template/pipeline/src/phases/i18n_const_collection.ts index f195d9e0a9e..1dfa3d2061f 100644 --- a/packages/compiler/src/template/pipeline/src/phases/i18n_const_collection.ts +++ b/packages/compiler/src/template/pipeline/src/phases/i18n_const_collection.ts @@ -99,9 +99,6 @@ function collectMessage( // Sort the params for consistency with TemaplateDefinitionBuilder output. messageOp.params = new Map([...messageOp.params.entries()].sort()); - // Check that the message has all of its parameters filled out. - assertAllParamsResolved(messageOp); - const mainVar = o.variable(job.pool.uniqueName(TRANSLATION_VAR_PREFIX)); // Closure Compiler requires const names to start with `MSG_` but disallows any other // const to start with `MSG_`. We define a variable starting with `MSG_` just for the @@ -230,21 +227,3 @@ function i18nGenerateClosureVar( } return o.variable(name); } - -/** - * Asserts that all of the message's placeholders have values. - */ -function assertAllParamsResolved(op: ir.I18nMessageOp): asserts op is ir.I18nMessageOp { - for (let placeholder in op.message.placeholders) { - placeholder = placeholder.trimEnd(); - if (!op.params.has(placeholder) && !op.postprocessingParams.has(placeholder)) { - throw Error(`Failed to resolve i18n placeholder: ${placeholder}`); - } - } - for (let placeholder in op.message.placeholderToMessage) { - placeholder = placeholder.trimEnd(); - if (!op.params.has(placeholder) && !op.postprocessingParams.has(placeholder)) { - throw Error(`Failed to resolve i18n message placeholder: ${placeholder}`); - } - } -}