From 5b7698939e2017ae3d02d72d2b970ab870fa9cb7 Mon Sep 17 00:00:00 2001 From: Kristiyan Kostadinov Date: Tue, 24 Jan 2017 23:13:40 +0100 Subject: [PATCH] chore(checkbox): remove unnecessary will-change (#2743) Removes a couple of unnecessary usages of `will-change` in the checkbox. They are redundant, because the properties being animated aren't problematic to transition in the first place (`border-color`, `background-color` and `opacity`). In general, we should avoid adding `will-change` like this, until we actually notice a performance issue, and even in that case it should be added right before an animation is supposed to happen. --- src/lib/checkbox/checkbox.scss | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/lib/checkbox/checkbox.scss b/src/lib/checkbox/checkbox.scss index 1e0a0d04000..213663d7123 100644 --- a/src/lib/checkbox/checkbox.scss +++ b/src/lib/checkbox/checkbox.scss @@ -240,7 +240,6 @@ md-checkbox { background-color: transparent; border: $md-checkbox-border-width solid; transition: border-color $md-checkbox-transition-duration $md-linear-out-slow-in-timing-function; - will-change: border-color; } .md-checkbox-background { @@ -252,7 +251,6 @@ md-checkbox { transition: background-color $md-checkbox-transition-duration $md-linear-out-slow-in-timing-function, opacity $md-checkbox-transition-duration $md-linear-out-slow-in-timing-function; - will-change: background-color, opacity; } .md-checkbox-checkmark {