skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(animations): make AnimationDriver.getParentElement required (#45114)

Browse Source 
This change is a follow up to #45057 to make `AnimationDriver.getParentElement`
a required method, which allows removing the slow path for the animation
namespace insertion logic.

BREAKING CHANGE:

The `AnimationDriver.getParentElement` method has become required, so any
implementors of this interface are now required to provide an implementation
for this method. This breakage is unlikely to affect application developers,
as `AnimationDriver` is not expected to be implemented in user code.

PR Close #45114
This commit is contained in:
JoostK
2022-02-16 23:11:33 +01:00
committed by Andrew Scott
parent bd168fc0c3
commit 59559fdbac
3 changed files with 15 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/animations/browser/src/render/animation_driver.ts
+1 -5
View File
@@ -65,12 +65,8 @@ export abstract class AnimationDriver {
/**
* Obtains the parent element, if any. `null` is returned if the element does not have a parent.
*
* This method is optional to avoid a breaking change where implementors of this interface would
* be required to implement this method. This method is to become required in a major version of
* Angular.
*/
abstract getParentElement?(element: unknown): unknown;
abstract getParentElement(element: unknown): unknown;
abstract query(element: any, selector: string, multi: boolean): any[];
packages/animations/browser/src/render/transition_animation_engine.ts
+13 -27
View File
@@ -594,34 +594,20 @@ export class TransitionAnimationEngine {
const limit = namespaceList.length - 1;
if (limit >= 0) {
let found = false;
if (this.driver.getParentElement !== undefined) {
// Fast path for when the driver implements `getParentElement`, which allows us to find the
// closest ancestor with an existing namespace that we can then insert `ns` after, without
// having to inspect all existing namespaces.
let ancestor = this.driver.getParentElement(hostElement);
while (ancestor) {
const ancestorNs = namespacesByHostElement.get(ancestor);
if (ancestorNs) {
// An animation namespace has been registered for this ancestor, so we insert `ns`
// right after it to establish top-down ordering of animation namespaces.
const index = namespaceList.indexOf(ancestorNs);
namespaceList.splice(index + 1, 0, ns);
found = true;
break;
}
ancestor = this.driver.getParentElement(ancestor);
}
} else {
// Slow path for backwards compatibility if the driver does not implement
// `getParentElement`, to be removed once `getParentElement` is a required method.
for (let i = limit; i >= 0; i--) {
const nextNamespace = namespaceList[i];
if (this.driver.containsElement(nextNamespace.hostElement, hostElement)) {
namespaceList.splice(i + 1, 0, ns);
found = true;
break;
}
// Find the closest ancestor with an existing namespace so we can then insert `ns` after it,
// establishing a top-down ordering of namespaces in `this._namespaceList`.
let ancestor = this.driver.getParentElement(hostElement);
while (ancestor) {
const ancestorNs = namespacesByHostElement.get(ancestor);
if (ancestorNs) {
// An animation namespace has been registered for this ancestor, so we insert `ns`
// right after it to establish top-down ordering of animation namespaces.
const index = namespaceList.indexOf(ancestorNs);
namespaceList.splice(index + 1, 0, ns);
found = true;
break;
}
ancestor = this.driver.getParentElement(ancestor);
}
if (!found) {
// No namespace exists that is an ancestor of `ns`, so `ns` is inserted at the front to