From 54252d5c1be882e6ffaec0f72516363f66b9de58 Mon Sep 17 00:00:00 2001 From: Kristiyan Kostadinov Date: Mon, 12 Mar 2018 18:40:41 -0400 Subject: [PATCH] refactor(overlay): remove 6.0.0 deletion targets (#10161) Removes all of the APIs that were marked for deletion in 6.0.0 from the `cdk/overlay` entry point. BREAKING CHANGES: * `ConnectedOverlayDirective` which was deprecated in 5.0.0 has been removed. Use `CdkConnectedOverlay` instead. * `OverlayOrigin` which was deprecated in 5.0.0 has been removed. Use `CdkOverlayOrigin` instead. * `hasBackdrop` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayHasBackdrop` instead. * `open` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayOpen` instead. * `scrollStrategy` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayScrollStrategy` instead. * `backdropClass` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayBackdropClass` instead. * `minHeight` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayMinHeight` instead. * `minWidth` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayMinWidth` instead. * `height` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayHeight` instead. * `width` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayWidth` instead. * `offsetX` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayOffsetX` instead. * `offsetY` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayOffsetY` instead. * `positions` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayPositions` instead. * `origin` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayOrigin` instead. --- src/cdk/overlay/overlay-directives.spec.ts | 19 +++-- src/cdk/overlay/overlay-directives.ts | 98 ---------------------- src/cdk/overlay/public-api.ts | 12 --- src/demo-app/overlay/overlay-demo.html | 7 +- src/lib/select/select.html | 16 ++-- 5 files changed, 28 insertions(+), 124 deletions(-) diff --git a/src/cdk/overlay/overlay-directives.spec.ts b/src/cdk/overlay/overlay-directives.spec.ts index 7251c94bb0e..56dc3b1e3c8 100644 --- a/src/cdk/overlay/overlay-directives.spec.ts +++ b/src/cdk/overlay/overlay-directives.spec.ts @@ -402,12 +402,21 @@ describe('Overlay directives', () => { -

Menu content

`, diff --git a/src/cdk/overlay/overlay-directives.ts b/src/cdk/overlay/overlay-directives.ts index 1de1ab5d53c..e5e6f1388fc 100644 --- a/src/cdk/overlay/overlay-directives.ts +++ b/src/cdk/overlay/overlay-directives.ts @@ -161,104 +161,6 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges { get lockPosition() { return this._lockPosition; } set lockPosition(value: any) { this._lockPosition = coerceBooleanProperty(value); } - /** - * @deprecated - * @deletion-target 6.0.0 - */ - @Input('origin') - get _deprecatedOrigin(): CdkOverlayOrigin { return this.origin; } - set _deprecatedOrigin(_origin: CdkOverlayOrigin) { this.origin = _origin; } - - /** - * @deprecated - * @deletion-target 6.0.0 - */ - @Input('positions') - get _deprecatedPositions(): ConnectionPositionPair[] { return this.positions; } - set _deprecatedPositions(_positions: ConnectionPositionPair[]) { this.positions = _positions; } - - /** - * @deprecated - * @deletion-target 6.0.0 - */ - @Input('offsetX') - get _deprecatedOffsetX(): number { return this.offsetX; } - set _deprecatedOffsetX(_offsetX: number) { this.offsetX = _offsetX; } - - /** - * @deprecated - * @deletion-target 6.0.0 - */ - @Input('offsetY') - get _deprecatedOffsetY(): number { return this.offsetY; } - set _deprecatedOffsetY(_offsetY: number) { this.offsetY = _offsetY; } - - /** - * @deprecated - * @deletion-target 6.0.0 - */ - @Input('width') - get _deprecatedWidth(): number | string { return this.width; } - set _deprecatedWidth(_width: number | string) { this.width = _width; } - - /** - * @deprecated - * @deletion-target 6.0.0 - */ - @Input('height') - get _deprecatedHeight(): number | string { return this.height; } - set _deprecatedHeight(_height: number | string) { this.height = _height; } - - /** - * @deprecated - * @deletion-target 6.0.0 - */ - @Input('minWidth') - get _deprecatedMinWidth(): number | string { return this.minWidth; } - set _deprecatedMinWidth(_minWidth: number | string) { this.minWidth = _minWidth; } - - /** - * @deprecated - * @deletion-target 6.0.0 - */ - @Input('minHeight') - get _deprecatedMinHeight(): number | string { return this.minHeight; } - set _deprecatedMinHeight(_minHeight: number | string) { this.minHeight = _minHeight; } - - /** - * @deprecated - * @deletion-target 6.0.0 - */ - @Input('backdropClass') - get _deprecatedBackdropClass(): string { return this.backdropClass; } - set _deprecatedBackdropClass(_backdropClass: string) { this.backdropClass = _backdropClass; } - - /** - * @deprecated - * @deletion-target 6.0.0 - */ - @Input('scrollStrategy') - get _deprecatedScrollStrategy(): ScrollStrategy { return this.scrollStrategy; } - set _deprecatedScrollStrategy(_scrollStrategy: ScrollStrategy) { - this.scrollStrategy = _scrollStrategy; - } - - /** - * @deprecated - * @deletion-target 6.0.0 - */ - @Input('open') - get _deprecatedOpen(): boolean { return this.open; } - set _deprecatedOpen(_open: boolean) { this.open = _open; } - - /** - * @deprecated - * @deletion-target 6.0.0 - */ - @Input('hasBackdrop') - get _deprecatedHasBackdrop() { return this.hasBackdrop; } - set _deprecatedHasBackdrop(_hasBackdrop: any) { this.hasBackdrop = _hasBackdrop; } - /** Event emitted when the backdrop is clicked. */ @Output() backdropClick = new EventEmitter(); diff --git a/src/cdk/overlay/public-api.ts b/src/cdk/overlay/public-api.ts index 1711f278ade..1e1f786a531 100644 --- a/src/cdk/overlay/public-api.ts +++ b/src/cdk/overlay/public-api.ts @@ -25,15 +25,3 @@ export {PositionStrategy} from './position/position-strategy'; export {GlobalPositionStrategy} from './position/global-position-strategy'; export {ConnectedPositionStrategy} from './position/connected-position-strategy'; export {VIEWPORT_RULER_PROVIDER} from '@angular/cdk/scrolling'; - -/** - * @deprecated Use CdkConnectedOverlay - * @deletion-target 6.0.0 - */ -export {CdkConnectedOverlay as ConnectedOverlayDirective} from './overlay-directives'; - -/** - * @deprecated Use CdkOverlayOrigin - * @deletion-target 6.0.0 - */ -export {CdkOverlayOrigin as OverlayOrigin} from './overlay-directives'; diff --git a/src/demo-app/overlay/overlay-demo.html b/src/demo-app/overlay/overlay-demo.html index ff9dfeecd2c..512ab0927ff 100644 --- a/src/demo-app/overlay/overlay-demo.html +++ b/src/demo-app/overlay/overlay-demo.html @@ -19,7 +19,12 @@ Open menu -
This is the menu panel. diff --git a/src/lib/select/select.html b/src/lib/select/select.html index 0d4e1943c30..de76f939702 100644 --- a/src/lib/select/select.html +++ b/src/lib/select/select.html @@ -17,15 +17,15 @@