From 52e2f0842d200571ee2c9526d6b14e4f0f11d1a8 Mon Sep 17 00:00:00 2001 From: cexbrayat Date: Thu, 23 Jan 2025 12:30:35 +0100 Subject: [PATCH] refactor(core): remove unused `APP_EFFECT_SCHEDULER` in effect code (#59679) The `APP_EFFECT_SCHEDULER` Injection token is never used and not a public API. PR Close #59679 --- packages/core/src/render3/reactivity/effect.ts | 10 ---------- .../src/render3/reactivity/root_effect_scheduler.ts | 2 -- 2 files changed, 12 deletions(-) diff --git a/packages/core/src/render3/reactivity/effect.ts b/packages/core/src/render3/reactivity/effect.ts index 6eb1c229246..9d7e6e94ca0 100644 --- a/packages/core/src/render3/reactivity/effect.ts +++ b/packages/core/src/render3/reactivity/effect.ts @@ -19,7 +19,6 @@ import { } from '../../../primitives/signals'; import {FLAGS, LViewFlags, LView, EFFECTS} from '../interfaces/view'; import {markAncestorsForTraversal} from '../util/view_utils'; -import {InjectionToken} from '../../di/injection_token'; import {inject} from '../../di/injector_compatibility'; import {Injector} from '../../di/injector'; import {assertNotInReactiveContext} from './asserts'; @@ -201,15 +200,6 @@ export interface RootEffectNode extends EffectNode { scheduler: EffectScheduler; } -/** - * Not public API, which guarantees `EffectScheduler` only ever comes from the application root - * injector. - */ -export const APP_EFFECT_SCHEDULER = /* @__PURE__ */ new InjectionToken('', { - providedIn: 'root', - factory: () => inject(EffectScheduler), -}); - export const BASE_EFFECT_NODE: Omit = /* @__PURE__ */ (() => ({ ...REACTIVE_NODE, diff --git a/packages/core/src/render3/reactivity/root_effect_scheduler.ts b/packages/core/src/render3/reactivity/root_effect_scheduler.ts index fcbbd368528..356995b3eb1 100644 --- a/packages/core/src/render3/reactivity/root_effect_scheduler.ts +++ b/packages/core/src/render3/reactivity/root_effect_scheduler.ts @@ -7,8 +7,6 @@ */ import {ɵɵdefineInjectable} from '../../di/interface/defs'; -import {PendingTasksInternal} from '../../pending_tasks'; -import {inject} from '../../di/injector_compatibility'; /** * Abstraction that encompasses any kind of effect that can be scheduled.