From 498534bbaa619495988f83f488522c689aeb1097 Mon Sep 17 00:00:00 2001 From: Kristiyan Kostadinov Date: Fri, 9 Mar 2018 10:29:08 -0500 Subject: [PATCH] fix(icon): namespace error when registering an icon on the server (#10175) Fixes the `MatIconRegistry` throwing a namespace error on the server due to the `xmlns` attribute. These changes remove the attribute, because it's optional under HTML5. Fixes #10170. --- src/lib/icon/icon-registry.ts | 3 --- src/universal-app/prerender.ts | 5 ++++- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/lib/icon/icon-registry.ts b/src/lib/icon/icon-registry.ts index ef4a06acbcb..0b0ac8a5b4c 100644 --- a/src/lib/icon/icon-registry.ts +++ b/src/lib/icon/icon-registry.ts @@ -459,9 +459,6 @@ export class MatIconRegistry { * Sets the default attributes for an SVG element to be used as an icon. */ private _setSvgAttributes(svg: SVGElement): SVGElement { - if (!svg.getAttribute('xmlns')) { - svg.setAttribute('xmlns', 'http://www.w3.org/2000/svg'); - } svg.setAttribute('fit', ''); svg.setAttribute('height', '100%'); svg.setAttribute('width', '100%'); diff --git a/src/universal-app/prerender.ts b/src/universal-app/prerender.ts index df558311377..b064ccd438d 100644 --- a/src/universal-app/prerender.ts +++ b/src/universal-app/prerender.ts @@ -15,7 +15,10 @@ const result = renderModuleFactory(KitchenSinkServerModuleNgFactory, { result .then(content => { - writeFileSync(join(__dirname, 'index-prerendered.html'), content, 'utf-8'); + const filename = join(__dirname, 'index-prerendered.html'); + + console.log(`Outputting result to ${filename}`); + writeFileSync(filename, content, 'utf-8'); log('Prerender done.'); }) // If rendering the module factory fails, exit the process with an error code because otherwise