diff --git a/src/demo-app/progress-spinner/progress-spinner-demo.html b/src/demo-app/progress-spinner/progress-spinner-demo.html index 2e2ba59b85e..07a04390dc8 100644 --- a/src/demo-app/progress-spinner/progress-spinner-demo.html +++ b/src/demo-app/progress-spinner/progress-spinner-demo.html @@ -4,13 +4,13 @@

Value: {{progressValue}}

- Is determinate + Is determinate
- -
diff --git a/src/demo-app/progress-spinner/progress-spinner-demo.ts b/src/demo-app/progress-spinner/progress-spinner-demo.ts index b67781631c5..9677e78e50d 100644 --- a/src/demo-app/progress-spinner/progress-spinner-demo.ts +++ b/src/demo-app/progress-spinner/progress-spinner-demo.ts @@ -8,9 +8,9 @@ import {Component} from '@angular/core'; styleUrls: ['progress-spinner-demo.css'], }) export class ProgressSpinnerDemo { - progressValue: number = 60; - color: string = 'primary'; - modeToggle: boolean = false; + progressValue = 60; + color = 'primary'; + isDeterminate = true; step(val: number) { this.progressValue = Math.max(0, Math.min(100, val + this.progressValue)); diff --git a/src/lib/progress-spinner/progress-spinner.spec.ts b/src/lib/progress-spinner/progress-spinner.spec.ts index 76bc536fd04..c23ba1bde66 100644 --- a/src/lib/progress-spinner/progress-spinner.spec.ts +++ b/src/lib/progress-spinner/progress-spinner.spec.ts @@ -27,10 +27,10 @@ describe('MdProgressSpinner', () => { it('should apply a mode of "determinate" if no mode is provided.', () => { let fixture = TestBed.createComponent(BasicProgressSpinner); - fixture.detectChanges(); + fixture.detectChanges(); - let progressElement = fixture.debugElement.query(By.css('md-progress-spinner')); - expect(progressElement.componentInstance.mode).toBe('determinate'); + let progressElement = fixture.debugElement.query(By.css('md-progress-spinner')); + expect(progressElement.componentInstance.mode).toBe('determinate'); }); it('should not modify the mode if a valid mode is provided.', () => { diff --git a/src/lib/progress-spinner/progress-spinner.ts b/src/lib/progress-spinner/progress-spinner.ts index aaa74d42e05..7320c54ab7c 100644 --- a/src/lib/progress-spinner/progress-spinner.ts +++ b/src/lib/progress-spinner/progress-spinner.ts @@ -287,19 +287,13 @@ export class MdProgressSpinner extends _MdProgressSpinnerMixinBase inputs: ['color'], templateUrl: 'progress-spinner.html', styleUrls: ['progress-spinner.css'], + changeDetection: ChangeDetectionStrategy.OnPush, }) -export class MdSpinner extends MdProgressSpinner implements OnDestroy { - +export class MdSpinner extends MdProgressSpinner { constructor(elementRef: ElementRef, ngZone: NgZone, renderer: Renderer2) { super(renderer, elementRef, ngZone); this.mode = 'indeterminate'; } - - ngOnDestroy() { - // The `ngOnDestroy` from `MdProgressSpinner` should be called explicitly, because - // in certain cases Angular won't call it (e.g. when using AoT and in unit tests). - super.ngOnDestroy(); - } }