build: update dependency jasmine to v4 (#46617)

| datasource | package        | from   | to    |
| ---------- | -------------- | ------ | ----- |
| npm        | jasmine        | 3.10.0 | 4.2.1 |
| npm        | @types/jasmine | 3.5.14 | 4.0.3 |
| npm        | jasmine        | 3.6.1  | 4.2.1 |

PR Close #46617

aio/aio-builds-setup/dockerbuild/scripts-js/lib/common/run-tests.ts

@@ -18,6 +18,5 @@ export const runTests = (specFiles: string[]) => {
 
   const runner = new Jasmine({});
   runner.loadConfig(config);
-  runner.onComplete((passed: boolean) => process.exit(passed ? 0 : 1));
   runner.execute();
 };

aio/aio-builds-setup/dockerbuild/scripts-js/package.json

@@ -27,7 +27,7 @@
     "body-parser": "^1.19.0",
     "delete-empty": "^3.0.0",
     "express": "^4.17.1",
-    "jasmine": "^3.6.1",
+    "jasmine": "^4.0.0",
     "nock": "^13.0.4",
     "node-fetch": "^2.6.1",
     "shelljs": "^0.8.5",
@@ -38,7 +38,7 @@
   "devDependencies": {
     "@types/body-parser": "^1.19.0",
     "@types/express": "^4.17.8",
-    "@types/jasmine": "^3.5.14",
+    "@types/jasmine": "^4.0.0",
     "@types/nock": "^11.1.0",
     "@types/node": "^14.6.4",
     "@types/node-fetch": "^2.5.7",

aio/aio-builds-setup/dockerbuild/scripts-js/test/preview-server/jasmine-custom-async-matchers.ts

@@ -2,7 +2,7 @@ import {PreviewServerError} from '../../lib/preview-server/preview-error';
 
 
 // Matchers
-const toBeRejectedWithPreviewServerError: jasmine.CustomAsyncMatcherFactory = () => {
+const toBeRejectedWithPreviewServerError: jasmine.CustomAsyncMatcherFactory = matchersUtil => {
   return {
     async compare(actualPromise: Promise<never>, expectedStatus: number, expectedMessage?: string | RegExp) {
       if (!(actualPromise instanceof Promise)) {
@@ -49,7 +49,7 @@ const toBeRejectedWithPreviewServerError: jasmine.CustomAsyncMatcherFactory = ()
       return `${PreviewServerError.name}(${value.status}${value.message ? `, ${value.message}` : ''})`;
     }
 
-    return jasmine.pp(value);
+    return matchersUtil.pp(value);
   }
 };
 

aio/aio-builds-setup/dockerbuild/scripts-js/test/preview-server/preview-server-factory.spec.ts

@@ -225,10 +225,10 @@ describe('PreviewServerFactory', () => {
       buildCreator.emit(ChangedPrVisibilityEvent.type, {pr: 42, shas: ['12345', '67890'], isPublic: true});
 
       const allCalls = prsAddCommentSpy.calls.all();
-      const prs: GithubPullRequests = allCalls[0].object;
+      const prs = allCalls[0].object as GithubPullRequests;
 
       expect(prsAddCommentSpy).toHaveBeenCalledTimes(2);
-      expect(prs).toBe(allCalls[1].object);
+      expect(prs).toBe(allCalls[1].object as GithubPullRequests);
       expect(prs).toBeInstanceOf(GithubPullRequests);
       expect(prs.repoSlug).toBe('organisation/repo');
     });

aio/package.json

@@ -147,7 +147,7 @@
     "html": "^1.0.0",
     "ignore": "^5.1.8",
     "image-size": "^1.0.0",
-    "jasmine": "~3.10.0",
+    "jasmine": "~4.2.0",
     "jasmine-core": "~4.2.0",
     "jasmine-spec-reporter": "~7.0.0",
     "jsdom": "^20.0.0",

aio/scripts/deploy-to-firebase/pre-deploy-actions.spec.mjs

@@ -153,7 +153,8 @@ describe('deploy-to-firebase/pre-deploy-actions:', () => {
   });
 
   describe('undo.checkPayloadSize()', () => {
-    // This is a no-op, so nothing to test.
+    // This method is a no-op, so there is nothing to test.
+    it('does not need tests', () => expect().nothing());
   });
 
   describe('undo.disableServiceWorker()', () => {

aio/yarn.lock

@@ -7854,21 +7854,16 @@ jasmine-core@^4.1.0:
   resolved "https://registry.yarnpkg.com/jasmine-core/-/jasmine-core-4.1.1.tgz#1045091e16f4f19e1d72416eef5db01e64d5fbeb"
   integrity sha512-lmUfT5XcK9KKvt3lLYzn93hc4MGzlUBowExFVgzbSW0ZCrdeyS574dfsyfRhxbg81Wj4gk+RxUiTnj7KBfDA1g==
 
+jasmine-core@^4.2.0, jasmine-core@~4.2.0:
+  version "4.2.0"
+  resolved "https://registry.yarnpkg.com/jasmine-core/-/jasmine-core-4.2.0.tgz#0605bea284d6d78276f43c47de2532ecd4a73b00"
+  integrity sha512-OcFpBrIhnbmb9wfI8cqPSJ50pv3Wg4/NSgoZIqHzIwO/2a9qivJWzv8hUvaREIMYYJBas6AvfXATFdVuzzCqVw==
+
 jasmine-core@~2.8.0:
   version "2.8.0"
   resolved "https://registry.yarnpkg.com/jasmine-core/-/jasmine-core-2.8.0.tgz#bcc979ae1f9fd05701e45e52e65d3a5d63f1a24e"
   integrity sha512-SNkOkS+/jMZvLhuSx1fjhcNWUC/KG6oVyFUGkSBEr9n1axSNduWU8GlI7suaHXr4yxjet6KjrUZxUTE5WzzWwQ==
 
-jasmine-core@~3.10.0:
-  version "3.10.1"
-  resolved "https://registry.yarnpkg.com/jasmine-core/-/jasmine-core-3.10.1.tgz#7aa6fa2b834a522315c651a128d940eca553989a"
-  integrity sha512-ooZWSDVAdh79Rrj4/nnfklL3NQVra0BcuhcuWoAwwi+znLDoUeH87AFfeX8s+YeYi6xlv5nveRyaA1v7CintfA==
-
-jasmine-core@~4.2.0:
-  version "4.2.0"
-  resolved "https://registry.yarnpkg.com/jasmine-core/-/jasmine-core-4.2.0.tgz#0605bea284d6d78276f43c47de2532ecd4a73b00"
-  integrity sha512-OcFpBrIhnbmb9wfI8cqPSJ50pv3Wg4/NSgoZIqHzIwO/2a9qivJWzv8hUvaREIMYYJBas6AvfXATFdVuzzCqVw==
-
 jasmine-spec-reporter@~7.0.0:
   version "7.0.0"
   resolved "https://registry.yarnpkg.com/jasmine-spec-reporter/-/jasmine-spec-reporter-7.0.0.tgz#94b939448e63d4e2bd01668142389f20f0a8ea49"
@@ -7885,13 +7880,13 @@ jasmine@2.8.0:
     glob "^7.0.6"
     jasmine-core "~2.8.0"
 
-jasmine@~3.10.0:
-  version "3.10.0"
-  resolved "https://registry.yarnpkg.com/jasmine/-/jasmine-3.10.0.tgz#acd3cd560a9d20d8fdad6bd2dd05867d188503f3"
-  integrity sha512-2Y42VsC+3CQCTzTwJezOvji4qLORmKIE0kwowWC+934Krn6ZXNQYljiwK5st9V3PVx96BSiDYXSB60VVah3IlQ==
+jasmine@~4.2.0:
+  version "4.2.1"
+  resolved "https://registry.yarnpkg.com/jasmine/-/jasmine-4.2.1.tgz#55f81ab9d5d32f2645aa598d1356b6858407f4a9"
+  integrity sha512-LNZEKcScnjPRj5J92I1P515bxTvaHMRAERTyCoaGnWr87eOT6zv+b3M+kxKdH/06Gz4TnnXyHbXLiPtMHZ0ncw==
   dependencies:
     glob "^7.1.6"
-    jasmine-core "~3.10.0"
+    jasmine-core "^4.2.0"
 
 jasminewd2@^2.1.0:
   version "2.2.0"