From 310a0e0eda24fc204379b9ba8f327c1664dc5991 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Mon, 12 Aug 2024 15:22:16 +0000 Subject: [PATCH] refactor(migrations): expose angular compiler options to signal input migration (#57347) Instead of exposing just the `ts.CompilerOptions`, we should expose the actual Angular compiler options throuhgout the signal input migration. This will be useful for parsing templates, in cases of JIT-opted components. PR Close #57347 --- .../schematics/migrations/signal-migration/src/BUILD.bazel | 1 + .../signal-migration/src/convert-input/convert_to_signal.ts | 2 +- .../migrations/signal-migration/src/migration_host.ts | 3 ++- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/core/schematics/migrations/signal-migration/src/BUILD.bazel b/packages/core/schematics/migrations/signal-migration/src/BUILD.bazel index fb87ba6dfc2..743ecfe1b6f 100644 --- a/packages/core/schematics/migrations/signal-migration/src/BUILD.bazel +++ b/packages/core/schematics/migrations/signal-migration/src/BUILD.bazel @@ -17,6 +17,7 @@ ts_library( "//packages/compiler-cli/src/ngtsc/annotations/common", "//packages/compiler-cli/src/ngtsc/annotations/directive", "//packages/compiler-cli/src/ngtsc/core", + "//packages/compiler-cli/src/ngtsc/core:api", "//packages/compiler-cli/src/ngtsc/diagnostics", "//packages/compiler-cli/src/ngtsc/file_system", "//packages/compiler-cli/src/ngtsc/imports", diff --git a/packages/core/schematics/migrations/signal-migration/src/convert-input/convert_to_signal.ts b/packages/core/schematics/migrations/signal-migration/src/convert-input/convert_to_signal.ts index 2d6866a94c1..e0f619aefd5 100644 --- a/packages/core/schematics/migrations/signal-migration/src/convert-input/convert_to_signal.ts +++ b/packages/core/schematics/migrations/signal-migration/src/convert-input/convert_to_signal.ts @@ -55,7 +55,7 @@ export function convertToSignalInput( } const strictPropertyInitialization = - !!host.tsOptions.strict || !!host.tsOptions.strictPropertyInitialization; + !!host.options.strict || !!host.options.strictPropertyInitialization; const inputArgs: ts.Expression[] = []; const typeArguments: ts.TypeNode[] = []; diff --git a/packages/core/schematics/migrations/signal-migration/src/migration_host.ts b/packages/core/schematics/migrations/signal-migration/src/migration_host.ts index cdbcc512d5b..3c5a5ebf5ae 100644 --- a/packages/core/schematics/migrations/signal-migration/src/migration_host.ts +++ b/packages/core/schematics/migrations/signal-migration/src/migration_host.ts @@ -8,6 +8,7 @@ import path from 'path'; import ts from 'typescript'; +import {NgCompilerOptions} from '../../../../../compiler-cli/src/ngtsc/core/api'; /** * A migration host is in practice a container object that @@ -20,7 +21,7 @@ export class MigrationHost { constructor( public projectDir: string, public isMigratingCore: boolean, - public tsOptions: ts.CompilerOptions, + public options: NgCompilerOptions, sourceFiles: readonly ts.SourceFile[], ) { this._sourceFiles = new WeakSet(sourceFiles);