From 2f213de593b65009aa35731e684adf4c704ca592 Mon Sep 17 00:00:00 2001 From: Shuaib Hasan Akib Date: Mon, 23 Feb 2026 19:27:05 +0600 Subject: [PATCH] refactor(core): remove outdated TODO comments Cleans up TODO comments that are no longer planned Fixes #67191 (cherry picked from commit 5ac1c025f9ff0bc8777b3181855a29824577ce97) --- packages/core/primitives/signals/src/computed.ts | 1 - packages/core/primitives/signals/src/linked_signal.ts | 1 - packages/core/primitives/signals/src/signal.ts | 1 - packages/core/primitives/signals/src/watch.ts | 1 - packages/core/src/authoring/input/input_signal_node.ts | 1 - 5 files changed, 5 deletions(-) diff --git a/packages/core/primitives/signals/src/computed.ts b/packages/core/primitives/signals/src/computed.ts index b6d5ceb7f42..96f1e93af6b 100644 --- a/packages/core/primitives/signals/src/computed.ts +++ b/packages/core/primitives/signals/src/computed.ts @@ -114,7 +114,6 @@ export const ERRORED: any = /* @__PURE__ */ Symbol('ERRORED'); // Note: Using an IIFE here to ensure that the spread assignment is not considered // a side-effect, ending up preserving `COMPUTED_NODE` and `REACTIVE_NODE`. -// TODO: remove when https://github.com/evanw/esbuild/issues/3392 is resolved. const COMPUTED_NODE = /* @__PURE__ */ (() => { return { ...REACTIVE_NODE, diff --git a/packages/core/primitives/signals/src/linked_signal.ts b/packages/core/primitives/signals/src/linked_signal.ts index eb66d3c80ca..14434c58581 100644 --- a/packages/core/primitives/signals/src/linked_signal.ts +++ b/packages/core/primitives/signals/src/linked_signal.ts @@ -123,7 +123,6 @@ export function linkedSignalUpdateFn( // Note: Using an IIFE here to ensure that the spread assignment is not considered // a side-effect, ending up preserving `LINKED_SIGNAL_NODE` and `REACTIVE_NODE`. -// TODO: remove when https://github.com/evanw/esbuild/issues/3392 is resolved. export const LINKED_SIGNAL_NODE: object = /* @__PURE__ */ (() => { return { ...REACTIVE_NODE, diff --git a/packages/core/primitives/signals/src/signal.ts b/packages/core/primitives/signals/src/signal.ts index d8ab44d44c2..0f54c8725b3 100644 --- a/packages/core/primitives/signals/src/signal.ts +++ b/packages/core/primitives/signals/src/signal.ts @@ -108,7 +108,6 @@ export function runPostSignalSetFn(node: SignalNode): void { // Note: Using an IIFE here to ensure that the spread assignment is not considered // a side-effect, ending up preserving `COMPUTED_NODE` and `REACTIVE_NODE`. -// TODO: remove when https://github.com/evanw/esbuild/issues/3392 is resolved. export const SIGNAL_NODE: SignalNode = /* @__PURE__ */ (() => { return { ...REACTIVE_NODE, diff --git a/packages/core/primitives/signals/src/watch.ts b/packages/core/primitives/signals/src/watch.ts index f9ed2402f27..e9c3f368039 100644 --- a/packages/core/primitives/signals/src/watch.ts +++ b/packages/core/primitives/signals/src/watch.ts @@ -140,7 +140,6 @@ const NOOP_CLEANUP_FN: WatchCleanupFn = () => {}; // Note: Using an IIFE here to ensure that the spread assignment is not considered // a side-effect, ending up preserving `COMPUTED_NODE` and `REACTIVE_NODE`. -// TODO: remove when https://github.com/evanw/esbuild/issues/3392 is resolved. const WATCH_NODE: Partial = /* @__PURE__ */ (() => { return { ...REACTIVE_NODE, diff --git a/packages/core/src/authoring/input/input_signal_node.ts b/packages/core/src/authoring/input/input_signal_node.ts index b521545b1a3..d57dedafb55 100644 --- a/packages/core/src/authoring/input/input_signal_node.ts +++ b/packages/core/src/authoring/input/input_signal_node.ts @@ -39,7 +39,6 @@ export interface InputSignalNode extends SignalNode { // Note: Using an IIFE here to ensure that the spread assignment is not considered // a side-effect, ending up preserving `COMPUTED_NODE` and `REACTIVE_NODE`. -// TODO: remove when https://github.com/evanw/esbuild/issues/3392 is resolved. export const INPUT_SIGNAL_NODE: InputSignalNode = /* @__PURE__ */ (() => { return { ...SIGNAL_NODE,