From 2e72ec7e1cc9745bcd1bf489d2a9283e2b12759f Mon Sep 17 00:00:00 2001
From: Andrew Kushnir <akushnir@google.com>
Date: Thu, 16 Jan 2025 21:24:50 -0800
Subject: [PATCH] test(platform-server): fix flaky incremental hydration test
 (#59584)

This commit updates a test setup to define a global `ngServerMode` correctly for a test that was emulating client-only behavior. The flag could've been set by prior tests and depending on its state, the test was acting differently.

PR Close #59584
---
 .../test/incremental_hydration_spec.ts        | 33 +++++++++----------
 1 file changed, 16 insertions(+), 17 deletions(-)

diff --git a/packages/platform-server/test/incremental_hydration_spec.ts b/packages/platform-server/test/incremental_hydration_spec.ts
index 7c55819c70f..4be2b69ef28 100644
--- a/packages/platform-server/test/incremental_hydration_spec.ts
+++ b/packages/platform-server/test/incremental_hydration_spec.ts
@@ -1822,6 +1822,9 @@ describe('platform-server partial hydration integration', () => {
 
   describe('client side navigation', () => {
     beforeEach(() => {
+      // This test emulates client-side behavior, set global server mode flag to `false`.
+      globalThis['ngServerMode'] = false;
+
       TestBed.configureTestingModule({
         providers: [
           {provide: PLATFORM_ID, useValue: PLATFORM_BROWSER_ID},
@@ -1830,32 +1833,28 @@ describe('platform-server partial hydration integration', () => {
       });
     });
 
+    afterEach(() => {
+      globalThis['ngServerMode'] = undefined;
+    });
+
     it('should not try to hydrate in CSR only cases', async () => {
       @Component({
         selector: 'app',
         template: `
-          <main (click)="fnA()">
-            @defer (hydrate when true) {
-              <article>
-                defer block rendered!
-                <span id="test" (click)="fnB()">{{value()}}</span>
-              </article>
-            } @placeholder {
-              <span>Outer block placeholder</span>
-            }
-          </main>
+          @defer (hydrate when true; on interaction) {
+            <p>Defer block rendered!</p>
+          } @placeholder {
+            <span>Outer block placeholder</span>
+          }
         `,
       })
-      class SimpleComponent {
-        value = signal('start');
-        fnA() {}
-        fnB() {
-          this.value.set('end');
-        }
-      }
+      class SimpleComponent {}
+
       const fixture = TestBed.createComponent(SimpleComponent);
       fixture.detectChanges();
 
+      // Verify that `hydrate when true` doesn't trigger rendering of the main
+      // content in client-only use-cases (expecting to see placeholder content).
       expect(fixture.nativeElement.innerHTML).toContain('Outer block placeholder');
     });
   });