From 2c8cb13bcf36915012c52cdd975bbd30676ef1f1 Mon Sep 17 00:00:00 2001 From: Pawel Kozlowski Date: Fri, 22 Nov 2024 18:46:51 +0100 Subject: [PATCH] refactor(docs-infra): use input bindings in docs component (#58826) Use reactive inputs instead of manually getting data from the currently activated route. PR Close #58826 --- adev/src/app/features/docs/docs.component.html | 5 +++-- adev/src/app/features/docs/docs.component.ts | 12 ++---------- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/adev/src/app/features/docs/docs.component.html b/adev/src/app/features/docs/docs.component.html index e3a86bf5996..13d8afca7ea 100644 --- a/adev/src/app/features/docs/docs.component.html +++ b/adev/src/app/features/docs/docs.component.html @@ -1,7 +1,8 @@ -@if (documentContent()) { +@let docContent = this.docContent(); +@if (docContent) { } diff --git a/adev/src/app/features/docs/docs.component.ts b/adev/src/app/features/docs/docs.component.ts index adb62c0dc27..db6186f0b0b 100644 --- a/adev/src/app/features/docs/docs.component.ts +++ b/adev/src/app/features/docs/docs.component.ts @@ -7,10 +7,7 @@ */ import {DocContent, DocViewer} from '@angular/docs'; -import {ChangeDetectionStrategy, Component, inject} from '@angular/core'; -import {toSignal} from '@angular/core/rxjs-interop'; -import {ActivatedRoute} from '@angular/router'; -import {map} from 'rxjs/operators'; +import {ChangeDetectionStrategy, Component, input} from '@angular/core'; @Component({ selector: 'docs-docs', @@ -21,14 +18,9 @@ import {map} from 'rxjs/operators'; templateUrl: './docs.component.html', }) export default class DocsComponent { - private readonly activatedRoute = inject(ActivatedRoute); - // Based on current route, proper static content for doc page is fetched. // In case when exists example-viewer placeholders, then ExampleViewer // components are going to be rendered. - private readonly documentContent$ = this.activatedRoute.data.pipe( - map((data) => data['docContent'] as DocContent), - ); - documentContent = toSignal(this.documentContent$); + docContent = input(); }