From 14d998d809df4e180fac9bb81d1d75098bf643d5 Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Fri, 25 Jul 2025 14:58:19 +0000 Subject: [PATCH] build: use rollup to locally bundle domino (#62823) Use rollup instead of esbuild for bundling domino locally for usage within the repository PR Close #62823 --- packages/platform-server/BUILD.bazel | 24 +++++++++++++++++------ packages/platform-server/init/BUILD.bazel | 24 +++++++++++++++++------ 2 files changed, 36 insertions(+), 12 deletions(-) diff --git a/packages/platform-server/BUILD.bazel b/packages/platform-server/BUILD.bazel index bee8be52a7d..8f4c2a37267 100644 --- a/packages/platform-server/BUILD.bazel +++ b/packages/platform-server/BUILD.bazel @@ -1,5 +1,5 @@ load("@aspect_rules_js//js:defs.bzl", "js_library") -load("@devinfra//bazel/esbuild:index.bzl", "esbuild") +load("@npm2//:rollup/package_json.bzl", rollup = "bin") load("//tools:defaults.bzl", "generate_api_docs", "tsec_test") load("//tools:defaults2.bzl", "api_golden_test_npm_package", "ng_package", "ng_project", "npm_package") @@ -27,12 +27,24 @@ ng_project( ], ) -esbuild( +rollup.rollup( name = "bundled_domino", - entry_point = "@npm//:node_modules/domino/lib/index.js", - format = "esm", - output = "src/bundled-domino.mjs", - deps = ["@npm//domino"], + srcs = [ + "//:node_modules/@rollup/plugin-commonjs", + "//:node_modules/domino", + ], + outs = [ + "src/bundled-domino.mjs", + ], + args = [ + "--format=esm", + "--plugin=@rollup/plugin-commonjs", + "--input=node_modules/domino/lib/index.js", + "--sourcemap=false", + "--file=packages/platform-server/src/bundled-domino.mjs", + ], + progress_message = "Bundling domino", + silent_on_success = True, ) js_library( diff --git a/packages/platform-server/init/BUILD.bazel b/packages/platform-server/init/BUILD.bazel index 09d51428e78..fa62aa0be8f 100644 --- a/packages/platform-server/init/BUILD.bazel +++ b/packages/platform-server/init/BUILD.bazel @@ -1,5 +1,5 @@ load("@aspect_rules_js//js:defs.bzl", "js_library") -load("@devinfra//bazel/esbuild:index.bzl", "esbuild") +load("@npm2//:rollup/package_json.bzl", rollup = "bin") load("//tools:defaults.bzl", "tsec_test") load("//tools:defaults2.bzl", "ng_project") @@ -19,12 +19,24 @@ ng_project( ], ) -esbuild( +rollup.rollup( name = "bundled_domino", - entry_point = "@npm//:node_modules/domino/lib/index.js", - format = "esm", - output = "src/bundled-domino.mjs", - deps = ["@npm//domino"], + srcs = [ + "//:node_modules/@rollup/plugin-commonjs", + "//:node_modules/domino", + ], + outs = [ + "src/bundled-domino.mjs", + ], + args = [ + "--format=esm", + "--plugin=@rollup/plugin-commonjs", + "--input=node_modules/domino/lib/index.js", + "--sourcemap=false", + "--file=packages/platform-server/init/src/bundled-domino.mjs", + ], + progress_message = "Bundling domino", + silent_on_success = True, ) js_library(