From 1328307bb856a5ac38b2fd066126d2d245483396 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Tue, 18 Apr 2017 18:24:33 +0200 Subject: [PATCH] build: remove outdated tslint rule (#4121) * At some point in tslint the `no-unused-variable` rule has been deprecated in favor of `noUnusedLocals` and `noUnusedParameters`. Since we don't want to have compilation errors for unused variables we re-implemented the `no-unused-variable` rule ourself and used it as a custom rule. * Recently we switched to a newer version of TSLint and TypeScript and the custom tslint rule won't ever work again. (tslint now requires a type-checker to be enabled). The custom rule fails currently and causes TSLint to not work with some editors (e.g Webstorm). --- package.json | 3 +-- tslint.json | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/package.json b/package.json index 8b5a03671c6..51cd96a1a50 100644 --- a/package.json +++ b/package.json @@ -114,8 +114,7 @@ "stylelint": "^7.8.0", "travis-after-modes": "0.0.7", "ts-node": "^3.0.0", - "tslint": "^5.0.0", - "tslint-no-unused-var": "0.0.6", + "tslint": "^5.1.0", "typescript": "~2.2.1", "uglify-js": "^2.8.14", "web-animations-js": "^2.2.2" diff --git a/tslint.json b/tslint.json index 37fb35232b2..e8ec1dd2984 100644 --- a/tslint.json +++ b/tslint.json @@ -1,6 +1,5 @@ { "rulesDirectory": [ - "./node_modules/tslint-no-unused-var/", "./tools/tslint-rules/" ], "rules": { @@ -27,7 +26,6 @@ "no-bitwise": true, "no-shadowed-variable": true, "no-unused-expression": true, - "no-unused-var": [true, {"ignore-pattern": "^(_.*)$"}], "no-var-keyword": true, "no-exposed-todo": true, "no-debugger": true,