mirror of
https://github.com/angular/angular.git
synced 2026-09-14 13:54:52 +08:00
build: update karma-sauce-launcher to latest version with heartbeat to prevent idle timeout (#43659)
Updates the `karma-sauce-launcher` to the latest version that comes with the heartbeat implemented. Whenever we create an instance of a browser in Saucelabs, we need to send a Selenium command every X seconds as otherwise Saucelabs will terminate the session due to it thinking the session is already unused. This is especially a problem for Karma unit tests as there is no selenium command at all, except for the initial one loading the Karma site. The latest version of the launcher has implemented an interval that dispatches a noop selenium command every X seconds to notify Saucelabs that the instance is still active. The current version of the launcher does not do that. This is likely the source of some disconnects because after 10-13min, the SL browser is terminated but Karma still waits some minute after realizing the browser is actually disconnected. We (the Angular team), contributed to that version in the past since the heartbeat was very flaky.. and we removed it. With the new version a lot has changed, the underlying Selenium client has changed so it's worth trying again with the heartbeat re-implemented; it worked pretty well so far in the COMP repo). PR Close #43659
This commit is contained in:
committed by
Andrew Scott
parent
4c00e92023
commit
116877b4ed