From 0e5e4e298a1e15711709559b5d4f941f6e53b816 Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Tue, 26 Apr 2022 16:58:00 +0300 Subject: [PATCH] refactor(common): consistently name tooling related to `closure-locale.ts` (#45714) Previously, some functions/targets related to the generation/verification of the `closure-locale.ts` file included `closure_locales` instead of `closure_locale` in their name, which was inconsistent and confusing. Rename all tooling to use `closure_locale` (which more closely matches the generated file's name). PR Close #45714 --- packages/common/locales/BUILD.bazel | 10 +++++----- packages/common/locales/index.bzl | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/common/locales/BUILD.bazel b/packages/common/locales/BUILD.bazel index 6ba788d608f..1e1d029e7af 100644 --- a/packages/common/locales/BUILD.bazel +++ b/packages/common/locales/BUILD.bazel @@ -1,5 +1,5 @@ load("@build_bazel_rules_nodejs//:index.bzl", "generated_file_test") -load("//packages/common/locales:index.bzl", "LOCALES", "generate_all_locale_files", "generate_closure_locales_file") +load("//packages/common/locales:index.bzl", "LOCALES", "generate_all_locale_files", "generate_closure_locale_file") load("//tools:defaults.bzl", "pkg_npm", "ts_library") package(default_visibility = ["//visibility:public"]) @@ -8,15 +8,15 @@ package(default_visibility = ["//visibility:public"]) # the `closure-locale.ts` file is checked-in for Google3, we add a `generated_file_test` to # ensure the checked-in file is up-to-date. To disambiguate from the test, we use a more # precise target name here. -generate_closure_locales_file( - name = "closure_locales_file_generated", - output_file = "closure_locales_generated.ts", +generate_closure_locale_file( + name = "closure_locale_file_generated", + output_file = "closure_locale_generated.ts", ) generated_file_test( name = "closure_locale_file", src = "closure-locale.ts", - generated = ":closure_locales_file_generated", + generated = ":closure_locale_file_generated", ) generate_all_locale_files( diff --git a/packages/common/locales/index.bzl b/packages/common/locales/index.bzl index d0ca0872f85..d58f4a9b9d6 100644 --- a/packages/common/locales/index.bzl +++ b/packages/common/locales/index.bzl @@ -36,7 +36,7 @@ def generate_base_locale_file(name, output_file, **kwargs): **kwargs ) -def generate_closure_locales_file(name, output_file, **kwargs): +def generate_closure_locale_file(name, output_file, **kwargs): _run_tool_with_single_output( name = name, output_file = output_file,