From 0a4146d1897f1ead5031ec392403a7e6c52257a7 Mon Sep 17 00:00:00 2001
From: SkyZeroZx <73321943+SkyZeroZx@users.noreply.github.com>
Date: Thu, 23 Jul 2026 12:05:15 -0500
Subject: [PATCH] docs: update signal forms skill to match the current
 implementation

(cherry picked from commit 7e39b4aedb386e5e69a8c317987d4efb71f9756d)
---
 .agent/skills/reference-signal-forms/SKILL.md    | 16 ++++++++--------
 .../references/integration.md                    | 12 ++++++------
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/.agent/skills/reference-signal-forms/SKILL.md b/.agent/skills/reference-signal-forms/SKILL.md
index b373b201174..752f9655f3c 100644
--- a/.agent/skills/reference-signal-forms/SKILL.md
+++ b/.agent/skills/reference-signal-forms/SKILL.md
@@ -5,7 +5,7 @@ description: Explains the mental model and architecture of the code under `packa
 
 # Signal Forms Architecture
 
-The `packages/forms/signals` directory contains an experimental, signal-based forms API for Angular.
+The `packages/forms/signals` directory contains the signal-based forms API for Angular.
 This system differs significantly from the existing Reactive and Template-driven forms.
 
 ## Mental Model
@@ -36,27 +36,27 @@ The central internal class representing a single field in the form graph. It agg
 
 - `structure`: Manages parent/child relationships and signal slicing.
 - `validationState`: Computes `valid`, `invalid`, `errors` signals.
-- `nodeState`: Tracks `touched`, `dirty`, `pristine`.
+- `nodeState`: Tracks `touched`, `dirty`, and derived logical state.
 - `metadataState`: Stores metadata like `min`, `max`, `required`.
 - `submitState`: Tracks submission status and server errors.
 
-### 2. `ValidationState` (`src/field/validation.ts`)
+### 2. `FieldValidationState` (`src/field/validation.ts`)
 
-Manages the complexity of validation:
+Implements `ValidationState` and manages the complexity of validation:
 
 - **Synchronous Errors**: Derived from schema rules.
 - **Asynchronous Errors**: Handled via signals, including 'pending' states.
 - **Tree Errors**: Errors that bubble up or are targeted at specific fields.
 - **Submission Errors**: Server-side errors injected imperatively via `submit()`.
 
-### 3. `FormField` Directive (`src/directive/form_field_directive.ts`)
+### 3. `FormField` Directive (`src/directive/form_field.ts`)
 
 The bridge between the `FieldNode` and the DOM.
 
 - Selector: `[formField]`
 - It supports:
   - **Native Elements**: `<input>`, `<select>`, `<textarea>`.
-  - **Custom Controls**: Components implementing `FormUiControl` or `FormValueControl`.
+  - **Custom Controls**: Components implementing `FormValueControl` or `FormCheckboxControl`.
   - **Legacy Interop**: Components implementing `ControlValueAccessor` (via `InteropNgControl`).
 
 ### 4. `Schema` (`src/api/structure.ts` & `src/api/rules`)
@@ -69,7 +69,7 @@ Defines the behavior.
 
 ## Data Flow
 
-1.  **Read**: `form.field.value()` reads directly from the underlying signal (projected to the specific path).
+1.  **Read**: `form.field().value()` reads directly from the underlying signal (projected to the specific path).
 2.  **Write**: Writing to the form (e.g., via UI) updates the underlying signal.
 3.  **Validation**: A computed effect observes the value signal and runs validators defined in the schema.
 
@@ -97,7 +97,7 @@ const userForm = form(user, userRules); // OR apply(userForm, userRules)
 - `packages/forms/signals/src/api/structure.ts`: Public API entry points (`form`, `apply`).
 - `packages/forms/signals/src/api/control.ts`: Interfaces for custom controls (`FormUiControl`).
 - `packages/forms/signals/src/field/node.ts`: The `FieldNode` implementation.
-- `packages/forms/signals/src/directive/form_field_directive.ts`: The `[formField]` directive.
+- `packages/forms/signals/src/directive/form_field.ts`: The `[formField]` directive.
 
 ## Supplemental Information
 
diff --git a/.agent/skills/reference-signal-forms/references/integration.md b/.agent/skills/reference-signal-forms/references/integration.md
index 4dbb63570c6..35af559df9b 100644
--- a/.agent/skills/reference-signal-forms/references/integration.md
+++ b/.agent/skills/reference-signal-forms/references/integration.md
@@ -2,9 +2,9 @@
 
 This document explains how the Signal Forms system hooks into the Angular compiler and runtime to provide seamless type-checking and efficient updates.
 
-## 1. Compiler-CLI Integration (Type Checking)
+## 1. Compiler Integration (Type Checking)
 
-The `packages/compiler-cli` package contains specific logic to support `[formField]`. This is primarily handled in `src/ngtsc/typecheck/src/ops/signal_forms.ts`.
+The `packages/compiler` package contains specific logic to support `[formField]`. This is primarily handled in `src/typecheck/ops/signal_forms.ts`.
 
 ### Key Mechanisms:
 
@@ -22,7 +22,7 @@ The `packages/compiler-cli` package contains specific logic to support `[formFie
 
 ### Relevant Files:
 
-- `packages/compiler-cli/src/ngtsc/typecheck/src/ops/signal_forms.ts`: The core logic for `TcbNativeFieldOp` and `SignalFormFieldOp`.
+- `packages/compiler/src/typecheck/ops/signal_forms.ts`: The core Signal Forms type-checking logic, including `TcbNativeFieldOp`.
 
 ## 2. Core Runtime Integration
 
@@ -30,8 +30,8 @@ The `packages/core` package provides the low-level instructions that power the `
 
 ### Key Mechanisms:
 
-- **`ɵngControlCreate` Hook**: The `FormField` directive defines a special method `ɵngControlCreate`.
-- **`ɵɵcontrol` Instructions**: When the compiler sees `ɵngControlCreate`, it emits:
+- **`ɵngControlCreate` Hook**: The `FormField` directive defines a special method `ɵngControlCreate`, which causes the compiler to install `ɵɵControlFeature`.
+- **`ɵɵcontrol` Instructions**: A `formField` binding causes the compiler to emit:
   - `ɵɵcontrolCreate`: Called during the creation phase.
   - `ɵɵcontrol`: Called during the update phase.
 - **`ControlDirectiveHost`**: These instructions provide the directive with a `ControlDirectiveHost`. This is a privileged interface that allows the `FormField` directive to:
@@ -43,4 +43,4 @@ The `packages/core` package provides the low-level instructions that power the `
 ### Relevant Files:
 
 - `packages/core/src/render3/instructions/control.ts`: Implementation of `ɵɵcontrol` instructions.
-- `packages/forms/signals/src/directive/form_field_directive.ts`: The directive that implements the hook.
+- `packages/forms/signals/src/directive/form_field.ts`: The directive that implements the hook.