skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(compiler-cli): report individual diagnostics for unused imports (#58589)

Browse Source 
Initially the unused imports check was implemented so that it reports one diagnostic per component with the individual unused imports being highlighted through the `relatedInformation`. This works fine when reporting errors to the command line, but vscode appears to only show `relatedInformation` when the user hovers over a diagnostic which is a sub-par experience.

These changes switch to reporting a diagnostic for each unused import instead.

PR Close #58589
This commit is contained in:
Kristiyan Kostadinov
2024-11-11 10:27:54 +01:00
committed by Jessica Janiuk
parent 5ac0538870
commit 086cb2c40e
3 changed files with 90 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/compiler-cli/test/ngtsc/template_typecheck_spec.ts
+7 -18
View File
@@ -7709,9 +7709,7 @@ suppress
const diags = env.driveDiagnostics();
expect(diags.length).toBe(1);
expect(diags[0].messageText).toBe('Imports array contains unused imports');
expect(diags[0].relatedInformation?.length).toBe(1);
expect(getSourceCodeForDiagnostic(diags[0].relatedInformation![0])).toBe('UnusedDir');
expect(diags[0].messageText).toBe('UnusedDir is not used within the template of MyComp');
});
it('should report when a pipe is not used within a template', () => {
@@ -7766,9 +7764,7 @@ suppress
const diags = env.driveDiagnostics();
expect(diags.length).toBe(1);
expect(diags[0].messageText).toBe('Imports array contains unused imports');
expect(diags[0].relatedInformation?.length).toBe(1);
expect(getSourceCodeForDiagnostic(diags[0].relatedInformation![0])).toBe('UnusedPipe');
expect(diags[0].messageText).toBe('UnusedPipe is not used within the template of MyComp');
});
it('should not report imports only used inside @defer blocks', () => {
@@ -7835,7 +7831,6 @@ suppress
const diags = env.driveDiagnostics();
expect(diags.length).toBe(1);
expect(diags[0].messageText).toBe('All imports are unused');
expect(diags[0].relatedInformation).toBeFalsy();
});
it('should not report unused imports coming from modules', () => {
@@ -7953,11 +7948,9 @@ suppress
);
const diags = env.driveDiagnostics();
expect(diags.length).toBe(1);
expect(diags[0].messageText).toBe('Imports array contains unused imports');
expect(diags[0].relatedInformation?.length).toBe(2);
expect(getSourceCodeForDiagnostic(diags[0].relatedInformation![0])).toBe('NgFor');
expect(getSourceCodeForDiagnostic(diags[0].relatedInformation![1])).toBe('PercentPipe');
expect(diags.length).toBe(2);
expect(diags[0].messageText).toBe('NgFor is not used within the template of MyComp');
expect(diags[1].messageText).toBe('PercentPipe is not used within the template of MyComp');
});
it('should report unused imports coming from a nested array from the same file', () => {
@@ -8017,9 +8010,7 @@ suppress
const diags = env.driveDiagnostics();
expect(diags.length).toBe(1);
expect(diags[0].messageText).toBe('Imports array contains unused imports');
expect(diags[0].relatedInformation?.length).toBe(1);
expect(getSourceCodeForDiagnostic(diags[0].relatedInformation![0])).toBe('UnusedDir');
expect(diags[0].messageText).toBe('UnusedDir is not used within the template of MyComp');
});
it('should report unused imports coming from an array used as the `imports` initializer', () => {
@@ -8068,9 +8059,7 @@ suppress
const diags = env.driveDiagnostics();
expect(diags.length).toBe(1);
expect(diags[0].messageText).toBe('Imports array contains unused imports');
expect(diags[0].relatedInformation?.length).toBe(1);
expect(getSourceCodeForDiagnostic(diags[0].relatedInformation![0])).toBe('UnusedDir');
expect(diags[0].messageText).toBe('UnusedDir is not used within the template of MyComp');
});
it('should not report unused imports coming from an array through a spread expression from a different file', () => {