skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

build: ensure tunnel identifiers are unique (#14108)

Browse Source 
* Currently it can happen that our tunnel identifier conflicts with other tunnel identifiers from other Angular projects. A few PRs reported that their tunnel couldn't be re-opened because it was already used and closed successfully.
This commit is contained in:
Paul Gschwendtner
2018-11-14 23:19:22 +01:00
committed by Andrew Seguin
parent cb57c6c6bf
commit 039ca606c8
3 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/karma.conf.js
+3 -2
View File
@@ -95,8 +95,9 @@ module.exports = config => {
if (process.env['CIRCLECI']) {
const instanceIndex = Number(process.env['CIRCLE_NODE_INDEX']);
const maxParallelInstances = Number(process.env['CIRCLE_NODE_TOTAL']);
const tunnelIdentifier = `${process.env['CIRCLE_BUILD_NUM']}-${instanceIndex}`;
const buildIdentifier = `angular-material-${tunnelIdentifier}`;
const tunnelIdentifier =
`angular-material-${process.env['CIRCLE_BUILD_NUM']}-${instanceIndex}`;
const buildIdentifier = `circleci-${tunnelIdentifier}`;
const testPlatform = process.env['TEST_PLATFORM'];
if (testPlatform === 'browserstack') {