skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

build: ensure tunnel identifiers are unique (#14108)

Browse Source 
* Currently it can happen that our tunnel identifier conflicts with other tunnel identifiers from other Angular projects. A few PRs reported that their tunnel couldn't be re-opened because it was already used and closed successfully.
This commit is contained in:
Paul Gschwendtner
2018-11-14 23:19:22 +01:00
committed by Andrew Seguin
parent cb57c6c6bf
commit 039ca606c8
3 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/browserstack/start-tunnel.sh
+1 -1
View File
@@ -31,7 +31,7 @@ rm ${tunnelFileName}
ARGS=""
if [ ! -z "${CIRCLE_BUILD_NUM}" ]; then
ARGS="${ARGS} --local-identifier ${CIRCLE_BUILD_NUM}-${CIRCLE_NODE_INDEX}"
ARGS="${ARGS} --local-identifier angular-material-${CIRCLE_BUILD_NUM}-${CIRCLE_NODE_INDEX}"
fi
echo "Starting Browserstack Local in the background, logging into: ${tunnelLogFile}"
scripts/saucelabs/start-tunnel.sh
+1 -1
View File
@@ -31,7 +31,7 @@ rm ${tunnelFileName}
sauceArgs="--readyfile ${tunnelReadyFile} --pidfile ${tunnelPidFile}"
if [ ! -z "${CIRCLE_BUILD_NUM}" ]; then
sauceArgs="${sauceArgs} --tunnel-identifier ${CIRCLE_BUILD_NUM}-${CIRCLE_NODE_INDEX}"
sauceArgs="${sauceArgs} --tunnel-identifier angular-material-${CIRCLE_BUILD_NUM}-${CIRCLE_NODE_INDEX}"
fi
echo "Starting Sauce Connect in the background, logging into: ${tunnelLogFile}"