skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity
Files
651c34735d011882b537c2ea2603467d00de8f67
angular__angular/.pullapprove.yml
T

1408 lines
52 KiB
YAML
Raw Normal View History

ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
####################################################################################
####################################################################################
# Angular Code Ownership #
####################################################################################
####################################################################################
#
# Configuration of code ownership and review approvals for the angular/angular repo.
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 22:52:49 +02:00
#
# More info: https://docs.pullapprove.com/
#
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# General rules / philosophy
# =========================================================
#
# - We trust that people do the right thing and won't approve changes they don't feel confident reviewing
# - We enforce that only approved PRs are merged ensuring that unreviewed code isn't accidentally merged
# - We distribute approval rights as much as possible to help us scale better
# - Groups have one or two global approvers groups as fallbacks:
# - @angular/fw-global-approvers: for approving minor changes, large-scale refactorings, and emergency situations.
# - @angular/fw-global-approvers-for-docs-only-changes: for approving minor documentation-only changes that don't require engineering review
# - A small number of file groups have very limited number of reviewers because incorrect changes to the files they guard would have serious consequences (e.g. security, public api)
#
# Configuration nuances:
#
# - This configuration works in conjunction with the protected branch settings that require all changes to be made via pull requests with at least one approval.
# - This approval can come from an appropriate codeowner, or any repo collaborator (person with write access) if the PR is authored by a codeowner.
# - All groups whose pullapprove rules are matched will be required for overall approval.
#
# NOTE:
# In the case of emergency, the repo administrators which include the current angular caretaker
# can bypass this reviewer approval requirement, this is expected as a last resort and to be
# done exceedingly sparingly.
####################################################################################
# GitHub usernames
####################################################################################
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
# See reviewer list under `required-minimum-review` group. Team member names and
# usernames are managed there.
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
####################################################################################
# Approval Groups
####################################################################################
# =========================================================
# @angular/framework-global-approvers
# =========================================================
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 22:52:49 +02:00
# Used for approving minor changes, large-scale refactorings, and in emergency situations.
#
ci: add alex to global approvers list (#42156) Note alex's addition to the global approvers list for pullapprove. PR Close #42156
2021-05-18 13:41:16 -07:00
# alxhub
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 15:10:13 -07:00
# jelbourn
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# josephperrott
#
# =========================================================
# @angular/framework-global-approvers-for-docs-only-changes
# =========================================================
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 22:52:49 +02:00
# Used for approving minor documentation-only changes that don't require engineering review.
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
version: 3
ci: Update pullapprove availability (#50070) I will not be available to review PRs for an extended period of time. PR Close #50070
2023-04-28 11:41:23 -07:00
availability:
ci: remove myself from pullapprove unavailability list (#51437) Removes myself from the pullapprove unavailability list. PR Close #51437
2023-08-21 11:31:24 +00:00
users_unavailable: []
ci: Update availability for pullapprove (#44312) Follows the v3 pullapprove docs here: https://docs.pullapprove.com/config/availability/ PR Close #44312
2021-11-30 09:55:05 -08:00
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 08:25:39 -07:00
# Meta field that goes unused by PullApprove to allow for defining aliases to be
# used throughout the config.
meta:
ci: only check active groups for the `no-groups-above-this-*` checks (#38259) Since PullApprove starts all inactive groups as a pending state, to properly assess if any groups we care about are pending we must only check the active groups. We additionally do this with rejected because the intention of the reusable checks is around checking active rules only. PR Close #38259
2020-07-27 17:10:23 -07:00
# Note: Because all inactive groups start as pending, we are only checking pending and rejected active groups.
build: refactor global approvals to be done via overrides, adding dev-infra global approvers (#44866) Add dev-infra global approver support and change global approval management to be done via overrides. By using overrides to determine global approval status, we can safely ignore the concept of global approval in all of the other group management. PR Close #44866
2022-01-27 15:32:20 -08:00
no-groups-above-this-pending: &no-groups-above-this-pending len(groups.active.pending.exclude("required-minimum-review")) == 0
no-groups-above-this-rejected: &no-groups-above-this-rejected len(groups.active.rejected.exclude("required-minimum-review")) == 0
ci: no longer use deprecated `pullapprove_conditions` option (#42895) PullApprove deprecated the `pullapprove_conditions` config option and introduced the `overrides` option. This commit migrates to the new option, while also eliminating the `fallback` group with a simple override (as per recommendation from the pull approve docs). PR Close #42895
2021-07-19 18:18:41 +02:00
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
defaults: &defaults
reviews:
# Authors provide their approval implicitly, this approval allows for a reviewer
# from a group not to need a review specifically for an area of the repository
# they own. This is coupled with the `required-minimum-review` group which requires
# that all PRs are reviewed by at least one team member who is not the author of
# the PR.
author_value: 1
build: update pullapprove config to better handle global approvals (#36384) Beginning with this change, global approvals will now require the approver to include `Reviewed-for: global-approvers`, and a docs global approval requires `Reviewed-for: global-docs-approvers`. Historically, providing a review by any member of the global reviewer groups would automatically be considered a global review. This change enforces that global approval should be an intentional, explicit action. The global-approvers and global-docs-approvers group will not be requested as reviews by pullapprove. PR Close #36384
2020-03-30 08:25:39 -07:00
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# turn on 'draft' support
# https://docs.pullapprove.com/config/github-api-version/
# https://developer.github.com/v3/previews/#draft-pull-requests
build: reformat yml files (#42136) Reformat all yml files in the repository. PR Close #42136
2021-05-14 10:54:35 -07:00
github_api_version: 'shadow-cat-preview'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
ci: no longer use deprecated `pullapprove_conditions` option (#42895) PullApprove deprecated the `pullapprove_conditions` config option and introduced the `overrides` option. This commit migrates to the new option, while also eliminating the `fallback` group with a simple override (as per recommendation from the pull approve docs). PR Close #42895
2021-07-19 18:18:41 +02:00
# https://docs.pullapprove.com/config/overrides/
# Note that overrides are processed in order.
overrides:
ci: allow for disabling PullApprove on a single PR via adding a label (#39430) Alowing for disabling PullApprove on a single PR via adding a label allows for an escape hatch if PullApprove is not acting as expected, or for cases where reviews can be stepped over in obvious situations, such as a revert. PR Close #39430
2020-10-26 09:47:49 -07:00
# For PRs which are still being worked on, either still in draft mode or indicated through WIP in
# title or label, PullApprove stays in a pending state until its ready for review.
ci: no longer use deprecated `pullapprove_conditions` option (#42895) PullApprove deprecated the `pullapprove_conditions` config option and introduced the `overrides` option. This commit migrates to the new option, while also eliminating the `fallback` group with a simple override (as per recommendation from the pull approve docs). PR Close #42895
2021-07-19 18:18:41 +02:00
- if: "draft or 'WIP' in title or 'PR state: WIP' in labels"
status: pending
build: reformat yml files (#42136) Reformat all yml files in the repository. PR Close #42136
2021-05-14 10:54:35 -07:00
explanation: 'Waiting to send reviews as PR is WIP'
ci: allow for disabling PullApprove on a single PR via adding a label (#39430) Alowing for disabling PullApprove on a single PR via adding a label allows for an escape hatch if PullApprove is not acting as expected, or for cases where reviews can be stepped over in obvious situations, such as a revert. PR Close #39430
2020-10-26 09:47:49 -07:00
# Disable PullApprove on specific PRs by adding the `PullApprove: disable` label
ci: no longer use deprecated `pullapprove_conditions` option (#42895) PullApprove deprecated the `pullapprove_conditions` config option and introduced the `overrides` option. This commit migrates to the new option, while also eliminating the `fallback` group with a simple override (as per recommendation from the pull approve docs). PR Close #42895
2021-07-19 18:18:41 +02:00
- if: "'PullApprove: disable' in labels"
status: success
ci: allow for disabling PullApprove on a single PR via adding a label (#39430) Alowing for disabling PullApprove on a single PR via adding a label allows for an escape hatch if PullApprove is not acting as expected, or for cases where reviews can be stepped over in obvious situations, such as a revert. PR Close #39430
2020-10-26 09:47:49 -07:00
explanation: "PullApprove skipped because of 'PullApprove: disable' label"
ci: update pullapprove config to properly handle global approvals (#42929) Update the config to properly identify a global approval as approved rather than as no file matching based groups being matched. PR Close #42929
2021-07-22 09:28:08 -07:00
# If no file matching based groups are active, report this pull request as failing. Most likely,
# the PR author would need to update the PullApprove config, or create new group.
- if: len(groups.active.exclude("required-minimum-review").exclude("global-*")) == 0 and len(groups.approved.include("global-*")) == 0
ci: no longer use deprecated `pullapprove_conditions` option (#42895) PullApprove deprecated the `pullapprove_conditions` config option and introduced the `overrides` option. This commit migrates to the new option, while also eliminating the `fallback` group with a simple override (as per recommendation from the pull approve docs). PR Close #42895
2021-07-19 18:18:41 +02:00
status: failure
explanation: 'At least one group must match this PR. Please update an existing review group, or create a new group.'
build: refactor global approvals to be done via overrides, adding dev-infra global approvers (#44866) Add dev-infra global approver support and change global approval management to be done via overrides. By using overrides to determine global approval status, we can safely ignore the concept of global approval in all of the other group management. PR Close #44866
2022-01-27 15:32:20 -08:00
# If any global dev-infra approval is given the status should be passing.
- if: len(groups.approved.include("global-dev-infra-approvers")) == 1
status: success
explanation: 'Passing as globally approved by dev-infra'
# If any global docs approval is given the status should be passing.
- if: len(groups.approved.include("global-docs-approvers")) == 1
status: success
explanation: 'Passing as globally approved by docs'
# If any global approval is given the status should be passing.
- if: len(groups.approved.include("global-approvers")) == 1
status: success
explanation: 'Passing as globally approved by global approvers'
ci: fix pullapprove_conditions (#35011) PR Close #35011
2020-01-28 09:29:36 -08:00
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
groups:
# =========================================================
# Framework: Animations
# =========================================================
fw-animations:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/animations/**/{*,.*}',
'packages/platform-browser/animations/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/animations.md',
docs: Document extracted from the original Introduction document, which is to be retired. Linting suggested corrections made. Restructuring or rewording sentences to be shorter and clearer. (#47907) PR Close #47907
2022-10-28 15:44:56 +00:00
'aio/content/guide/add-an-animation.md',
docs: Document extracted from the original Introduction document, which is to be retired. Linting suggested corrections made. Restructuring or rewording sentences to be shorter and clearer. (#47908) docs: add to pullapprove PR Close #47908
2022-10-28 15:52:26 +00:00
'aio/content/guide/animate-state-style.md',
docs: Document extracted from the original Introduction document, which is to be retired. (#47913) docs: add to pullapprove PR Close #47913
2022-10-28 20:03:15 +00:00
'aio/content/guide/animation-api-summary.md',
docs: Document extracted from the original Introduction document, which is to be retired. Linting suggested corrections made. Restructuring or rewording sentences to be shorter and clearer. (#47906) docs: Document extracted from the original Introduction document, which is to be retired. Linting suggested corrections made. Restructuring or rewording sentences to be shorter and clearer. docs: revised understanding doc and pullapprove.yml PR Close #47906
2022-10-27 23:43:49 +00:00
'aio/content/guide/understanding-angular-animation.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/animations/**/{*,.*}',
'aio/content/images/guide/animations/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/complex-animation-sequences.md',
'aio/content/guide/reusable-animations.md',
'aio/content/guide/route-animations.md',
docs: Document extracted from the original Introduction document, which is to be retired. Linting suggested corrections made. Restructuring or rewording sentences to be shorter and clearer. (#47912) PR Close #47912
2022-10-28 19:51:18 +00:00
'aio/content/guide/transition-and-triggers.md',
docs: Document extracted from the original Introduction document, which is to be retired. Linting suggested corrections made. Restructuring or rewording sentences to be shorter and clearer. (#47909) docs: add to pullapprove PR Close #47909
2022-10-28 16:03:21 +00:00
'aio/content/guide/animations-attach-to-html-template.md',
'aio/content/guide/animation-transition-timing.md'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- alxhub
build: update pullapprove to remove @matsko from reviewer lists (#38146) With @matsko leaving the Angular team, we need to update the pullapprove configuration to reflect his no longer being a reviewer for file groups throughout the repository. PR Close #38146
2020-07-20 11:06:05 -07:00
- crisbeto
build: don't assign jelbourn to most review categories (#45668) Configure pullapprove to not automatically assign jelbourn to most review categories. PR Close #45668
2022-04-18 09:29:19 -07:00
- ~jelbourn
ci: add jessicajaniuk to pullapprove groups (#44255) This adds jessicajaniuk to fw-animations and fw-testing. PR Close #44255
2021-11-23 16:38:00 -08:00
- jessicajaniuk
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Framework: Compiler
# =========================================================
fw-compiler:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
refactor: remove Angular Compatibility Compiler (ngcc) (#49101) This commit removes the NGCC code and all the related infra setup required to support it. BREAKING CHANGE: Angular Compatibility Compiler (ngcc) has been removed and as a result Angular View Engine libraries will no longer work PR Close #49101
2023-02-16 13:28:23 +00:00
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/compiler/**/{*,.*}',
'packages/examples/compiler/**/{*,.*}',
'aio/content/examples/angular-compiler-options/**/{*,.*}',
'packages/compiler-cli/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/angular-compiler-options.md',
'aio/content/guide/aot-compiler.md',
'aio/content/guide/aot-metadata-errors.md',
ci: move error pages outside of the `public-api` group (#49770) Currently, a change in an error guide triggers a review for the `public-api` group (requests 3 reviewers and al least 2 must approve). This is overly aggressive and we can relax this by moving the guides under `fw-core` and extended diagnistics under `fw-compiler`. In this case 1 reviewer would be requested. PR Close #49770
2023-04-10 12:27:06 -07:00
'aio/content/guide/template-typecheck.md',
'aio/content/extended-diagnostics/*.md'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
ci: add atscott to fw-compiler reviewers (#42963) add atscott to fw-compiler reviewers PR Close #42963
2021-07-26 11:37:35 -07:00
- alxhub
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- AndrewKushnir
ci: add atscott to fw-compiler reviewers (#42963) add atscott to fw-compiler reviewers PR Close #42963
2021-07-26 11:37:35 -07:00
- atscott
build: update PullApprove config (#49878) Updates the PullApprove config to add myself to `fw-compiler` and `fw-core` with the following reasoning: * We talked about `fw-compiler` some time ago, because it would help with TypeScript updates and because I'm familiar with the compiler. * Also adding myself to `fw-core` to make it easier with some upcoming features and because I can help with the review load for the runtime changes. PR Close #49878
2023-04-17 09:03:44 +02:00
- crisbeto
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
- JoostK
refactor: add dylhunn to pullapprove (#51069) As discussed on Slack -- I feel comfortable enough, and this will also help unblock Miles on reviews PR Close #51069
2023-07-17 09:50:57 -07:00
- dylhunn
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
ci: add codeowner group for migrations (#36661) Adds a new codeowner group that is dedicated for changes to the migrations stored in `packages/core/schematics`. PR Close #36661
2020-04-16 23:27:33 +02:00
# =========================================================
# Framework: Migrations
# =========================================================
fw-migrations:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: add codeowner group for migrations (#36661) Adds a new codeowner group that is dedicated for changes to the migrations stored in `packages/core/schematics`. PR Close #36661
2020-04-16 23:27:33 +02:00
conditions:
ci: fix pullapprove `fnmatch` patterns due to recent changes (#46589) We recently changed our pullapprove config to work with hidden directories. As part of that, we accidentally invalidated some other pattern parameters due to inconsistency in Pullapprove. e.g. contains any globs uses wcmatch, while `files.exclude` and `files.include` uses `fnmatch`. The current fnmatch patterns are actual wcmatch glob patterns and need to be adjusted for `fnmatch`. As part of this fix (which ensures groups are more correct again), this commit also cleans up some unused `file.exclude` in the `fw-common` group (likely due to a copy-paste mistake). PR Close #46589
2022-06-29 07:58:29 +00:00
- files.include("packages/core/schematics/*")
ci: add codeowner group for migrations (#36661) Adds a new codeowner group that is dedicated for changes to the migrations stored in `packages/core/schematics`. PR Close #36661
2020-04-16 23:27:33 +02:00
reviewers:
users:
- alxhub
- crisbeto
ci: re-activate "devversion" in pullapprove after OOO (#41352) After being OOO for a while, I have been denoted as OOO in the pullapprove configuration (by commenting out the username in the reviewer lists). See 3ba97ab3917b682b6d08b9e71599051e77e2d3ac. This re-activates `devversion` in the pullapprove configuration. PR Close #41352
2021-03-26 20:34:34 +01:00
- devversion
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- dylhunn
ci: Add members to fw-migrations pullapprove group (#52378) This adds jessicajaniuk and AndrewKushnir to the fw-migrations reviewers list. PR Close #52378
2023-10-25 14:35:55 -04:00
- jessicajaniuk
- AndrewKushnir
ci: add codeowner group for migrations (#36661) Adds a new codeowner group that is dedicated for changes to the migrations stored in `packages/core/schematics`. PR Close #36661
2020-04-16 23:27:33 +02:00
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Framework: Core
# =========================================================
fw-core:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
ci: fix pullapprove `fnmatch` patterns due to recent changes (#46589) We recently changed our pullapprove config to work with hidden directories. As part of that, we accidentally invalidated some other pattern parameters due to inconsistency in Pullapprove. e.g. contains any globs uses wcmatch, while `files.exclude` and `files.include` uses `fnmatch`. The current fnmatch patterns are actual wcmatch glob patterns and need to be adjusted for `fnmatch`. As part of this fix (which ensures groups are more correct again), this commit also cleans up some unused `file.exclude` in the `fw-common` group (likely due to a copy-paste mistake). PR Close #46589
2022-06-29 07:58:29 +00:00
contains_any_globs(files.exclude("packages/core/schematics/*"), [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/core/**/{*,.*}',
'packages/examples/core/**/{*,.*}',
'packages/platform-browser/**/{*,.*}',
'packages/examples/platform-browser/**/{*,.*}',
'packages/platform-browser-dynamic/**/{*,.*}',
'packages/docs/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/accessibility.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/accessibility/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/architecture-components.md',
'aio/content/guide/architecture-modules.md',
'aio/content/guide/architecture-next-steps.md',
'aio/content/guide/architecture-services.md',
'aio/content/guide/architecture.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/architecture/**/{*,.*}',
docs: Introduce RxJS and Signals interop guide (#50039) Create a new Signals section on aio, and add an interop guide. PR Close #50039
2023-04-27 00:11:57 -07:00
'aio/content/guide/rxjs-interop.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/images/guide/architecture/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/attribute-directives.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/attribute-directives/**/{*,.*}',
'aio/content/images/guide/attribute-directives/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/bootstrapping.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/bootstrapping/**/{*,.*}',
docs: add the change detection guide to the navigation and pullapprove (#45880) PR Close #45880
2022-05-04 15:56:03 -07:00
'aio/content/guide/change-detection.md',
'aio/content/guide/change-detection-zone-pollution.md',
'aio/content/guide/change-detection-slow-computations.md',
'aio/content/guide/change-detection-skipping-subtrees.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/images/guide/change-detection/**/{*,.*}',
docs: class-binding created as a separate task-based doc (#45897) Class and style binding was pulled out of Attribute, class, and style binding doc and put in its own doc. Content edited with the assistance of the SME. Prerequisites and What's next sections were added. PR Close #45897
2021-11-06 00:05:39 +00:00
'aio/content/guide/class-binding.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/cheatsheet.md',
'aio/content/guide/component-interaction.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/component-interaction/**/{*,.*}',
'aio/content/images/guide/component-interaction/**/{*,.*}',
docs: Add Component Overview topic to angular.io (#39186) PR Close #39186
2020-10-06 16:52:53 -07:00
'aio/content/guide/component-overview.md',
ci: move error pages outside of the `public-api` group (#49770) Currently, a change in an error guide triggers a review for the `public-api` group (requests 3 reviewers and al least 2 must approve). This is overly aggressive and we can relax this by moving the guides under `fw-core` and extended diagnistics under `fw-compiler`. In this case 1 reviewer would be requested. PR Close #49770
2023-04-10 12:27:06 -07:00
'aio/content/errors/*.md',
'aio/content/examples/errors/**/{*,.*}',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/component-overview/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/component-styles.md',
docs: add two new overview pages: developer-guide-overview and understanding-angular-overview (#44091) PR Close #44091
2021-11-05 22:59:54 +00:00
'aio/content/guide/developer-guide-overview.md',
docs: Migrate section, view encapsulation, from Component Styles topic into its own topic. (#38986) PR Close #38986
2020-09-24 20:30:13 +00:00
'aio/content/guide/view-encapsulation.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/component-styles/**/{*,.*}',
'aio/content/examples/content-projection/**/{*,.*}',
docs: initial commit of content projection topic. (#41143) Content projection is an important part of Angular. However, it has never been documented in the Angular documentation set. This topic attempts to provide the basics of content projection for developers. It is not a comprehensive guide; rather, it is a starting point that we can hopefully expand upon in the future. PR Close #41143
2021-03-10 00:25:18 +00:00
'aio/content/guide/content-projection.md',
docs: update dependency injection content (#44466) Refactored the DI section to improve doc quality, reduce cognitive load and drive consistency. - Added an overview with prerequisites and doc cards that point to rest of the DI content - Added introduction topic with topic purpose, value proposition and "fail fast" - Broke apart complex concepts into simpler tasks - Unified tone and language for each topic - Added new content based on SME feedback - Deleted obsolete content PR Close #44466
2021-11-29 23:15:42 +00:00
'aio/content/guide/creating-injectable-service.md',
'aio/content/guide/dependency-injection-overview.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/dependency-injection.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/dependency-injection/**/{*,.*}',
'aio/content/images/guide/dependency-injection/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/dependency-injection-in-action.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/dependency-injection-in-action/**/{*,.*}',
'aio/content/images/guide/dependency-injection-in-action/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/dependency-injection-navtree.md',
'aio/content/guide/dependency-injection-providers.md',
docs: Improve documentation about Injection context / inject (#49782) Injection context has gain public visibility with the exposure of `inject`. Lets provide some insights. Closes #49774 PR Close #49782
2023-04-11 13:37:59 +02:00
'aio/content/guide/dependency-injection-context.md',
docs: add lightweight token page to library section of docs (#36144) adds new DI technique recommendation for libraries to ensure tree-shaking for unused services includes reasons for packaging schematics with libraries, clarify schematic usage recommendation PR Close #36144
2020-03-19 08:40:36 -07:00
'aio/content/guide/lightweight-injection-tokens.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/displaying-data.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/displaying-data/**/{*,.*}',
'aio/content/images/guide/displaying-data/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/dynamic-component-loader.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/dynamic-component-loader/**/{*,.*}',
'aio/content/images/guide/dynamic-component-loader/**/{*,.*}',
docs: add doc with list of example apps currently in aio (#39295) PR Close #39295
2020-10-15 17:06:04 -04:00
'aio/content/guide/example-apps-list.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/feature-modules.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/feature-modules/**/{*,.*}',
'aio/content/images/guide/feature-modules/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/frequent-ngmodules.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/images/guide/frequent-ngmodules/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/hierarchical-dependency-injection.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/hierarchical-dependency-injection/**/{*,.*}',
docs: add image directive guide (#47155) PR Close #47155
2022-08-23 20:00:58 +00:00
'aio/content/guide/image-directive.md',
'aio/content/guide/image-directive-setup.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/providers-viewproviders/**/{*,.*}',
'aio/content/examples/resolution-modifiers/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/lazy-loading-ngmodules.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/lazy-loading-ngmodules/**/{*,.*}',
'aio/content/images/guide/lazy-loading-ngmodules/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/lifecycle-hooks.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/lifecycle-hooks/**/{*,.*}',
'aio/content/images/guide/lifecycle-hooks/**/{*,.*}',
'aio/content/examples/ngcontainer/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/ngmodules.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/ngmodules/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/ngmodule-api.md',
'aio/content/guide/ngmodule-faq.md',
'aio/content/guide/ngmodule-vs-jsmodule.md',
'aio/content/guide/module-types.md',
docs: add template overview doc (#45897) Organize bottom list into cards. PR Close #45897
2022-05-05 22:49:15 +00:00
'aio/content/guide/template-overview.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/template-syntax.md',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/built-in-template-functions.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/built-in-template-functions/**/{*,.*}',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/event-binding.md',
docs: edit event-binding doc copy and headers (#38903) PR Close #38903
2020-09-18 16:43:40 -04:00
'aio/content/guide/event-binding-concepts.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/event-binding/**/{*,.*}',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/interpolation.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/interpolation/**/{*,.*}',
'aio/content/examples/template-syntax/**/{*,.*}',
'aio/content/images/guide/template-syntax/**/{*,.*}',
docs: new binding overview doc (#45897) New binding overview doc. Content derived from existing docs. Make changes suggested in PR for binding overview doc. Deleted bottom paragraph from Binding overview per comments made by atscott and alxhub. PR Close #45897
2022-04-07 00:12:12 +00:00
'aio/content/guide/binding-overview.md',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/binding-syntax.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/binding-syntax/**/{*,.*}',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/property-binding.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/property-binding/**/{*,.*}',
docs: edit property binding doc (#38799) This commit edits the property binding doc copy and adds some docregions to clarify explanations. PR Close #38799
2020-09-10 17:06:39 -04:00
'aio/content/guide/property-binding-best-practices.md',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/attribute-binding.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/attribute-binding/**/{*,.*}',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/two-way-binding.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/two-way-binding/**/{*,.*}',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/built-in-directives.md',
docs: add host directives guide (#48057) PR Close #48057
2022-11-14 12:59:15 -08:00
'aio/content/guide/directive-composition-api.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/built-in-directives/**/{*,.*}',
'aio/content/images/guide/built-in-directives/**/{*,.*}',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/template-reference-variables.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/template-reference-variables/**/{*,.*}',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/inputs-outputs.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/inputs-outputs/**/{*,.*}',
'aio/content/images/guide/inputs-outputs/**/{*,.*}',
docs: new Template expressions overview doc (#45897) Create a new Template expressions overview doc in the Understanding... format. PR Close #45897
2022-03-31 21:33:16 +00:00
'aio/content/guide/understanding-template-expr-overview.md',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/template-expression-operators.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/template-expression-operators/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/pipes.md',
docs: new Pipes custom data doc (#45505) PR Close #45505
2022-04-01 23:51:25 +00:00
'aio/content/guide/pipes-custom-data-trans.md',
docs: Understanding pipes new doc (#45897) New overview file using the Understanding… format. The original Pipes document was considered too long and was broken down into several separate topics. Content edited with the assistance of the SME. PR Close #45897
2022-02-10 18:42:59 +00:00
'aio/content/guide/pipes-overview.md',
docs: Migrate pipe guide and its code examples to standalone (#51333) **Pipes Sample Code** Migrated all sample code in the `examples/pipes` folder. Did not touch the pipes in the ToH or Testing folders. >The existing, complex discussion of the `CurrencyPipe` within `pipes-transform-data.md` cried out for a new `concurrency-formatting.component` example`. **Extracted "pipe precedence" into its own page** The topic had been extracted from `pipe.md` and tacked on to the bottom of the `pipes-overview.md` page. It's an advanced and somewhat obscure topic that doesn't belong in the overview. Rather than throw it away, I created a new `pipe-precedence.md` page and added it to the bottom of the pipes section navigation. I also tried to improve both the guide text and the companion component, `precedence.component`. **How to create a pipe is missing** The readers are told they can create their own pipes in several places throughout the docs. But there are no links and you can't navigate to a page that covers the topic. This is a serious omission! The topic is introduced in the `pipes-custom-data-trans.md` page (extracted verbatim from `pipes.md`). But you can't navigate to this page and their are no links to it. TODO: restore this page and add it to the left-nav. **Change `pipes.md` references to `pipe-overview.md`** The original, kitchen-sink page, `pipes.md`, was disconnected from navigation long ago, in favor of multiple pages such as `pipe-overview.md`. The page is still in the AIO documentation and can be found by searching or by links from 3rd party documenters. Landing on that page hides the left-nav. In this commit, we treat `pipes.md` as deprecated (which it seems to be). Therefore, this commit retargets previous `pipes.md` references to `pipe-overview.md`. >The `change-detection-slow-computations.md` is the exception. It refers to "pure pipes", a subject not covered in the current pipe documentation. That reference is retargeted to `api/core/Pipe#pure`. Certain code files are only referenced in `pipe.md`. They still work and are displayed in the overall pipes code sample as before. Now they are marked with deprecation comments for future treatment or removal. For consistency, certain sections of `pipes.md` were replaced by the contents of the corresponding current pages. PR Close #51333
2023-08-09 23:34:27 -07:00
'aio/content/guide/pipe-precedence.md',
docs: Pipes transform data new doc (#45897) New Transforming data with pipes document. Content taken from the original Pipes document. Content edited with the assistance of the SME. PR Close #45897
2022-02-10 19:07:59 +00:00
'aio/content/guide/pipes-transform-data.md',
docs: new Pipes in templates doc (#45897) New using a Pipe in a template document. Content taken from the original Pipes document. Content edited with the assistance of the SME. PR Close #45897
2022-04-07 23:54:15 +00:00
'aio/content/guide/pipe-template.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/pipes/**/{*,.*}',
'aio/content/images/guide/pipes/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/providers.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/providers/**/{*,.*}',
'aio/content/images/guide/providers/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/singleton-services.md',
'aio/content/guide/sharing-ngmodules.md',
docs: add guide to standalone components preview (#46058) Add a new page in developers guide section with the general overview of the standalone components, directives and pipes Additional APIs (bootstrapApplication, router, DI) as also covered. PR Close #46058
2022-05-19 11:00:16 +02:00
'aio/content/guide/standalone-components.md',
docs: add guide for standalone migration (#49044) Adds a guide describing how to use the standalone migration schematic. The new guide is grouped together with the existing standalone guide. PR Close #49044
2023-02-16 23:30:02 +01:00
'aio/content/guide/standalone-migration.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/structural-directives.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/structural-directives/**/{*,.*}',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/svg-in-templates.md',
docs: edit attribute-binding doc and move colSpan note to property binding (#38860) This commit edits the copy of the attribute binding documentation, moves the colspan section that is primarily about property binding to the property binding document, and adds a docregion to the attribute-binding example to help clarify a point in the document. Part of the copy edit reformats the style precedence list in tabular format so that it is easier to read and understand. PR Close #38860
2020-09-14 17:12:32 -04:00
'aio/content/guide/style-precedence.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/images/guide/structural-directives/**/{*,.*}',
docs: separate template syntax into multiple docs (#36954) This is part of a re-factor of template syntax and structure. The first phase breaks out template syntax into multiple documents. The second phase will be a rewrite of each doc. Specifically, this PR does the following: - Breaks sections of the current template syntax document each into their own page. - Corrects the links to and from these new pages. - Adds template syntax subsection to the left side NAV which contains all the new pages. - Adds the new files to pullapprove. PR Close #36954
2020-04-28 16:26:58 -04:00
'aio/content/guide/template-statements.md',
docs: add two new overview pages: developer-guide-overview and understanding-angular-overview (#44091) PR Close #44091
2021-11-05 22:59:54 +00:00
'aio/content/guide/understanding-angular-overview.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/user-input.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/user-input/**/{*,.*}',
'aio/content/images/guide/user-input/**/{*,.*}',
docs(core): describe interactions between view-encapsulated components (#42397) This commit adds information to the view encapsulation guide that describes the styling interactions between components that use differing view encapsulation modes. Closes #40715 PR Close #42397
2021-05-27 21:27:38 +01:00
'aio/content/guide/view-encapsulation.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/view-encapsulation/**/{*,.*}',
'aio/content/images/guide/view-encapsulation/**/{*,.*}',
docs: add hydration guide (#49665) This adds a guide for how to use hydration in Angular. PR Close #49665
2023-03-31 17:08:26 -04:00
'aio/content/special-elements/**/{*,.*}',
docs(docs-infra): add support for block syntax to dgeni (#52123) This adds the new block syntax to dgeni docs pipeline, mainly copying the way that elements (`<ng-content>` etc.) work. Actual doc content is just a placeholder for this PR. PR Close #52123
2023-10-09 17:21:45 -07:00
'aio/content/blocks/**/{*,.*}',
docs(core): primary Angular Signals documentation (#50053) Adds the developer preview signals guide to AIO, under the preview section. This guide explains signals, computed properties, and effects. PR Close #50053
2023-04-27 14:24:11 -07:00
'aio/content/guide/hydration.md',
docs: Add defer guide (#52380) This adds a user guide for how to use defer. PR Close #52380
2023-10-24 17:45:08 -04:00
'aio/content/guide/defer.md',
docs(core): clarify InjectionToken usage (#51386) - Emphasized the importance of using the same InjectionToken instance for both provider and injection call. - Added examples to illustrate correct usages to prevent NullInjectorError. PR Close #51386
2023-08-16 12:10:01 -04:00
'aio/content/guide/signals.md',
docs: guide for the built-in control flow (#52369) This change adds a dedicated developer guide for the built-in control flow. PR Close #52369
2023-10-25 13:15:16 +02:00
'aio/content/guide/control_flow.md',
docs(core): clarify InjectionToken usage (#51386) - Emphasized the importance of using the same InjectionToken instance for both provider and injection call. - Added examples to illustrate correct usages to prevent NullInjectorError. PR Close #51386
2023-08-16 12:10:01 -04:00
'aio/content/examples/injection-token/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
- alxhub
- AndrewKushnir
refactor(dev-infra): add atscott for fw-core approvers (#37020) Add atscott (Andrew Scott) to the list of approvers in the fw-core section of the .pullapprove.yml file. PR Close #37020
2020-05-08 11:36:24 -07:00
- atscott
build: update PullApprove config (#49878) Updates the PullApprove config to add myself to `fw-compiler` and `fw-core` with the following reasoning: * We talked about `fw-compiler` some time ago, because it would help with TypeScript updates and because I'm familiar with the compiler. * Also adding myself to `fw-core` to make it easier with some upcoming features and because I can help with the review load for the runtime changes. PR Close #49878
2023-04-17 09:03:44 +02:00
- crisbeto
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- dylhunn
docs(core): add jessicajaniuk to pullapprove list (#39473) This just adds jessicajessica to the pullapprove.yml file PR Close #39473
2020-10-28 10:05:57 -07:00
- jessicajaniuk
ci: Update availability for pullapprove (#44312) Follows the v3 pullapprove docs here: https://docs.pullapprove.com/config/availability/ PR Close #44312
2021-11-30 09:55:05 -08:00
- pkozlowski-opensource
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
Revert "Revert "ci: update pullapprove config to add comp labels"" (#40059) This reverts commit c88e8141abb411bd955e29f2670b9e2c204cce1a. This reverts the revert that undid the doing of the pull approve approval. PR Close #40059
2020-12-09 15:15:41 -08:00
# =========================================================
# Framework: Common
# =========================================================
fw-common:
<<: *defaults
conditions:
- >
ci: fix pullapprove `fnmatch` patterns due to recent changes (#46589) We recently changed our pullapprove config to work with hidden directories. As part of that, we accidentally invalidated some other pattern parameters due to inconsistency in Pullapprove. e.g. contains any globs uses wcmatch, while `files.exclude` and `files.include` uses `fnmatch`. The current fnmatch patterns are actual wcmatch glob patterns and need to be adjusted for `fnmatch`. As part of this fix (which ensures groups are more correct again), this commit also cleans up some unused `file.exclude` in the `fw-common` group (likely due to a copy-paste mistake). PR Close #46589
2022-06-29 07:58:29 +00:00
contains_any_globs(files.exclude("packages/common/http/*"), [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/common/**/{*,.*}',
'packages/examples/common/**/{*,.*}',
Revert "Revert "ci: update pullapprove config to add comp labels"" (#40059) This reverts commit c88e8141abb411bd955e29f2670b9e2c204cce1a. This reverts the revert that undid the doing of the pull approve approval. PR Close #40059
2020-12-09 15:15:41 -08:00
])
reviewers:
users:
- alxhub
- AndrewKushnir
- atscott
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- dylhunn
Revert "Revert "ci: update pullapprove config to add comp labels"" (#40059) This reverts commit c88e8141abb411bd955e29f2670b9e2c204cce1a. This reverts the revert that undid the doing of the pull approve approval. PR Close #40059
2020-12-09 15:15:41 -08:00
- jessicajaniuk
ci: Update availability for pullapprove (#44312) Follows the v3 pullapprove docs here: https://docs.pullapprove.com/config/availability/ PR Close #44312
2021-11-30 09:55:05 -08:00
- pkozlowski-opensource
Revert "Revert "ci: update pullapprove config to add comp labels"" (#40059) This reverts commit c88e8141abb411bd955e29f2670b9e2c204cce1a. This reverts the revert that undid the doing of the pull approve approval. PR Close #40059
2020-12-09 15:15:41 -08:00
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Framework: Http
# =========================================================
fw-http:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/common/http/**/{*,.*}',
'packages/examples/http/**/{*,.*}',
docs: add new files for HTTP content (#47684) PR Close #47684
2022-10-07 00:06:43 +00:00
'aio/content/guide/understanding-communicating-with-http.md',
'aio/content/guide/http-configure-http-url-parameters.md',
'aio/content/guide/http-handle-request-errors.md',
'aio/content/guide/http-intercept-requests-and-responses.md',
'aio/content/guide/http-interceptor-use-cases.md',
'aio/content/guide/http-make-jsonp-request.md',
'aio/content/guide/http-optimize-server-interaction.md',
'aio/content/guide/http-pass-metadata-to-interceptors.md',
'aio/content/guide/http-request-data-from-server.md',
'aio/content/guide/http-security-xsrf-protection.md',
'aio/content/guide/http-send-data-to-server.md',
docs: New document extracted from the original Communicating with backend services using HTTP document, which is to be retired. (#47937) PR Close #47937
2022-11-02 00:47:39 +00:00
'aio/content/guide/http-server-communication.md',
docs: add new files for HTTP content (#47684) PR Close #47684
2022-10-07 00:06:43 +00:00
'aio/content/guide/http-setup-server-communication.md',
'aio/content/guide/http-test-requests.md',
'aio/content/guide/http-track-show-request-progress.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/http/**/{*,.*}',
'aio/content/images/guide/http/**/{*,.*}'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
- alxhub
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- AndrewKushnir
- atscott
- dylhunn
- jessicajaniuk
- pkozlowski-opensource
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Framework: Elements
# =========================================================
fw-elements:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/elements/**/{*,.*}',
'aio/content/examples/elements/**/{*,.*}',
'aio/content/images/guide/elements/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/elements.md'
])
reviewers:
users:
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- alxhub
- AndrewKushnir
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
- andrewseguin
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- atscott
- dylhunn
- jessicajaniuk
- pkozlowski-opensource
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Framework: Forms
# =========================================================
fw-forms:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/forms/**/{*,.*}',
'packages/examples/forms/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/forms.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/forms/**/{*,.*}',
'aio/content/images/guide/forms/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/forms-overview.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/forms-overview/**/{*,.*}',
'aio/content/images/guide/forms-overview/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/form-validation.md',
docs: Add a guide for typed forms. (#45939) Create a new page, which describes the basic features of the new reactive forms types, and describes how to migrate to them. PR Close #45939
2022-05-09 18:15:06 -07:00
'aio/content/guide/typed-forms.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/form-validation/**/{*,.*}',
'aio/content/images/guide/form-validation/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/dynamic-form.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/dynamic-form/**/{*,.*}',
'aio/content/images/guide/dynamic-form/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/reactive-forms.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/reactive-forms/**/{*,.*}',
'aio/content/images/guide/reactive-forms/**/{*,.*}'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
- AndrewKushnir
ci: add dylhunn to review groups for forms. (#44204) This is needed so I can review forms PRs that affect public API. PR Close #44204
2021-11-17 15:29:23 -08:00
- dylhunn
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Framework: i18n
# =========================================================
fw-i18n:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/core/src/i18n/**/{*,.*}',
'packages/core/src/render3/i18n/**/{*,.*}',
fix(dev-infra): update i18n-related file locations in PullApprove config (#38403) The changes in https://github.com/angular/angular/pull/38368 split `render3/i18n.ts` files into smaller scripts, but the PullApprove config was not updated to reflect that. This commit updates the PullApprove config to reflect the recent changes in i18n-related files. PR Close #38403
2020-08-10 15:15:24 -07:00
'packages/core/src/render3/instructions/i18n.ts',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'packages/core/src/render3/interfaces/i18n.ts',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/common/locales/**/{*,.*}',
'packages/common/src/i18n/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'packages/common/src/pipes/date_pipe.ts',
'packages/common/src/pipes/i18n_plural_pipe.ts',
'packages/common/src/pipes/i18n_select_pipe.ts',
'packages/common/src/pipes/number_pipe.ts',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/compiler/src/i18n/**/{*,.*}',
'packages/compiler/src/render3/view/i18n/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'packages/compiler-cli/src/extract_i18n.ts',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/localize/**/{*,.*}',
docs: add subtopics for internationalization to PR (#43245) Add subtopics for internationalization guide to PR. PR Close #43245
2021-09-13 15:20:30 -07:00
'aio/content/guide/i18n-overview.md',
docs: update internationalization topics (#43722) Add new $localize and Ivy content. Clean up navigation. PR Close #43722
2021-10-05 08:54:06 -07:00
'aio/content/guide/i18n-common-overview.md',
docs: add subtopics for internationalization to PR (#43245) Add subtopics for internationalization guide to PR. PR Close #43245
2021-09-13 15:20:30 -07:00
'aio/content/guide/i18n-common-add-package.md',
'aio/content/guide/i18n-common-locale-id.md',
'aio/content/guide/i18n-common-format-data-locale.md',
'aio/content/guide/i18n-common-prepare.md',
'aio/content/guide/i18n-common-translation-files.md',
'aio/content/guide/i18n-common-merge.md',
'aio/content/guide/i18n-common-deploy.md',
'aio/content/guide/i18n-example.md',
docs: update internationalization topics (#43722) Add new $localize and Ivy content. Clean up navigation. PR Close #43722
2021-10-05 08:54:06 -07:00
'aio/content/guide/i18n-optional-overview.md',
'aio/content/guide/i18n-optional-manual-runtime-locale.md',
docs: add subtopics for internationalization to PR (#43245) Add subtopics for internationalization guide to PR. PR Close #43245
2021-09-13 15:20:30 -07:00
'aio/content/guide/i18n-optional-import-global-variants.md',
'aio/content/guide/i18n-optional-manage-marked-text.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/i18n/**/{*,.*}'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
- AndrewKushnir
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- dgp1130
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Framework: Platform Server
# =========================================================
fw-platform-server:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/platform-server/**/{*,.*}',
docs(platform-server): added commands for universal and add prerendering info (#36005) Fixes #36004 PR Close #36005
2021-05-31 01:18:23 +05:30
'aio/content/guide/prerendering.md',
docs: update SSR doc to reflect version 17 (#52398) Changes to SSR doc PR Close #52398
2023-10-26 16:17:34 +00:00
'aio/content/guide/ssr.md',
'aio/content/examples/ssr/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
ci: add myself to `fw-platform-server` reviewers (#42265) Add `alan-agius4` as `platform-server` reviewer. PR Close #42265
2021-05-24 10:00:02 +02:00
- alan-agius4
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
- alxhub
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- AndrewKushnir
- atscott
- dylhunn
- jessicajaniuk
- pkozlowski-opensource
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Framework: Router
# =========================================================
fw-router:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/router/**/{*,.*}',
'packages/examples/router/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/router.md',
docs: Add new section, tutorials, to left nav, and a tutorial on routing (#36545) This PR adds a new section, tutorials, to the left navigation. It also adds a new, basic tutorial for routing. PR Close #36545
2020-04-09 17:43:26 +00:00
'aio/content/guide/router-tutorial.md',
docs: Move router tutorial (toh) from router.md to new file (#37979) In an effort to make angular documentation easier for users to read, we are moving the router tutorial currently in router.md to a new file. To support this change, we have done the following: * Update files to fix any broken links caused by moving the file * Updated the new file to follow tutorial guidelines * Add the new file to the table of contents under, Tutorials. PR Close #37979
2020-07-08 15:29:41 +00:00
'aio/content/guide/router-tutorial-toh.md',
docs: move all existing router documentation into a single location and add two new topics: an overview and a reference (#41972) PR Close #41972
2021-05-06 21:28:54 +00:00
'aio/content/guide/routing-overview.md',
'aio/content/guide/router-reference.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/router-tutorial/**/{*,.*}',
'aio/content/examples/router/**/{*,.*}',
'aio/content/images/guide/router/**/{*,.*}',
docs: add new tutorial that explains how to use the UrlMatcher for custom route matching (#42138) PR Close #42138
2021-05-17 23:04:08 +00:00
'aio/content/guide/routing-with-urlmatcher.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/routing-with-urlmatcher/**/{*,.*}'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- AndrewKushnir
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
- atscott
# =========================================================
# Framework: Service Worker
# =========================================================
build: fix typo in PullApprove group name (server-worker --> service-worker) (#36325) PR Close #36325
2020-03-30 17:35:21 +03:00
fw-service-worker:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/service-worker/**/{*,.*}',
'packages/examples/service-worker/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/service-worker-getting-started.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/service-worker-getting-started/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/app-shell.md',
'aio/content/guide/service-worker-communications.md',
'aio/content/guide/service-worker-config.md',
'aio/content/guide/service-worker-devops.md',
'aio/content/guide/service-worker-intro.md',
feat(service-worker): add `openWindow`, `focusLastFocusedOrOpen` and `navigateLastFocusedOrOpen` (#42520) Add `openWindow`, `focusLastFocusedOrOpen` and `navigateLastFocusedOrOpen` abilty to the notificationclick handler such that when either a notification or notification action is clicked the service-worker can act accordinly without the need for the app to be open PR Close #26907 PR Close #42520
2021-06-08 16:59:33 +01:00
'aio/content/guide/service-worker-notifications.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/images/guide/service-worker/**/{*,.*}'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
- alxhub
# =========================================================
# Framework: Upgrade
# =========================================================
fw-upgrade:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/upgrade/**/{*,.*}',
'packages/common/upgrade/**/{*,.*}',
'packages/examples/upgrade/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/upgrade.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/upgrade-lazy-load-ajs/**/{*,.*}',
'aio/content/examples/upgrade-module/**/{*,.*}',
'aio/content/images/guide/upgrade/**/{*,.*}',
'aio/content/examples/upgrade-phonecat-1-typescript/**/{*,.*}',
'aio/content/examples/upgrade-phonecat-2-hybrid/**/{*,.*}',
'aio/content/examples/upgrade-phonecat-3-final/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/upgrade-performance.md',
'aio/content/guide/upgrade-setup.md',
'aio/content/guide/ajs-quick-reference.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/ajs-quick-reference/**/{*,.*}'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- alxhub
- jessicajaniuk
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Framework: Testing
# =========================================================
fw-testing:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
ci: fix pullapprove `fnmatch` patterns due to recent changes (#46589) We recently changed our pullapprove config to work with hidden directories. As part of that, we accidentally invalidated some other pattern parameters due to inconsistency in Pullapprove. e.g. contains any globs uses wcmatch, while `files.exclude` and `files.include` uses `fnmatch`. The current fnmatch patterns are actual wcmatch glob patterns and need to be adjusted for `fnmatch`. As part of this fix (which ensures groups are more correct again), this commit also cleans up some unused `file.exclude` in the `fw-common` group (likely due to a copy-paste mistake). PR Close #46589
2022-06-29 07:58:29 +00:00
contains_any_globs(files.exclude('packages/compiler-cli/*').exclude('packages/language-service/*').exclude('packages/service-worker/*'), [
'packages/**/testing/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/testing.md',
docs: break testing doc into multiple docs (#37957) This commit breaks up the testing document into nine total documents, with each document focusing on an existing section of the current testing documentation. There are no content changes. PR Close #37957
2020-06-30 14:14:34 -04:00
'aio/content/guide/test-debugging.md',
'aio/content/guide/testing-attribute-directives.md',
'aio/content/guide/testing-code-coverage.md',
'aio/content/guide/testing-components-basics.md',
'aio/content/guide/testing-components-scenarios.md',
'aio/content/guide/testing-pipes.md',
'aio/content/guide/testing-services.md',
'aio/content/guide/testing-utility-apis.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/testing/**/{*,.*}',
'aio/content/images/guide/testing/**/{*,.*}'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- alxhub
build: add AndrewKushnir to the `fw-testing` group (#36744) This commit update the PullApprove config to add AndrewKushnir to the `fw-testing` group. The reason for this change is that I was involved into TestBed rewrite (for Ivy) and it belongs to the `fw-testing` group ownership. PR Close #36744
2020-04-21 11:47:52 -07:00
- AndrewKushnir
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- atscott
- dylhunn
ci: add jessicajaniuk to pullapprove groups (#44255) This adds jessicajaniuk to fw-animations and fw-testing. PR Close #44255
2021-11-23 16:38:00 -08:00
- jessicajaniuk
ci: Update availability for pullapprove (#44312) Follows the v3 pullapprove docs here: https://docs.pullapprove.com/config/availability/ PR Close #44312
2021-11-30 09:55:05 -08:00
- pkozlowski-opensource
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 16:10:50 -08:00
# =========================================================
# Framework: Benchmarks
# =========================================================
fw-benchmarks:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 16:10:50 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'modules/benchmarks/**/{*,.*}'
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 16:10:50 -08:00
])
reviewers:
users:
ci: update owners for fw-benchmarks (#44304) Add alxhub and jelbourn to owners for fw-benchmarks group. PR Close #44304
2021-11-29 11:24:30 -08:00
- alxhub
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- AndrewKushnir
- atscott
- dylhunn
- jessicajaniuk
ci: Update availability for pullapprove (#44312) Follows the v3 pullapprove docs here: https://docs.pullapprove.com/config/availability/ PR Close #44312
2021-11-30 09:55:05 -08:00
- pkozlowski-opensource
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 16:10:50 -08:00
# =========================================================
# Framework: Playground
# =========================================================
fw-playground:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 16:10:50 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'modules/playground/**/{*,.*}'
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 16:10:50 -08:00
])
reviewers:
users:
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- alxhub
- AndrewKushnir
- atscott
- dylhunn
- jessicajaniuk
ci: Update availability for pullapprove (#44312) Follows the v3 pullapprove docs here: https://docs.pullapprove.com/config/availability/ PR Close #44312
2021-11-30 09:55:05 -08:00
- pkozlowski-opensource
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 16:10:50 -08:00
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Framework: Security
# =========================================================
fw-security:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/core/src/sanitization/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'packages/core/test/linker/security_integration_spec.ts',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/compiler/src/schema/**/{*,.*}',
'packages/platform-browser/src/security/**/{*,.*}',
build: Enable tsec checks for critical packages. (#43108) tsec is a static analyzer that discovers Trusted Types violations. Deploy tsec to make sure there will be no TT regression in several critical packages, including core, platform-browser, platform-server and their dependencies. Existing violations have been reviewed and exempted in packages/tsec-exemption.json. Future changes to the exemption list requires security review. PR Close #43108
2021-08-10 23:00:20 +00:00
'packages/tsconfig-tsec-base.json',
build: Turn tsec checks into bazel tests. (#43108) Introduce two new bazel rules: tsec_test and tsec_config, for describing the tsec checks and the tsconfig file needed for such checks, respectively. Currently, tsec_test only checks the srcs of a ts_library or ng_module. It does not check direct or transitive dependencies. Also, tsconfig files need to be manually maintained to make sure tsec can read all necessary input (including global symbols). PR Close #43108
2021-08-13 04:50:34 +00:00
'packages/tsec-exemption.json',
'tools/tsec.bzl',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/security.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/security/**/{*,.*}',
'aio/content/images/guide/security/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- alxhub
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 15:10:13 -07:00
- jelbourn
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- josephperrott
ci: Update availability for pullapprove (#44312) Follows the v3 pullapprove docs here: https://docs.pullapprove.com/config/availability/ PR Close #44312
2021-11-30 09:55:05 -08:00
- pkozlowski-opensource
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 15:10:13 -07:00
reviews:
build: reformat yml files (#42136) Reformat all yml files in the repository. PR Close #42136
2021-05-14 10:54:35 -07:00
request: -1 # request reviews from everyone
required: 2 # require at least 2 approvals
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 15:10:13 -07:00
reviewed_for: required
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Bazel
# =========================================================
bazel:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/bazel/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
ci: add devversion to codeowners for `bazel` (#43431) This commit proposes adding myself to the codeowners for `bazel`. I have made various changes for quite some time to `@angular/bazel` and with the new APF v13 changes, a lot of code was simplified. As one of the primary consumers of `@angular/bazel` (in the name of the Angular components repo), I think it would be reasonable to have an eye on changes to the Bazel package. PR Close #43431
2021-09-28 01:29:55 +02:00
- devversion
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
- josephperrott
# =========================================================
# Language Service
# =========================================================
language-service:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/language-service/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/language-service.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/images/guide/language-service/**/{*,.*}'
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 22:52:49 +02:00
])
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
reviewers:
users:
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- alxhub
ci: add atscott to language-service approvers (#40027) Add myself (atscott) to the list of approvers for language-service PRs. PR Close #40027
2020-12-08 11:07:42 -08:00
- atscott
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# zone.js
# =========================================================
zone-js:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/zone.js/**/{*,.*}',
docs: add documentation of NgZone with zone.js (#34295) PR Close #34295
2019-12-07 23:30:53 +09:00
'aio/content/guide/zone.md'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
- JiaLiPassion
build: import in-memory-web-api project (#37182) Moves the `angular-in-memory-web-api` project into the main repository in order to make it easier to maintain and release. PR Close #37182
2020-06-12 18:25:08 +02:00
# =========================================================
# in-memory-web-api
# =========================================================
in-memory-web-api:
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/misc/angular-in-memory-web-api/**/{*,.*}',
build: import in-memory-web-api project (#37182) Moves the `angular-in-memory-web-api` project into the main repository in order to make it easier to maintain and release. PR Close #37182
2020-06-12 18:25:08 +02:00
])
reviewers:
users:
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- alxhub
- AndrewKushnir
- atscott
build: import in-memory-web-api project (#37182) Moves the `angular-in-memory-web-api` project into the main repository in order to make it easier to maintain and release. PR Close #37182
2020-06-12 18:25:08 +02:00
- crisbeto
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- dylhunn
- jessicajaniuk
- pkozlowski-opensource
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Benchpress
# =========================================================
benchpress:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'packages/benchpress/**/{*,.*}'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
ci: update codeowners for benchpress (#50769) Pawel and myself have investigated benchpress for quite some time now, and I believe we have the most up-to-date understanding in the team- so it would make sense to add us to the owners. PR Close #50769
2023-06-19 14:15:44 +00:00
- devversion
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 15:10:13 -07:00
- josephperrott
ci: update codeowners for benchpress (#50769) Pawel and myself have investigated benchpress for quite some time now, and I believe we have the most up-to-date understanding in the team- so it would make sense to add us to the owners. PR Close #50769
2023-06-19 14:15:44 +00:00
- pkozlowski-opensource
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Integration Tests
# =========================================================
integration-tests:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'integration/**/{*,.*}'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- alxhub
- AndrewKushnir
- atscott
- dylhunn
- jessicajaniuk
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
- josephperrott
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- pkozlowski-opensource
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
ci: add new group to approve contributor list changes (#40368) This commit adds a new `docs-contributors` group (with Emma and Minko as members) which will be used as reviewers for PRs that update the list of contributors. PR Close #40368
2021-01-08 12:18:31 -08:00
# =========================================================
# Docs: Contributors
# =========================================================
docs-contributors:
<<: *defaults
conditions:
- >
contains_any_globs(files, [
'aio/content/marketing/contributors.json',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/images/bios/**/{*,.*}',
ci: add new group to approve contributor list changes (#40368) This commit adds a new `docs-contributors` group (with Emma and Minko as members) which will be used as reviewers for PRs that update the list of contributors. PR Close #40368
2021-01-08 12:18:31 -08:00
])
reviewers:
users:
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- MarkTechson
ci: add new group to approve contributor list changes (#40368) This commit adds a new `docs-contributors` group (with Emma and Minko as members) which will be used as reviewers for PRs that update the list of contributors. PR Close #40368
2021-01-08 12:18:31 -08:00
- mgechev
- twerske
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Docs: Gettings Started & Tutorial
# =========================================================
docs-getting-started-and-tutorial:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
'aio/content/guide/setup-local.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/images/guide/setup-local/**/{*,.*}',
'aio/content/tutorial/**/{*,.*}',
'aio/content/images/guide/toh/**/{*,.*}',
docs: move marketing demo out of tested examples (#48404) PR Close #48404
2022-12-08 08:13:18 -08:00
'aio/content/demos/first-app/**/{*,.*}',
docs: add first-app-lesson-01 example (#48512) PR Close #48512
2022-12-14 08:03:35 -08:00
'aio/content/examples/first-app-*/**/{*,.*}',
docs: update the intro page (#49980) Update the introduction page to include a link to the new tutorial and to remove links to the other tutorials to give learners a clearer path forward. Also, add files to pull approve. PR Close #49980
2023-04-28 15:51:35 -07:00
'aio/content/images/guide/faa/**/{*,.*}',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/toh-pt0/**/{*,.*}',
'aio/content/examples/toh-pt1/**/{*,.*}',
'aio/content/examples/toh-pt2/**/{*,.*}',
'aio/content/examples/toh-pt3/**/{*,.*}',
'aio/content/examples/toh-pt4/**/{*,.*}',
'aio/content/examples/toh-pt5/**/{*,.*}',
'aio/content/examples/toh-pt6/**/{*,.*}',
'aio/content/examples/getting-started-v0/**/{*,.*}',
'aio/content/examples/getting-started/**/{*,.*}',
'aio/content/start/**/{*,.*}',
docs: update of landing page and backup pages (#47047) Updates the angular.io landing page with new messaging and new images. The Quick-start app has been updated to demonstrate a minimalist Angular app and the value proposition content has been updated. PR Close #47047
2022-07-15 15:27:02 -07:00
'aio/content/guide/quick-start.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/images/guide/start/**/{*,.*}',
'aio/content/examples/what-is-angular/**/{*,.*}',
docs: add what is angular topic (#40811) PR Close #40811
2021-02-08 18:45:18 +00:00
'aio/content/guide/what-is-angular.md'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- AndrewKushnir
- jessicajaniuk
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Docs: Marketing
# =========================================================
docs-marketing:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
ci: add new group to approve contributor list changes (#40368) This commit adds a new `docs-contributors` group (with Emma and Minko as members) which will be used as reviewers for PRs that update the list of contributors. PR Close #40368
2021-01-08 12:18:31 -08:00
contains_any_globs(files.exclude("aio/content/marketing/contributors.json"), [
docs: update of landing page and backup pages (#47047) Updates the angular.io landing page with new messaging and new images. The Quick-start app has been updated to demonstrate a minimalist Angular app and the value proposition content has been updated. PR Close #47047
2022-07-15 15:27:02 -07:00
'aio/content/examples/marketing-first-app/**/{*,.*}',
docs: add a page with the Angular roadmap (#38358) PR Close #38358
2020-08-04 20:47:29 +03:00
'aio/content/guide/roadmap.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/marketing/**/{*,.*}',
'aio/content/images/marketing/**/{*,.*}',
ci: add missing codeowners for `aio/` files (#34988) PR Close #34988
2020-01-27 12:51:17 +02:00
'aio/content/file-not-found.md',
'aio/content/license.md',
'aio/content/navigation.json'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- MarkTechson
ci: add mgechev to docs-marketing approvers (#40396) Add mgechev to docs-marketing approvals to allow approval of aio changes PR Close #40396
2021-01-11 12:55:40 -08:00
- mgechev
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- twerske
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Docs: Observables
# =========================================================
docs-observables:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
'aio/content/guide/observables.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/observables/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/comparing-observables.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/comparing-observables/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/observables-in-angular.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/observables-in-angular/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/practical-observable-usage.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/practical-observable-usage/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/rx-library.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/rx-library/**/{*,.*}'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
- alxhub
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- atscott
- dylhunn
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Docs: Packaging, Tooling, Releasing
# =========================================================
docs-packaging-and-releasing:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 16:10:50 -08:00
'docs/PUBLIC_API.md',
'docs/RELEASE_SCHEDULE.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/npm-packages.md',
'aio/content/guide/browser-support.md',
'aio/content/guide/releases.md',
'aio/content/guide/updating.md',
'aio/content/guide/deprecations.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/deprecation-guide/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/migration-module-with-providers.md',
'aio/content/guide/static-query-migration.md',
docs: add latest version content (#43964) Add the update to latest version content for version 13. Add redirect for latest version content. Update toc for later version content. PR Close #43964
2021-10-27 10:29:07 -07:00
'aio/content/guide/update-to-latest-version.md',
docs(docs-infra): add versions document to code owners (#48753) PR Close #48753
2023-01-18 20:45:09 +01:00
'aio/content/guide/versions.md',
docs: add info about v15 changes and update process (#47951) PR Close #47951
2022-11-09 08:40:22 -08:00
'aio/content/guide/update-to-version-14.md',
docs: add v16 update guide (#50073) PR Close #50073
2023-04-28 15:19:10 -07:00
'aio/content/guide/update-to-version-15.md',
'aio/content/guide/update-to-version-16.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- alxhub
ci: add more reviewers to the `docs-packaging-and-releasing` group (#45652) Currently that group has just 2 reviewers, but we often update the files that belong to that group during the deprecation period. Adding more people would allow to balance the reviews better. PR Close #45652
2022-04-15 13:03:10 -07:00
- AndrewKushnir
- atscott
ci: Add members to fw-migrations pullapprove group (#52378) This adds jessicajaniuk and AndrewKushnir to the fw-migrations reviewers list. PR Close #52378
2023-10-25 14:35:55 -04:00
- jessicajaniuk
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 15:10:13 -07:00
- jelbourn
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
ci: rename the angular devtools pullapprove name (#42160) Change `devtools` to `docs-devtools` to properly reflect the approval group. PR Close #42160
2021-05-18 15:44:06 -07:00
# =========================================================
# Docs: Angular DevTools
# =========================================================
docs-devtools:
<<: *defaults
conditions:
- >
contains_any_globs(files, [
'aio/content/guide/devtools.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/images/guide/devtools/**/{*,.*}'
ci: rename the angular devtools pullapprove name (#42160) Change `devtools` to `docs-devtools` to properly reflect the approval group. PR Close #42160
2021-05-18 15:44:06 -07:00
])
reviewers:
users:
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- MarkTechson
ci: rename the angular devtools pullapprove name (#42160) Change `devtools` to `docs-devtools` to properly reflect the approval group. PR Close #42160
2021-05-18 15:44:06 -07:00
- mgechev
- twerske
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
ci: special case tooling-cli-shared-api review group (#37467) The new tooling-cli-shared-api is used to guard changes to packages/compiler-cli/src/tooling.ts which is a private API sharing channel between Angular FW and CLI. Changes to this file should be rare and explicitly approved by at least two members of the CLI team. PR Close #37467
2020-06-05 16:27:53 -07:00
# =========================================================
# Tooling: Compiler API shared with Angular CLI
#
# Changing this API might break Angular CLI, so we require
# the CLI team to approve changes here.
# =========================================================
tooling-cli-shared-api:
conditions:
- >
contains_any_globs(files, [
refactor(compiler-cli): expose tooling code through `private` entry-point (#43431) Similar to the other private entry-points we have added for localize, bazel or the migrations, we should expose the tooling code through a dedicated private export. This will make the compiler-cli exports more consistent and it will become easier for the CLI to export necessary code. PR Close #43431
2021-09-30 19:37:11 +02:00
'packages/compiler-cli/private/tooling.ts',
refactor: expose new `@angular/localize/tools` entry-point for CLI usage (#43431) This wires up the `@angular/localize/tools` entry-point. For context: This entry-point is being created to avoid deep imports into `@angular/localize/src/tools/<..>` like the CLI relies on. Deep imports do not play well with strict ESM, and now that all APF packages are strict ESM, the tool code needs to be either strict ESM as well. We use ESBuild to create individual bundles for the CLI entry-points, and the actual tool entry-point. We use a bundler because this enables the localize code be ESM compatible. Without a bundler, all relative imports within the `tools` entry-point would need to explicitly have the `.js` extension. This would be cumbersome and hard to maintain/enforce or validate. One might wonder why this is not a standard APF entry-point then. The answer is that the APF entry-points do not support exposing the CLI binaries (like `yarn localize-translate`). This could be done through tertiary entry-points, but using ESBuild directly gives us more control for now. We might want to revisit this in the future again. PR Close #43431
2021-09-24 19:19:11 +02:00
'packages/localize/tools/index.ts'
ci: special case tooling-cli-shared-api review group (#37467) The new tooling-cli-shared-api is used to guard changes to packages/compiler-cli/src/tooling.ts which is a private API sharing channel between Angular FW and CLI. Changes to this file should be rare and explicitly approved by at least two members of the CLI team. PR Close #37467
2020-06-05 16:27:53 -07:00
])
reviewers:
users:
- alan-agius4
- clydin
ci: update pullapprove config to reflect kyliau's departure (#43230) Update pullapprove configuration to remove kyliau from groups. PR Close #43230
2021-08-23 10:39:33 -07:00
- dgp1130
ci: special case tooling-cli-shared-api review group (#37467) The new tooling-cli-shared-api is used to guard changes to packages/compiler-cli/src/tooling.ts which is a private API sharing channel between Angular FW and CLI. Changes to this file should be rare and explicitly approved by at least two members of the CLI team. PR Close #37467
2020-06-05 16:27:53 -07:00
reviews:
build: reformat yml files (#42136) Reformat all yml files in the repository. PR Close #42136
2021-05-14 10:54:35 -07:00
request: -1 # request reviews from everyone
required: 2 # require at least 2 approvals
ci: special case tooling-cli-shared-api review group (#37467) The new tooling-cli-shared-api is used to guard changes to packages/compiler-cli/src/tooling.ts which is a private API sharing channel between Angular FW and CLI. Changes to this file should be rare and explicitly approved by at least two members of the CLI team. PR Close #37467
2020-06-05 16:27:53 -07:00
reviewed_for: required
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Docs: CLI
# =========================================================
docs-cli:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/cli/**/{*,.*}',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 22:52:49 +02:00
'aio/content/guide/typescript-configuration.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/setup/**/{*,.*}',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 22:52:49 +02:00
'aio/content/guide/build.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/images/guide/build/**/{*,.*}',
'aio/content/images/guide/cli/**/{*,.*}',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 22:52:49 +02:00
'aio/content/guide/cli-builder.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/cli-builder/**/{*,.*}',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 22:52:49 +02:00
'aio/content/guide/deployment.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/images/guide/deployment/**/{*,.*}',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 22:52:49 +02:00
'aio/content/guide/file-structure.md',
'aio/content/guide/ivy.md',
docs: add strict-mode.md file to pullapprove (#37679) When I created the strict-mode.md file, I didn't add it to the pullapprove list. Now it's there. The issue was introduced in #37486. PR Close #37679
2020-06-23 00:15:10 +00:00
'aio/content/guide/strict-mode.md',
feat(dev-infra): pullapprove verify should handle `files` in conditions (#36661) Currently, when verifying our pullapprove configuration, we don't respect modifications to the set of files in a condition. e.g. It's not possible to do the following: ``` contains_any_globs(files.exclude(...), [ ``` This prevents us from having codeowner groups which match a directory, but want to filter out specific sub directories. For example, `fw-core` matches all files in the core package. We want to exclude the schematics from that glob. Usually we do this by another exclude condition. This has a *significant* downside though. It means that fw-core will not be requested if a PR changes schematic code, _and_ actual fw-core code. To support these conditions, the pullapprove verification tool is refactored, so that it no longer uses Regular expressions for parsing, but rather evaluates the code through a dynamic function. This is possible since the conditions are written in simple Python that can be run in NodeJS too (with small modifications/transformations). PR Close #36661
2020-04-16 20:12:25 +02:00
'aio/content/guide/web-worker.md',
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 22:52:49 +02:00
'aio/content/guide/workspace-config.md',
docs: add solution-style tsconfig migration docs (#37512) This adds documentation for the v10.0 tooling migration `solution-style-tsconfig` contained within the `@schematics/angular` package. PR Close #37512
2020-06-08 21:41:50 -04:00
'aio/content/guide/migration-solution-style-tsconfig.md',
docs: add tslib update migration docs (#37402) This adds documentation for the v10.0 tooling migration `update-libraries-tslib` contained within the `@schematics/angular` package. PR Close #37402
2020-06-02 14:37:27 -04:00
'aio/content/guide/migration-update-libraries-tslib.md',
docs: add developer preview guide for esbuild-based build system (#50068) Angular v16 will move the esbuild-based browser application builder from an experimental status to a developer preview status. This newly added guide provides instructions and information regarding the use of the new build system. PR Close #50068
2023-04-27 10:42:08 -04:00
'aio/content/guide/esbuild.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
ci: add alan-agius4 to docs-cli in pullapprove configuration (#39448) Add alan-agius4 to `docs-cli` group in pullapprove configuration. PR Close #39448
2020-10-27 14:22:31 +01:00
- alan-agius4
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
- clydin
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- dgp1130
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
- mgechev
# =========================================================
# Docs: CLI Libraries
# =========================================================
docs-libraries:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
docs: improve consuming partial-Ivy code outside the Angular CLI (#44027) With this change we add an example of how to consume the linker plugin and also clean up the parts of this section. Closes #44026 PR Close #44027
2021-11-03 09:10:50 +01:00
'aio/content/examples/angular-linker-plugin/webpack.config.mjs',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/creating-libraries.md',
'aio/content/guide/libraries.md',
docs: initial commit of Angular Package Format documentation (#43987) This commit adds the Angular Package Format to AIO. Previously this document was updated and versioned in Google Docs. The document is also updated for the Angular Package Format version 13. PR Close #43987
2021-10-29 15:30:32 -07:00
'aio/content/guide/using-libraries.md',
'aio/content/guide/angular-package-format.md'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
- alan-agius4
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- alxhub
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
- mgechev
# =========================================================
# Docs: Schematics
# =========================================================
docs-schematics:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
'aio/content/guide/schematics.md',
'aio/content/guide/schematics-authoring.md',
'aio/content/guide/schematics-for-libraries.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/images/guide/schematics/**/{*,.*}',
'aio/content/examples/schematics-for-libraries/**/{*,.*}'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
- alan-agius4
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- dylhunn
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
- mgechev
docs: add angular.dev (#52536) PR Close #52536
2023-11-06 08:42:56 -08:00
# =========================================================
# Docs: Angular Dev Site
# =========================================================
angular-dev:
<<: *defaults
conditions:
- >
contains_any_globs(files, [
'adev/**/{.*,*}'
])
reviewers:
users:
- twerske
- josephperrott
- jelbourn
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Docs-infra
# =========================================================
docs-infra:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/{*,.*}',
'aio/aio-builds-setup/**/{*,.*}',
'aio/content/cli-src/**/{*,.*}',
'aio/content/examples/{*,.*}',
'aio/scripts/**/{*,.*}',
'aio/src/**/{*,.*}',
'aio/tests/**/{*,.*}',
'aio/tools/**/{*,.*}',
'aio/tools/examples/shared/boilerplate/cli/.vscode/**/{*,.*}',
build(bazel): incrementally build aio example zips and live examples The existing scripts were amended to work on one example at a time
2022-06-02 15:18:34 -07:00
'aio/content/BUILD.bazel',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/images/guide/contributors-guide/**/{*,.*}',
docs: add contributors guide to aio (#41061) PR Close #41061
2021-03-03 00:05:34 +00:00
'aio/content/guide/contributors-guide-overview.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/docs-style-guide.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/docs-style-guide/**/{*,.*}',
'aio/content/images/guide/docs-style-guide/**/{*,.*}',
docs: add more documentation about lint messages (#47019) Adds suggestions for how to resolve the most common messages produced by the documentation linter. Adds links to the Proselint and other style tests to the new documentation. Updates pullapprove and navigation. PR Close #47019
2022-08-01 16:33:29 -07:00
'aio/content/guide/docs-lint-errors.md',
'aio/content/images/guide/docs-lint-errors/**/{*,.*}',
docs: add guidelines for localizing angular documentation (#43314) PR Close #43314
2021-09-01 23:06:41 +00:00
'aio/content/guide/localized-documentation.md',
'aio/content/guide/localizing-angular.md',
ci: remove redundant entries from `.pullapprove.yml` (#41250) This commit removes some entries from `.pullapprove.yml` that do not correspond to existing files on disk. PR Close #41250
2021-03-17 20:46:56 +02:00
'aio/content/guide/reviewing-content.md',
'aio/content/guide/updating-content-github-ui.md',
'aio/content/guide/updating-search-keywords.md',
docs: update of documentation contrib. guide (#47381) This update describes the content authoring and revision process in sufficient detail for technical and non-technical contributors to the angular.io documentation. PR Close #47381
2022-08-17 15:44:54 -07:00
'aio/content/guide/doc-build-test.md',
'aio/content/guide/doc-edit-finish.md',
'aio/content/guide/doc-editing.md',
'aio/content/guide/doc-github-tasks.md',
'aio/content/guide/doc-pr-open.md',
'aio/content/guide/doc-pr-prep.md',
'aio/content/guide/doc-pr-update.md',
'aio/content/guide/doc-prepare-to-edit.md',
'aio/content/guide/doc-select-issue.md',
'aio/content/guide/doc-tasks.md',
'aio/content/guide/doc-update-overview.md',
'aio/content/guide/doc-update-start.md',
'aio/content/guide/docs-lint-errors.md',
'aio/content/images/guide/preparing-to-edit-docs/**/{*,.*}',
'aio/content/images/guide/github-for-docs/**/{*,.*}',
'aio/content/images/guide/doc-update-start/**/{*,.*}',
'aio/content/images/guide/doc-update-overview/**/{*,.*}',
'aio/content/images/guide/doc-pr-update/**/{*,.*}',
'aio/content/images/guide/doc-pr-prep/**/{*,.*}',
'aio/content/images/guide/doc-pr-open/**/{*,.*}',
'aio/content/images/guide/doc-github-tasks/**/{*,.*}',
'aio/content/images/guide/doc-prepare-to-edit/**/{*,.*}',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
build: Add Jessica and Andrew K to docs-infra (#46843) This adds two people to the docs-infra pullapprove group. PR Close #46843
2022-07-14 15:26:26 -07:00
- AndrewKushnir
- jessicajaniuk
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- josephperrott
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
ci: add angular devtools to pullapprove config Creates new section in pullapprove for angular devtools
2021-11-23 22:10:11 -05:00
# =========================================================
# Angular DevTools
# =========================================================
devtools:
<<: *defaults
conditions:
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'devtools/**/{*,.*}',
ci: add angular devtools to pullapprove config Creates new section in pullapprove for angular devtools
2021-11-23 22:10:11 -05:00
])
reviewers:
users:
build: fix AleksanderBodurri to be the correct capitalization in pullapprove config (#47483) Fix AleksanderBodurri username. PR Close #47483
2022-09-19 15:49:58 +00:00
- AleksanderBodurri
ci: sort devtools pullapprove reviewers in alphabetical order Previously this list was not in any order. This commit puts the reviewer list in alphabetical order to be consistent with how other groups order reviewers
2022-01-21 12:59:46 -05:00
- devversion
refactor: add `dgp1130` to DevTools PullApprove config (#51301) DevTools falls under Angular Tooling and I'll probably be reviewing future PRs for the extension. PR Close #51301
2023-08-08 15:53:24 -07:00
- dgp1130
ci: sort devtools pullapprove reviewers in alphabetical order Previously this list was not in any order. This commit puts the reviewer list in alphabetical order to be consistent with how other groups order reviewers
2022-01-21 12:59:46 -05:00
- josephperrott
ci: add angular devtools to pullapprove config Creates new section in pullapprove for angular devtools
2021-11-23 22:10:11 -05:00
- mgechev
- twerske
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Dev-infra
# =========================================================
dev-infra:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
ci: do not match dev-infra group for pullapprove owner changes (#47216) Back when we fixed the pullapprove verify command and our config to properly include dot-prefixed files, we accidentally started matching the pullapprove file in the dev-infra group. This commit fixes this so that dev-infra is not triggered for basic code owner config changes. PR Close #47216
2022-08-22 12:31:21 +00:00
contains_any_globs(files.exclude('.pullapprove.yml'), [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'{*,.*}',
'.circleci/**/{*,.*}',
'.devcontainer/**/{*,.*}',
'.github/**/{*,.*}',
'.husky/**/{*,.*}',
'.ng-dev/**/{*,.*}',
'.vscode/**/{*,.*}',
'.yarn/**/{*,.*}',
docs: add guide for branching process (#39924) PR Close #39924
2020-12-01 18:46:55 -08:00
'docs/*.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'docs/images/**/{*,.*}',
'goldens/{*,.*}',
ci: change ownership of `goldens/public-api/manage.js` (#43664) With this change we change ownership of `goldens/public-api/manage.js` from `public-api` to `dev-infra`. This file is a script to manage public-api golden files and therefore it should fall under the dev-infra umbrella. PR Close #43664
2021-10-01 12:22:57 +02:00
'goldens/public-api/manage.js',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'modules/{*,.*}',
'packages/{*,.*}',
'packages/examples/test-utils/**/{*,.*}',
'packages/private/**/{*,.*}',
'packages/examples/{*,.*}',
'scripts/**/{*,.*}',
'third_party/**/{*,.*}',
'tools/bazel-repo-patches/**/{*,.*}',
'tools/circular_dependency_test/**/{*,.*}',
'tools/contributing-stats/**/{*,.*}',
build: create NodeJS ESM loader for supporting Bazel setup (#48521) Replaces the existing ESM loader for dealing with external module imports. This loader was introduced by Aspect for AIO `.mjs` scripts. The loader will be used as foundation for a more extensive loader that also properly handles first-party packages. Additionally another loader is added, all packed as a single loader because our current NodeJS version only supports a single loader per node invocation. So we implement chaining ourselves. The new loader will attempt rewriting `.js` extensions to `.mjs`, also it will add `.mjs` if not already done. This is necessary in the transition phase because we don't/cannot use explicit `.mts` extensions and also we don't specify extensions in imports yet. Long-term we would likely use `.mts` and explicit import extensions, but it's not yet clear how we would sync this into g3 too. PR Close #48521
2022-12-06 13:57:06 +00:00
'tools/esm-interop/**/{*,.*}',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'tools/gulp-tasks/**/{*,.*}',
'tools/legacy-saucelabs/**/{*,.*}',
build: add rules for generating block/element API data (#52480) Adds build rules for "artificially" generating `DocEntry` collections for block and element APIs. The two rules are very similar, but _just_ different enough that it's worth having two separate implementations. PR Close #52480
2023-10-31 18:02:22 -07:00
'tools/manual_api_docs/**/{*,.*}',
build: update dependency jasmine to v5 (#51820) The patch is to fix upstream bug in `@bazel/jasmine`. See: bazelbuild/rules_nodejs#3691 PR Close #51820
2023-09-19 11:28:53 +00:00
'tools/npm-patches/**/{*,.*}',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'tools/rxjs/**/{*,.*}',
build: share Saucelabs browsers between karma test targets using background Saucelabs daemon and custom karma launcher (#49200) This upgrades the Saucelabs Bazel step on CI to use the more efficient Saucelabs daemon PR Close #49200
2023-02-20 12:37:34 -08:00
'tools/saucelabs-daemon/**/{*,.*}',
build: add rules for generating block/element API data (#52480) Adds build rules for "artificially" generating `DocEntry` collections for block and element APIs. The two rules are very similar, but _just_ different enough that it's worth having two separate implementations. PR Close #52480
2023-10-31 18:02:22 -07:00
'tools/saucelabs/**/{*,.*}',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'tools/symbol-extractor/**/{*,.*}',
'tools/testing/**/{*,.*}',
'tools/tslint/**/{*,.*}',
'tools/utils/**/{*,.*}',
'tools/yarn/**/{*,.*}',
'tools/{*,.*}',
ci: remove *.bazel from dev-infra ownership (#41382) Historically all .bazel files were owned by dev-infra to assist in ensuring that consistency was maintained in how rules were being used. As this now has reached a point of maturity in the repository where the check is mostly a rubber stamping, this requirement can be removed. Notably this is different than the requirement of dev-infra approval for .bzl files as these contain the implementation of macros rather than just the usage. PR Close #41382
2021-03-30 11:38:09 -07:00
'**/*.bzl'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
ci: re-activate "devversion" in pullapprove after OOO (#41352) After being OOO for a while, I have been denoted as OOO in the pullapprove configuration (by commenting out the username in the reviewer lists). See 3ba97ab3917b682b6d08b9e71599051e77e2d3ac. This re-activates `devversion` in the pullapprove configuration. PR Close #41352
2021-03-26 20:34:34 +01:00
- devversion
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
- josephperrott
# =========================================================
# Public API
# =========================================================
public-api:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
Revert "ci: roll back phased review conditions" (#38259) This reverts commit ca8eafc2983f983803cd03e4a08bf732672712dd. PR Close #38259
2020-07-27 17:15:42 -07:00
- *no-groups-above-this-pending
- *no-groups-above-this-rejected
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
- >
ci: change ownership of `goldens/public-api/manage.js` (#43664) With this change we change ownership of `goldens/public-api/manage.js` from `public-api` to `dev-infra`. This file is a script to manage public-api golden files and therefore it should fall under the dev-infra umbrella. PR Close #43664
2021-10-01 12:22:57 +02:00
contains_any_globs(files.exclude("goldens/public-api/manage.js"), [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'goldens/public-api/**/{*,.*}',
ci: update pullapprove.yml to cover all files in the repo (#35072) PR Close #35072
2020-01-30 16:10:50 -08:00
'docs/NAMING.md',
docs: initial commit of Angular Package Format documentation (#43987) This commit adds the Angular Package Format to AIO. Previously this document was updated and versioned in Google Docs. The document is also updated for the Angular Package Format version 13. PR Close #43987
2021-10-29 15:30:32 -07:00
'aio/content/guide/angular-package-format.md',
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
'aio/content/guide/glossary.md',
'aio/content/guide/styleguide.md',
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'aio/content/examples/styleguide/**/{*,.*}',
'aio/content/images/guide/styleguide/{*,.*}'
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
])
reviewers:
users:
ci: add more owners for limited categories (#38170) * Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to #37994 PR Close #38170
2020-07-21 18:43:05 -07:00
- AndrewKushnir
ci: add more owners for some categories (#37994) * Add petebacondarwin to public-api, size-tracking, and circular-dependencies * Add mhevery, josephperrott, and jelbourn to code-ownership PR Close #37994
2020-07-15 11:47:26 -07:00
- alxhub
ci: add more owners for limited categories (#38170) * Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to #37994 PR Close #38170
2020-07-21 18:43:05 -07:00
- atscott
ci: add dylhunn to review groups for size, piblic api, minimum, and circular (#44190) This is needed so I can review forms PRs that affect public API. PR Close #44190
2021-11-16 10:10:13 -08:00
- dylhunn
build: don't assign jelbourn to most review categories (#45668) Configure pullapprove to not automatically assign jelbourn to most review categories. PR Close #45668
2022-04-18 09:29:19 -07:00
- ~jelbourn
ci: add jessicajaniuk to pullapprove groups (#40176) This adds jessicajaniuk to size-tracking, public-api, and circular-dependencies. PR Close #40176
2020-12-17 10:37:32 -08:00
- jessicajaniuk
ci: Update availability for pullapprove (#44312) Follows the v3 pullapprove docs here: https://docs.pullapprove.com/config/availability/ PR Close #44312
2021-11-30 09:55:05 -08:00
- pkozlowski-opensource
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 15:10:13 -07:00
reviews:
ci: decrease the number of required `public-api` and `size-tracking` reviews (#45855) This commit updates the PullApprove config to decrease the number of required reviews from `public-api` and `size-tracking` group members. PR Close #45855
2022-05-03 11:02:21 -07:00
request: 3 # Request reviews from 3 people
required: 2 # Require that 2 people approve
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 15:10:13 -07:00
reviewed_for: required
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# ================================================
# Size tracking
# ================================================
size-tracking:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
Revert "ci: roll back phased review conditions" (#38259) This reverts commit ca8eafc2983f983803cd03e4a08bf732672712dd. PR Close #38259
2020-07-27 17:15:42 -07:00
- *no-groups-above-this-pending
- *no-groups-above-this-rejected
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
- >
contains_any_globs(files, [
ci: fix pullapprove to match hidden files and directories (#46520) After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: https://github.com/angular/dev-infra/pull/642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
2022-06-27 16:28:45 +00:00
'goldens/size-tracking/**/{*,.*}'
ci: minor PullApprove fixes/improvements (#35015) This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015
2020-01-28 22:52:49 +02:00
])
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
reviewers:
users:
ci: add more owners for some categories (#37994) * Add petebacondarwin to public-api, size-tracking, and circular-dependencies * Add mhevery, josephperrott, and jelbourn to code-ownership PR Close #37994
2020-07-15 11:47:26 -07:00
- alxhub
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- AndrewKushnir
ci: add more owners for limited categories (#38170) * Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to #37994 PR Close #38170
2020-07-21 18:43:05 -07:00
- atscott
ci: add dylhunn to review groups for size, piblic api, minimum, and circular (#44190) This is needed so I can review forms PRs that affect public API. PR Close #44190
2021-11-16 10:10:13 -08:00
- dylhunn
build: don't assign jelbourn to most review categories (#45668) Configure pullapprove to not automatically assign jelbourn to most review categories. PR Close #45668
2022-04-18 09:29:19 -07:00
- ~jelbourn
ci: add jessicajaniuk to pullapprove groups (#40176) This adds jessicajaniuk to size-tracking, public-api, and circular-dependencies. PR Close #40176
2020-12-17 10:37:32 -08:00
- jessicajaniuk
ci: Update availability for pullapprove (#44312) Follows the v3 pullapprove docs here: https://docs.pullapprove.com/config/availability/ PR Close #44312
2021-11-30 09:55:05 -08:00
- pkozlowski-opensource
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 15:10:13 -07:00
reviews:
ci: decrease the number of required `public-api` and `size-tracking` reviews (#45855) This commit updates the PullApprove config to decrease the number of required reviews from `public-api` and `size-tracking` group members. PR Close #45855
2022-05-03 11:02:21 -07:00
request: 2 # Request reviews from 2 people
required: 1 # Require that 1 person approve
ci: extend and update the reviewer groups (#37467) Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
2020-06-05 15:10:13 -07:00
reviewed_for: required
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
ci: set up golden file for typescript circular dependencies (#35647) Sets up a golden file for the TypeScript circular dependencies for source files inside of the `packages/` folder. Also sets up the appropriate Yarn shorthand scripts, and a codeowner group that is soley responsible for verifying changes to the golden. PR Close #35647
2020-02-24 12:08:24 +01:00
# ================================================
# Circular dependencies
# ================================================
circular-dependencies:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: set up golden file for typescript circular dependencies (#35647) Sets up a golden file for the TypeScript circular dependencies for source files inside of the `packages/` folder. Also sets up the appropriate Yarn shorthand scripts, and a codeowner group that is soley responsible for verifying changes to the golden. PR Close #35647
2020-02-24 12:08:24 +01:00
conditions:
Revert "ci: roll back phased review conditions" (#38259) This reverts commit ca8eafc2983f983803cd03e4a08bf732672712dd. PR Close #38259
2020-07-27 17:15:42 -07:00
- *no-groups-above-this-pending
- *no-groups-above-this-rejected
ci: set up golden file for typescript circular dependencies (#35647) Sets up a golden file for the TypeScript circular dependencies for source files inside of the `packages/` folder. Also sets up the appropriate Yarn shorthand scripts, and a codeowner group that is soley responsible for verifying changes to the golden. PR Close #35647
2020-02-24 12:08:24 +01:00
- >
contains_any_globs(files, [
build: move circular deps golden to a subfolder (#36630) Moves the circular deps golden for packages into a subfolder of goldens, `/goldens/circular-deps/` to more easily target the files for ownership. PR Close #36630
2020-04-14 13:37:54 -07:00
'goldens/circular-deps/packages.json'
ci: set up golden file for typescript circular dependencies (#35647) Sets up a golden file for the TypeScript circular dependencies for source files inside of the `packages/` folder. Also sets up the appropriate Yarn shorthand scripts, and a codeowner group that is soley responsible for verifying changes to the golden. PR Close #35647
2020-02-24 12:08:24 +01:00
])
reviewers:
users:
ci: add more owners for limited categories (#38170) * Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to #37994 PR Close #38170
2020-07-21 18:43:05 -07:00
- alxhub
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- AndrewKushnir
ci: add more owners for limited categories (#38170) * Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to #37994 PR Close #38170
2020-07-21 18:43:05 -07:00
- atscott
ci: add dylhunn to review groups for size, piblic api, minimum, and circular (#44190) This is needed so I can review forms PRs that affect public API. PR Close #44190
2021-11-16 10:10:13 -08:00
- dylhunn
build: don't assign jelbourn to most review categories (#45668) Configure pullapprove to not automatically assign jelbourn to most review categories. PR Close #45668
2022-04-18 09:29:19 -07:00
- ~jelbourn
ci: add jessicajaniuk to pullapprove groups (#40176) This adds jessicajaniuk to size-tracking, public-api, and circular-dependencies. PR Close #40176
2020-12-17 10:37:32 -08:00
- jessicajaniuk
ci: Update availability for pullapprove (#44312) Follows the v3 pullapprove docs here: https://docs.pullapprove.com/config/availability/ PR Close #44312
2021-11-30 09:55:05 -08:00
- pkozlowski-opensource
ci: set up golden file for typescript circular dependencies (#35647) Sets up a golden file for the TypeScript circular dependencies for source files inside of the `packages/` folder. Also sets up the appropriate Yarn shorthand scripts, and a codeowner group that is soley responsible for verifying changes to the golden. PR Close #35647
2020-02-24 12:08:24 +01:00
build: reformat yml files (#42136) Reformat all yml files in the repository. PR Close #42136
2021-05-14 10:54:35 -07:00
####################################################################################
# Special Cases
####################################################################################
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
# =========================================================
# Code Ownership
# =========================================================
code-ownership:
ci: include PR author as an approver of all PRs (#36915) This change adds an implicit approval for any change by the PR author. This allows for a PR author to provide the required owner approval for an area of the code base. This change helps to align the review methodology with how Google's internal system works. Where anyone is able to provide the LGTM for a change if thats all that is needed. PR Close #36915
2020-05-04 08:20:24 -07:00
<<: *defaults
ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
2020-01-16 08:39:09 -08:00
conditions:
- >
contains_any_globs(files, [
'.pullapprove.yml'
])
reviewers:
users:
ci: add more owners for limited categories (#38170) * Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to #37994 PR Close #38170
2020-07-21 18:43:05 -07:00
- alxhub
ci: update pullapprove groups (#44340) This updates all of the pullapprove file to properly reference current members. PR Close #44340
2021-12-01 14:52:55 -08:00
- AndrewKushnir
- andrewseguin
- dgp1130
build: don't assign jelbourn to most review categories (#45668) Configure pullapprove to not automatically assign jelbourn to most review categories. PR Close #45668
2022-04-18 09:29:19 -07:00
- ~jelbourn
ci: Add jessicajaniuk to code-ownership pullapprove group (#48426) Add Jessica to the code-ownership group to allow approve PullApprove config changes. PR Close #48426
2022-12-09 13:20:20 -08:00
- jessicajaniuk
ci: add more owners for some categories (#37994) * Add petebacondarwin to public-api, size-tracking, and circular-dependencies * Add mhevery, josephperrott, and jelbourn to code-ownership PR Close #37994
2020-07-15 11:47:26 -07:00
- josephperrott
build: refactor global approvals to be done via overrides, adding dev-infra global approvers (#44866) Add dev-infra global approver support and change global approval management to be done via overrides. By using overrides to determine global approval status, we can safely ignore the concept of global approval in all of the other group management. PR Close #44866
2022-01-27 15:32:20 -08:00
####################################################################################
# Override managed result groups
#
# Groups which are only used to determine the value of an override are managed at
# the bottom of the list as they will set a status on the PR directly, they
# therefore can always be process last without concern.
####################################################################################
# =========================================================
# Global Approvers
#
# All reviews performed for global approvals require using
# the `Reviewed-for:` specifier to set the approval
# specificity as documented at:
# https://docs.pullapprove.com/reviewed-for/
# =========================================================
global-approvers:
type: optional
reviewers:
teams:
- framework-global-approvers
reviews:
request: 0
required: 1
reviewed_for: required
# =========================================================
# Global Approvers For Docs
#
# All reviews performed for global docs approvals require
# using the `Reviewed-for:` specifier to set the approval
# specificity as documented at:
# https://docs.pullapprove.com/reviewed-for/
# =========================================================
global-docs-approvers:
type: optional
reviewers:
teams:
- framework-global-approvers-for-docs-only-changes
reviews:
request: 0
required: 1
reviewed_for: required
# =========================================================
# Global Approvers For Dev-Infra changes
#
# All reviews performed for global dev-infra approvals
# require using the `Reviewed-for:` specifier to set the
# approval specificity as documented at:
# https://docs.pullapprove.com/reviewed-for/
# =========================================================
global-dev-infra-approvers:
type: optional
reviewers:
teams:
- dev-infra-framework
reviews:
request: 0
required: 1
reviewed_for: required
# =========================================================
# Require review on all PRs
#
# All PRs require at least one review. This rule will not
# request any reviewers, however will require that at least
# one review is provided before the group is satisfied.
# =========================================================
required-minimum-review:
reviews:
request: 0 # Do not request any reviews from the reviewer group
required: 1 # Require that all PRs have approval from at least one of the users in the group
author_value: 0 # The author of the PR cannot provide an approval for themself
reviewed_for: ignored # All reviews apply to this group whether noted via Reviewed-for or not
reviewers:
users:
- alan-agius4 # Alan Agius
build: fix AleksanderBodurri to be the correct capitalization in pullapprove config (#47483) Fix AleksanderBodurri username. PR Close #47483
2022-09-19 15:49:58 +00:00
- AleksanderBodurri # Aleksander Bodurri
build: refactor global approvals to be done via overrides, adding dev-infra global approvers (#44866) Add dev-infra global approver support and change global approval management to be done via overrides. By using overrides to determine global approval status, we can safely ignore the concept of global approval in all of the other group management. PR Close #44866
2022-01-27 15:32:20 -08:00
- alxhub # Alex Rickabaugh
- AndrewKushnir # Andrew Kushnir
- andrewseguin # Andrew Seguin
- atscott # Andrew Scott
- clydin # Charles Lyding
- crisbeto # Kristiyan Kostadinov
- devversion # Paul Gschwendtner
- dgp1130 # Doug Parker
- dylhunn # Dylan Hunn
- jelbourn # Jeremy Elbourn
- jessicajaniuk # Jessica Janiuk
- JiaLiPassion # Jia Li
- JoostK # Joost Koehoorn
- josephperrott # Joey Perrott
- MarkTechson # Mark Thompson (Techson)
- mgechev # Minko Gechev
- mmalerba # Miles Malerba
- pkozlowski-opensource # Pawel Kozlowski
- twerske # Emma Twersky
- zarend # Zach Arend
Reference in New Issue Copy Permalink