mirror of
https://github.com/alirezarezvani/claude-skills.git
synced 2026-09-19 03:31:11 +08:00
40fa75258a
Addresses the review observation on #993: the compiled skill's authoring-notes.json carried only a `source` block (how it was built) even though its content is derived from an external MIT-licensed work, where the rest of the repo uses an `attribution` block for that. check_plugin_json.py's NOTES_ALLOWED permits both keys, so the two coexist. Adds `attribution` to engineering/spinning-up-deep-rl following the shape used by book-to-skill and skillopt-sleep: derived_from, upstream_docs, upstream_path, original_author, original_license, original_copyright, derivation_note. The emitter is deliberately NOT changed to synthesise this. It knows only `--source-note` free text and a rights basis -- not an upstream URL, author or licence -- and a half-filled attribution block is worse than none. Instead Step 11 of conversion_workflow.md now says attribution is added by hand whenever `--rights` is anything but internal-docs, names the field shape, and restates that the actual obligation is the LICENSE notice and README credit -- authoring-notes.json is metadata Claude Code never reads, and a sidecar JSON file is not a licence notice. Gates re-run clean: check_plugin_json --all, check_paths, check_frontmatter, check_dual_publish, check_model_freshness, smoke_scripts (692/692), derive_counters --check, book_skill_validator --strict. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UySnyf5upm4y8xhYA3w6yw