From a4ae7518674ccfe6c5cd91353eef49046030e930 Mon Sep 17 00:00:00 2001 From: Addy Osmani Date: Sun, 21 Jun 2026 12:08:48 -0700 Subject: [PATCH] docs(code-review): disambiguate file-size signal from diff-size threshold The file-size paragraph used "1000 total lines" adjacent to the "~1000 lines changed" diff threshold, which let readers conflate "diff too large" with "file too large". Spell out the distinction inline and reframe total file length as an inspection signal rather than a hard cap. Addresses @federicobartoli's review feedback on #304. --- skills/code-review-and-quality/SKILL.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/skills/code-review-and-quality/SKILL.md b/skills/code-review-and-quality/SKILL.md index a64d2d2..5efda7a 100644 --- a/skills/code-review-and-quality/SKILL.md +++ b/skills/code-review-and-quality/SKILL.md @@ -110,7 +110,7 @@ Small, focused changes are easier to review, faster to merge, and safer to deplo ~1000 lines changed → Too large. Split it. ``` -**Watch file size, not just diff size.** A small diff can still push a file past a healthy boundary — around 1000 total lines is a common smell. When a change materially grows an already-large file, ask whether to extract helpers, subcomponents, or modules *first*, before piling more on. Decompose, then add. +**Watch file size, not just diff size.** A small diff can still push a file past a healthy boundary — around 1000 *total* lines in a single file (distinct from the ~1000 *changed*-lines threshold above) is a common inspection signal, not a hard cap. When a change materially grows an already-large file, ask whether to extract helpers, subcomponents, or modules *first*, before piling more on. Decompose, then add. **What counts as "one change":** A single self-contained modification that addresses one thing, includes related tests, and keeps the system functional after submission. One part of a feature — not the whole feature.